Deprecate the Dir template function

Author: ferranbt

internal/local_runner.go

@@ -457,19 +457,6 @@ func (d *LocalRunner) getService(name string) *Service {
 func (d *LocalRunner) applyTemplate(s *Service) ([]string, map[string]string, error) {
 	var input map[string]interface{}
 
-	// For {{.Dir}}:
-	// - Service runs on host: bind to the output folder
-	// - Service runs inside docker: bind to /artifacts
-	if d.isHostService(s.Name) {
-		input = map[string]interface{}{
-			"Dir": d.out.dst,
-		}
-	} else {
-		input = map[string]interface{}{
-			"Dir": "/artifacts",
-		}
-	}
-
 	resolvePort := func(name string, defaultPort int, protocol string) int {
 		// For {{Port "name" "defaultPort"}}:
 		// - Service runs on host: return the host port
@@ -952,8 +939,9 @@ func CreatePrometheusServices(manifest *Manifest, out *output) error {
 	srv := manifest.NewService("prometheus").
 		WithImage("prom/prometheus").
 		WithTag("latest").
-		WithArgs("--config.file", "{{.Dir}}/prometheus.yaml").
-		WithPort("metrics", 9090, "tcp")
+		WithArgs("--config.file", "/data/prometheus.yaml").
+		WithPort("metrics", 9090, "tcp").
+		WithArtifact("/data/prometheus.yml", "prometheus.yaml")
 	manifest.services = append(manifest.services, srv)
 
 	return nil

internal/manifest.go

@@ -436,9 +436,7 @@ func applyTemplate(templateStr string) (string, []Port, []NodeRef) {
 
 	// use template substitution to load constants
 	// pass-through the Dir template because it has to be resolved at the runtime
-	input := map[string]interface{}{
-		"Dir": "{{.Dir}}",
-	}
+	input := map[string]interface{}{}
 
 	var portRef []Port
 	var nodeRef []NodeRef