|
1 |
| -## PR Overview |
2 |
| -**This PR will address the following Issue/Feature:** |
| 1 | +<!-- |
| 2 | +Pre-Submission Reminders |
| 3 | +Before marking this PR as "ready for review": |
3 | 4 |
|
4 |
| -**This PR will result in the following new package version:** |
5 |
| -<!--- Please add details around your decision for breaking vs non-breaking version upgrade. If this is a breaking change, were backwards-compatible options explored? --> |
| 5 | +- `dbt run --full-refresh && dbt test` |
| 6 | +- `dbt run` && `dbt test` (if incremental models are present) |
| 7 | +- The related issue is linked, tagged, and appropriately assigned |
| 8 | +- Documentation and version updates are included, if applicable |
| 9 | +- `docs` have been regenerated (unless there are no code or YAML changes) |
| 10 | +- BuildKite integration tests are passing |
| 11 | +--> |
6 | 12 |
|
7 |
| -**Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:** |
8 |
| -<!--- Copy/paste the CHANGELOG for this version below. --> |
| 13 | +## PR Overview |
| 14 | +**Package version introduced in this PR:** |
| 15 | + |
| 16 | +**This PR addresses the following Issue/Feature(s):** |
| 17 | +<!-- Add Issue # or internal ticket reference --> |
9 | 18 |
|
10 |
| -## PR Checklist |
11 |
| -### Basic Validation |
12 |
| -Please acknowledge that you have successfully performed the following commands locally: |
13 |
| -- [ ] dbt run –full-refresh && dbt test |
14 |
| -- [ ] dbt run (if incremental models are present) && dbt test |
| 19 | +**Summary of changes:** |
| 20 | +<!-- 1-2 sentences describing PR changes. --> |
15 | 21 |
|
16 |
| -Before marking this PR as "ready for review" the following have been applied: |
17 |
| -- [ ] The appropriate issue has been linked, tagged, and properly assigned |
18 |
| -- [ ] All necessary documentation and version upgrades have been applied |
19 |
| -- [ ] docs were regenerated (unless this PR does not include any code or yml updates) |
20 |
| -- [ ] BuildKite integration tests are passing |
21 |
| -- [ ] Detailed validation steps have been provided below |
22 | 22 |
|
23 |
| -#### ❗ Special Updates for Ad Reporting ❗ |
24 |
| -To reduce integration testing time, not all models should be enabled in the `run_models.sh` vars. Update the variables after `dbt run` and `dbt test` to set: |
25 |
| -- [ ] this PR's package to `true` |
26 |
| -- [ ] Google Ads and Facebook Ads to `true` (if not already) |
27 |
| -- [ ] All other packages to `false` |
| 23 | +### Submission Checklist |
| 24 | +- [ ] Alignment meeting with the reviewer (if needed) |
| 25 | + - [ ] Timeline and validation requirements discussed |
| 26 | +- [ ] Provide validation details: |
| 27 | + - [ ] **Validation Steps:** Check for unintentional effects (e.g., add/run consistency & integrity tests) |
| 28 | + - [ ] **Testing Instructions:** Confirm the change addresses the issue(s) |
| 29 | + - [ ] **Focus Areas:** Complex logic or queries that need extra attention |
28 | 30 |
|
29 |
| -### Detailed Validation |
30 |
| -Please share any and all of your validation steps: |
31 |
| -<!--- Provide the steps you took to validate your changes below. --> |
32 |
| - |
33 |
| -### If you had to summarize this PR in an emoji, which would it be? |
34 |
| -<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) --> |
35 |
| -:dancer: |
| 31 | +### Changelog |
| 32 | +<!-- Recommend drafting changelog notes, then refining via ChatGPT using: |
| 33 | +"Draft a changelog entry based on the following notes." --> |
| 34 | +- [ ] Draft changelog for PR |
| 35 | +- [ ] Final changelog for release review |
0 commit comments