Skip to content

Commit 79d724e

Browse files
fivetran-jamieQMalcolmfivetran-joemarkiewiczfivetran-catfritz
authored
Add geo reports + fold in Google Ads search report (#144)
* country report with name standardization * bk * postgres * seeds and such * Remove extra `endmacro` block in `fivetran_n_days_ago.sql` (#143) * Remove extra `endmacro` block in `fivetran_n_days_ago.sql` For a long time dbt-core has ignored extraneous/orphaned block tags. However, in 1.10 we're going to start issuing a deprecation warning for them. As such, it made sense to get this cleaned up :) * Document orphaned `endmacro` fix in changelog * Bump version to 1.13.1 Only change is a bug fix so, doing a patch release seems appropriate. * bk * region working + moved country mapping to ephemeral model * tests * polishing * polish up * joe feedback * Readme * remove s * Update CHANGELOG.md * quickstart.yml updates * Update CHANGELOG.md Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> * docs regen --------- Co-authored-by: Quigley Malcolm <QMalcolm@users.noreply.github.com> Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
1 parent 6d40324 commit 79d724e

File tree

48 files changed

+2143
-183
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+2143
-183
lines changed

.buildkite/scripts/run_models.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ echo `pwd`
1717
cd integration_tests
1818
dbt deps
1919
dbt seed --target "$db" --full-refresh
20-
dbt run --target "$db" --full-refresh --vars '{ad_reporting__facebook_ads_enabled: true, ad_reporting__google_ads_enabled: true, ad_reporting__amazon_ads_enabled: false, ad_reporting__apple_search_ads_enabled: false, ad_reporting__linkedin_ads_enabled: true, ad_reporting__microsoft_ads_enabled: false, ad_reporting__pinterest_ads_enabled: false, ad_reporting__reddit_ads_enabled: false, ad_reporting__snapchat_ads_enabled: false, ad_reporting__tiktok_ads_enabled: false, ad_reporting__twitter_ads_enabled: false}'
21-
dbt test --target "$db" --vars '{ad_reporting__facebook_ads_enabled: true, ad_reporting__google_ads_enabled: true, ad_reporting__amazon_ads_enabled: false, ad_reporting__apple_search_ads_enabled: false, ad_reporting__linkedin_ads_enabled: true, ad_reporting__microsoft_ads_enabled: false, ad_reporting__pinterest_ads_enabled: false, ad_reporting__reddit_ads_enabled: false, ad_reporting__snapchat_ads_enabled: false, ad_reporting__tiktok_ads_enabled: false, ad_reporting__twitter_ads_enabled: false}'
20+
dbt run --target "$db" --full-refresh --vars '{ad_reporting__facebook_ads_enabled: true, facebook_ads__using_demographics_country: true, facebook_ads__using_demographics_region: true, ad_reporting__google_ads_enabled: true, ad_reporting__amazon_ads_enabled: false, ad_reporting__apple_search_ads_enabled: false, ad_reporting__linkedin_ads_enabled: true, ad_reporting__microsoft_ads_enabled: false, ad_reporting__pinterest_ads_enabled: false, ad_reporting__reddit_ads_enabled: false, ad_reporting__snapchat_ads_enabled: false, ad_reporting__tiktok_ads_enabled: false, ad_reporting__twitter_ads_enabled: false}'
21+
dbt test --target "$db" --vars '{ad_reporting__facebook_ads_enabled: true, facebook_ads__using_demographics_country: true, facebook_ads__using_demographics_region: true, ad_reporting__google_ads_enabled: true, ad_reporting__amazon_ads_enabled: false, ad_reporting__apple_search_ads_enabled: false, ad_reporting__linkedin_ads_enabled: true, ad_reporting__microsoft_ads_enabled: false, ad_reporting__pinterest_ads_enabled: false, ad_reporting__reddit_ads_enabled: false, ad_reporting__snapchat_ads_enabled: false, ad_reporting__tiktok_ads_enabled: false, ad_reporting__twitter_ads_enabled: false}'
2222

2323
dbt run-operation fivetran_utils.drop_schemas_automation --target "$db"
Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,35 @@
1-
## PR Overview
2-
**This PR will address the following Issue/Feature:**
1+
<!--
2+
Pre-Submission Reminders
3+
Before marking this PR as "ready for review":
34
4-
**This PR will result in the following new package version:**
5-
<!--- Please add details around your decision for breaking vs non-breaking version upgrade. If this is a breaking change, were backwards-compatible options explored? -->
5+
- `dbt run --full-refresh && dbt test`
6+
- `dbt run` && `dbt test` (if incremental models are present)
7+
- The related issue is linked, tagged, and appropriately assigned
8+
- Documentation and version updates are included, if applicable
9+
- `docs` have been regenerated (unless there are no code or YAML changes)
10+
- BuildKite integration tests are passing
11+
-->
612

7-
**Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:**
8-
<!--- Copy/paste the CHANGELOG for this version below. -->
13+
## PR Overview
14+
**Package version introduced in this PR:**
15+
16+
**This PR addresses the following Issue/Feature(s):**
17+
<!-- Add Issue # or internal ticket reference -->
918

10-
## PR Checklist
11-
### Basic Validation
12-
Please acknowledge that you have successfully performed the following commands locally:
13-
- [ ] dbt run –full-refresh && dbt test
14-
- [ ] dbt run (if incremental models are present) && dbt test
19+
**Summary of changes:**
20+
<!-- 1-2 sentences describing PR changes. -->
1521

16-
Before marking this PR as "ready for review" the following have been applied:
17-
- [ ] The appropriate issue has been linked, tagged, and properly assigned
18-
- [ ] All necessary documentation and version upgrades have been applied
19-
- [ ] docs were regenerated (unless this PR does not include any code or yml updates)
20-
- [ ] BuildKite integration tests are passing
21-
- [ ] Detailed validation steps have been provided below
2222

23-
#### ❗ Special Updates for Ad Reporting ❗
24-
To reduce integration testing time, not all models should be enabled in the `run_models.sh` vars. Update the variables after `dbt run` and `dbt test` to set:
25-
- [ ] this PR's package to `true`
26-
- [ ] Google Ads and Facebook Ads to `true` (if not already)
27-
- [ ] All other packages to `false`
23+
### Submission Checklist
24+
- [ ] Alignment meeting with the reviewer (if needed)
25+
- [ ] Timeline and validation requirements discussed
26+
- [ ] Provide validation details:
27+
- [ ] **Validation Steps:** Check for unintentional effects (e.g., add/run consistency & integrity tests)
28+
- [ ] **Testing Instructions:** Confirm the change addresses the issue(s)
29+
- [ ] **Focus Areas:** Complex logic or queries that need extra attention
2830

29-
### Detailed Validation
30-
Please share any and all of your validation steps:
31-
<!--- Provide the steps you took to validate your changes below. -->
32-
33-
### If you had to summarize this PR in an emoji, which would it be?
34-
<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) -->
35-
:dancer:
31+
### Changelog
32+
<!-- Recommend drafting changelog notes, then refining via ChatGPT using:
33+
"Draft a changelog entry based on the following notes." -->
34+
- [ ] Draft changelog for PR
35+
- [ ] Final changelog for release review

.quickstart/quickstart.yml

Lines changed: 39 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,44 @@ table_variables:
5454
pinterest__using_keywords:
5555
- keyword_history
5656
- keyword_report
57+
pinterest__using_pin_promotion_targeting_report:
58+
- pin_promotion_targeting_report
59+
pinterest__using_targeting_geo:
60+
- targeting_geo
61+
pinterest__using_targeting_geo_region:
62+
- targeting_geo_region
5763
twitter_ads__using_keywords:
5864
- line_item_keywords_report
65+
twitter_ads__using_campaign_locations_report:
66+
- campaign_locations_report
67+
twitter_ads__using_campaign_regions_report:
68+
- campaign_regions_report
69+
google_ads__using_search_term_keyword_stats:
70+
- search_term_keyword_stats
71+
facebook_ads__using_demographics_country:
72+
- demographics_country
73+
- demographics_country_actions
74+
facebook_ads__using_demographics_region:
75+
- demographics_region
76+
- demographics_region_actions
77+
linkedin_ads__using_geo:
78+
- geo
79+
linkedin_ads__using_monthly_ad_analytics_by_member_country:
80+
- monthly_ad_analytics_by_member_country
81+
linkedin_ads__using_monthly_ad_analytics_by_member_region:
82+
- monthly_ad_analytics_by_member_region
83+
microsoft_ads__using_geographic_daily_report:
84+
- geographic_performance_daily_report
85+
reddit_ads__using_campaign_country_report:
86+
- campaign_country_report
87+
reddit_ads__using_campaign_country_conversions_report:
88+
- campaign_country_conversions_report
89+
snapchat_ads__using_campaign_country_report:
90+
- campaign_geo_country_daily_report
91+
snapchat_ads__using_campaign_region_report:
92+
- campaign_geo_region_daily_report
93+
tiktok_ads__using_campaign_country_report:
94+
- campaign_country_report
5995

6096
destination_configurations:
6197
databricks:
@@ -72,5 +108,7 @@ public_models: [
72108
"ad_reporting__ad_report",
73109
"ad_reporting__keyword_report",
74110
"ad_reporting__search_report",
75-
"ad_reporting__url_report"
111+
"ad_reporting__url_report",
112+
"ad_reporting__monthly_campaign_country_report",
113+
"ad_reporting__monthly_campaign_region_report"
76114
]

0 commit comments

Comments
 (0)