test: don't use destructors

These destructors get called when the instance gets out of lexical
scope, which makes some issues tricky to debug.

We will cleanup at test teardown instead, and anyway everything gets
deleted after the container exits.

Signed-off-by: Pablo Barbáchano <pablob@amazon.com>

Author: pb8o

tests/conftest.py

@@ -314,6 +314,7 @@ def kill(self):
             """Clean up all built VMs"""
             for vm in self.vms:
                 vm.kill()
+                vm.jailer.cleanup()
             shutil.rmtree(self.tmp_path)
 
     uvm_factory = MicroVMFactory(fc_tmp_path, bin_cloner_path)

tests/framework/jailer.py

@@ -79,10 +79,6 @@ def __init__(
         self.ramfs_subdir_name = "ramfs"
         self._ramfs_path = None
 
-    def __del__(self):
-        """Cleanup this jailer context."""
-        self.cleanup()
-
     # Disabling 'too-many-branches' warning for this function as it needs to
     # check every argument, so the number of branches will increase
     # with every new argument.

tests/framework/microvm.py

@@ -1023,10 +1023,6 @@ def monitor_fd(microvm, path):
         self.logging_thread.daemon = True
         self.logging_thread.start()
 
-    def __del__(self):
-        """Teardown the object."""
-        self.kill()
-
 
 class Serial:
     """Class for serial console communication with a Microvm."""