test: skip snapshotting old releases in m6a

Firecracker releases up to 1.3.3 do not pass CPU information in a way
that can cause a crash in the Ubuntu 22.04 rootfs.

This was fixed in 8dab78b, but not released in the 1.2 branch.

Skip the test as 1.2 will be out of support soon.

Signed-off-by: Pablo Barbáchano <pablob@amazon.com>

Author: pb8o

tests/integration_tests/functional/test_mmds.py

@@ -12,6 +12,7 @@
 import pytest
 
 import host_tools.logging as log_tools
+from framework.properties import global_props
 from framework.utils import (
     configure_mmds,
     generate_mmds_get_request,
@@ -640,6 +641,11 @@ def test_mmds_older_snapshot(
     if the FC version does not support this feature.
     """
 
+    # due to bug fixed in commit 8dab78b
+    firecracker_version = firecracker_release.version_tuple
+    if global_props.instance == "m6a.metal" and firecracker_version < (1, 3, 3):
+        pytest.skip("incompatible with AMD and Firecracker <1.3.3")
+
     microvm = microvm_factory.build(
         guest_kernel,
         rootfs,

tests/integration_tests/functional/test_snapshot_advanced.py

@@ -10,9 +10,10 @@
 
 import host_tools.drive as drive_tools
 from framework.microvm import SnapshotType
+from framework.properties import global_props
 
 # Define 4 scratch drives.
-scratch_drives = ["vdb", "vdc", "vdd", "vde", "vdf"]
+scratch_drives = ["vdb", "vdc", "vdd", "vde"]
 
 
 def test_restore_old_to_current(
@@ -26,6 +27,11 @@ def test_restore_old_to_current(
     2. Restore with the current build
     """
 
+    # due to bug fixed in commit 8dab78b
+    firecracker_version = firecracker_release.version_tuple
+    if global_props.instance == "m6a.metal" and firecracker_version < (1, 3, 3):
+        pytest.skip("incompatible with AMD and Firecracker <1.3.3")
+
     # Microvm: 2vCPU 256MB RAM, balloon, 4 disks and 4 net devices.
     diff_snapshots = True
     vm = microvm_factory.build(
@@ -37,7 +43,6 @@ def test_restore_old_to_current(
     )
     vm.spawn()
     vm.basic_config(track_dirty_pages=True)
-
     snapshot = create_snapshot_helper(
         vm,
         drives=scratch_drives,

tests/integration_tests/performance/test_snapshot_perf.py

@@ -9,6 +9,7 @@
 import pytest
 
 import host_tools.logging as log_tools
+from framework.properties import global_props
 from framework.stats import consumer, producer, types
 from framework.utils import CpuMap
 
@@ -84,6 +85,11 @@ def test_older_snapshot_resume_latency(
     if "4.14" not in guest_kernel.name:
         pytest.skip("just test one guest kernel")
 
+    # due to bug fixed in commit 8dab78b
+    firecracker_version = firecracker_release.version_tuple
+    if global_props.instance == "m6a.metal" and firecracker_version < (1, 3, 3):
+        pytest.skip("incompatible with AMD and Firecracker <1.3.3")
+
     vcpus, guest_mem_mib = 2, 512
     microvm_cfg = f"{vcpus}vcpu_{guest_mem_mib}mb.json"
     vm = microvm_factory.build(