refactor(test): unify debug info dumping routines

We have two places where the test framework dumps a bunch of debug info:
When something fails via SSH, and when we fail to kill a microVM because
it's already dead. Let's unify both of these to dump the _same_ debug
information, by having both call _dump_debug_information (generalized
slightly so that it no longer hardcodes "SSH gone wrong" as the error
message, and extended to also print uffd logs).

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>

Author: roypat

tests/framework/microvm.py

@@ -313,14 +313,14 @@ def kill(self):
             if self.screen_pid:
                 os.kill(self.screen_pid, signal.SIGKILL)
         except:
-            if self.uffd_handler:
-                LOG.error(
-                    "Failed to kill Firecracker Process. Did it already die (or did the UFFD handler process die and take it down)?"
-                )
-                LOG.error("UFFD Handler Logs:\n" + self.uffd_handler.log_data)
-            else:
-                LOG.error("Failed to kill Firecracker Process. Did it already die?")
-            LOG.error("Firecracker Logs:\n" + self.log_data)
+            msg = (
+                "Failed to kill Firecracker Process. Did it already die (or did the UFFD handler process die and take it down)?"
+                if self.uffd_handler
+                else "Failed to kill Firecracker Process. Did it already die?"
+            )
+
+            self._dump_debug_information(msg)
+
             raise
 
         # if microvm was spawned then check if it gets killed
@@ -1062,7 +1062,9 @@ def ssh_iface(self, iface_idx=0):
             user="root",
             host=guest_ip,
             control_path=Path(self.chroot()) / f"ssh-{iface_idx}.sock",
-            on_error=self._dump_debug_information,
+            on_error=lambda exc: self._dump_debug_information(
+                f"Failure executing command via SSH in microVM: {exc}"
+            ),
         )
         self._connections.append(connection)
         return connection
@@ -1084,17 +1086,18 @@ def thread_backtraces(self):
                 )
         return "\n".join(backtraces)
 
-    def _dump_debug_information(self, exc: Exception):
+    def _dump_debug_information(self, what: str):
         """
         Dumps debug information about this microvm
 
         Used for example when running a command inside the guest via `SSHConnection.check_output` fails.
         """
-        print(
-            f"Failure executing command via SSH in microVM: {exc}\n\n"
-            f"Firecracker logs:\n{self.log_data}\n"
-            f"Thread backtraces:\n{self.thread_backtraces}"
-        )
+        LOG.error(what)
+        LOG.error("Firecracker logs:\n %s", self.log_data)
+        if self.uffd_handler:
+            LOG.error("Uffd logs: %s", self.uffd_handler.log_data)
+        if not self._killed:
+            LOG.error("Thread backtraces: %s", self.thread_backtraces)
 
     def wait_for_ssh_up(self):
         """Wait for guest running inside the microVM to come up and respond."""