Skip to content

Commit 3c70571

Browse files
Jonathan Woollett-LightJonathanWoollett-Light
authored andcommitted
Updated PR template
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
1 parent f010acf commit 3c70571

File tree

1 file changed

+12
-17
lines changed

1 file changed

+12
-17
lines changed

.github/pull_request_template.md

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
1-
# Reason for This PR
1+
## Changes
22

3-
`[Author TODO: add issue #.]`
4-
`[Open the PR after the related issue has a clear conclusion.]`
5-
`[If there is no issue which states the need for this PR, create one first.]`
6-
Fixes #
3+
...
74

8-
## Description of Changes
5+
## Reason
96

10-
`[Author TODO: add description of changes.]`
11-
12-
- [ ] This functionality can be added in [`rust-vmm`][1].
7+
...
138

149
## License Acceptance
1510

@@ -18,18 +13,18 @@ the terms of the Apache 2.0 license.
1813

1914
## PR Checklist
2015

21-
`[Author TODO: Meet these criteria.]`
22-
`[Reviewer TODO: Verify that these criteria are met. Request changes if not]`
23-
2416
- [ ] All commits in this PR are signed (`git commit -s`).
25-
- [ ] The issue which led to this PR has a clear conclusion.
26-
- [ ] This PR follows the solution outlined in the related issue.
17+
- [ ] If a specific issue led to this PR, this PR closes the issue.
2718
- [ ] The description of changes is clear and encompassing.
2819
- [ ] Any required documentation changes (code and docs) are included in this PR.
29-
- [ ] Any newly added `unsafe` code is properly documented.
30-
- [ ] Any API changes follow the [Runbook for Firecracker API changes][2].
31-
- [ ] Any user-facing changes are mentioned in `CHANGELOG.md`.
20+
- [ ] New `unsafe` code is documented.
21+
- [ ] API changes follow the [Runbook for Firecracker API changes][2].
22+
- [ ] User-facing changes are mentioned in `CHANGELOG.md`.
3223
- [ ] All added/changed functionality is tested.
3324

25+
---
26+
27+
- [ ] This functionality can be added in [`rust-vmm`][1].
28+
3429
[1]: https://github.com/rust-vmm
3530
[2]: ../docs/api-change-runbook.md

0 commit comments

Comments
 (0)