Skip to content

Commit 38692ce

Browse files
author
Jonathan Woollett-Light
committed
refactor: Re-export logging macros
Re-exports logging macros from `logger` to allow more atomic changes in `logger`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
1 parent 12b49dc commit 38692ce

30 files changed

+36
-50
lines changed

src/logger/src/metrics.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,13 @@ use std::ops::Deref;
6767
use std::sync::atomic::{AtomicUsize, Ordering};
6868
use std::sync::{Mutex, OnceLock};
6969

70-
#[cfg(target_arch = "aarch64")]
71-
use log::warn;
7270
use serde::{Serialize, Serializer};
7371
#[cfg(target_arch = "aarch64")]
7472
use vm_superio::rtc_pl031::RtcEvents;
7573

7674
use super::FcLineWriter;
75+
#[cfg(target_arch = "aarch64")]
76+
use crate::warn;
7777

7878
/// Static instance used for handling metrics.
7979
pub static METRICS: Metrics<FirecrackerMetrics, FcLineWriter> =

src/vmm/src/arch/aarch64/cache_info.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
use std::path::{Path, PathBuf};
55
use std::{fs, io};
66

7-
use log::warn;
7+
use logger::warn;
88

99
// Based on https://elixir.free-electrons.com/linux/v4.9.62/source/arch/arm64/kernel/cacheinfo.c#L29.
1010
const MAX_CACHE_LEVEL: u8 = 7;

src/vmm/src/builder.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ use linux_loader::loader::elf::Elf as Loader;
1717
#[cfg(target_arch = "aarch64")]
1818
use linux_loader::loader::pe::PE as Loader;
1919
use linux_loader::loader::KernelLoader;
20-
use log::error;
20+
use logger::error;
2121
use seccompiler::BpfThreadMap;
2222
use snapshot::Persist;
2323
use userfaultfd::Uffd;

src/vmm/src/device_manager/mmio.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use std::sync::{Arc, Mutex};
1111

1212
use kvm_ioctls::{IoEventAddress, VmFd};
1313
use linux_loader::cmdline as kernel_cmdline;
14-
use log::info;
14+
use logger::info;
1515
#[cfg(target_arch = "x86_64")]
1616
use utils::vm_memory::GuestAddress;
1717
use versionize::{VersionMap, Versionize, VersionizeResult};

src/vmm/src/device_manager/persist.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use std::sync::{Arc, Mutex};
88

99
use event_manager::{MutEventSubscriber, SubscriberOps};
1010
use kvm_ioctls::VmFd;
11-
use log::{error, warn};
11+
use logger::{error, warn};
1212
use mmds::data_store::MmdsVersion;
1313
use snapshot::Persist;
1414
use utils::vm_memory::GuestMemoryMmap;

src/vmm/src/devices/legacy/i8042.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
use std::io;
99
use std::num::Wrapping;
1010

11-
use log::warn;
12-
use logger::{IncMetric, METRICS};
11+
use logger::{warn, IncMetric, METRICS};
1312
use utils::eventfd::EventFd;
1413

1514
/// Errors thrown by the i8042 device.
@@ -228,7 +227,7 @@ impl I8042Device {
228227
// our exit event fd. Meaning Firecracker will be exiting as soon as the VMM
229228
// thread wakes up to handle this event.
230229
if let Err(err) = self.reset_evt.write(1) {
231-
log::error!("Failed to trigger i8042 reset event: {:?}", err);
230+
logger::error!("Failed to trigger i8042 reset event: {:?}", err);
232231
METRICS.i8042.error_count.inc();
233232
}
234233
METRICS.i8042.reset_count.inc();

src/vmm/src/devices/legacy/serial.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ use std::io::{Read, Write};
1212
use std::os::unix::io::{AsRawFd, RawFd};
1313

1414
use event_manager::{EventOps, Events, MutEventSubscriber};
15-
use log::{error, warn};
16-
use logger::{IncMetric, METRICS};
15+
use logger::{error, warn, IncMetric, METRICS};
1716
use utils::epoll::EventSet;
1817
use vm_superio::serial::{Error as SerialError, SerialEvents};
1918
use vm_superio::{Serial, Trigger};

src/vmm/src/devices/mod.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ pub mod pseudo;
1515
pub mod virtio;
1616

1717
pub use bus::{Bus, BusDevice, BusError};
18-
use log::error;
19-
use logger::{IncMetric, METRICS};
18+
use logger::{error, IncMetric, METRICS};
2019

2120
use crate::devices::virtio::{QueueError, VsockError};
2221

src/vmm/src/devices/pseudo/boot_timer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ impl BootTimer {
2323

2424
let boot_time_us = now_tm_us.time_us - self.start_ts.time_us;
2525
let boot_time_cpu_us = now_tm_us.cputime_us - self.start_ts.cputime_us;
26-
log::info!(
26+
logger::info!(
2727
"Guest-boot-time = {:>6} us {} ms, {:>6} CPU us {} CPU ms",
2828
boot_time_us,
2929
boot_time_us / 1000,

src/vmm/src/devices/virtio/balloon/device.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ use std::sync::Arc;
77
use std::time::Duration;
88
use std::{cmp, fmt};
99

10-
use log::error;
11-
use logger::{IncMetric, METRICS};
10+
use logger::{error, IncMetric, METRICS};
1211
use serde::Serialize;
1312
use timerfd::{ClockId, SetTimeFlags, TimerFd, TimerState};
1413
use utils::eventfd::EventFd;

0 commit comments

Comments
 (0)