List without entries, now starts the job right away. Jobnames specified in needs list are now validate and must exist

Author: firecow

src/index.ts

@@ -74,7 +74,7 @@ const runJobs = async () => {
 
         // Find jobs that can be started, because their needed jobs have finished
         for (const job of jobs) {
-            if (job.isRunning() || job.isFinished() || job.needs.length === 0) {
+            if (job.isRunning() || job.isFinished() || job.needs === null) {
                 continue;
             }
 

src/job.ts

@@ -17,7 +17,7 @@ if (process.env.EXEPATH) {
 
 export class Job {
     public readonly name: string;
-    public readonly needs: string[];
+    public readonly needs: string[] | null;
     public readonly stage: string;
 
     private readonly afterScripts: string[] = [];
@@ -72,11 +72,7 @@ export class Job {
         this.afterScripts = [].concat(jobData.after_script || ciDefault.after_script || globals.after_script || []);
         this.allowFailure = jobData.allow_failure || false;
         this.variables = jobData.variables || {};
-        if (this.needs && this.needs.length === 0) {
-            console.error(`${jobNameStr} ${c.red("'needs' cannot be empty array")}`);
-            process.exit(1);
-        }
-        this.needs = jobData.needs || [];
+        this.needs = jobData.needs || null;
     }
 
     public getJobNameString() {

src/parser.ts

@@ -102,6 +102,8 @@ export class Parser {
 
             this.jobs.set(key, job);
         }
+
+        this.validateNeedsTags();
     }
 
     public getJobs(): ReadonlyMap<string, Job> {
@@ -111,4 +113,18 @@ export class Parser {
     public getStages(): ReadonlyMap<string, Stage> {
         return this.stages;
     }
+
+    private validateNeedsTags() {
+        const jobNames = Array.from(this.jobs.values()).map((j) => j.name);
+        for (const job of this.jobs.values()) {
+            if (job.needs === null || job.needs.length === 0) {
+                continue;
+            }
+
+            if (job.needs.filter((v) => (jobNames.indexOf(v) >= 0)).length !== job.needs.length) {
+                console.error(`${c.blueBright(`${job.name}`)} needs list contains unspecified jobs.`);
+                process.exit(1);
+            }
+        }
+    }
 }

tslint.json

@@ -5,6 +5,7 @@
     ],
     "jsRules": {},
     "rules": {
+        "no-null-keyword": false,
         "no-magic-numbers": false,
         "strict-boolean-expressions": false,
         "newline-per-chained-call": false,