fix: edge cases when boolean include-input got converted into string when it's supposed to be boolean (#1291)

* fix: edge cases when boolean include-input got converted into string when it's supposed to be boolean

* refactor: arg have been renamed and anyways it's not required

Author: ANGkeith

src/parser.ts

@@ -337,6 +337,9 @@ export class Parser {
 
                             case "number":
                             case "boolean":
+                                if ((secondChar == "\"" && lastChar == "\"") && firstChar != "\\") {
+                                    return firstChar + inputValue;
+                                }
                                 return firstTwoChar + inputValue + lastChar;
 
                             default:

tests/test-cases/include-inputs/input-templates/types/boolean/.gitlab-ci-input-template.yml

@@ -0,0 +1,11 @@
+---
+spec:
+  inputs:
+    boolean_input:
+      type: boolean
+---
+default:
+  interruptible: $[[ inputs.boolean_input ]]  # This should be !!bool and not !!str
+scan-website:
+  script:
+    - echo $[[ inputs.boolean_input]]

tests/test-cases/include-inputs/input-templates/types/boolean/.gitlab-ci.yml

@@ -0,0 +1,7 @@
+---
+include:
+  - local: '/.gitlab-ci-input-template.yml'
+    inputs:
+      boolean_input: true
+stages:
+  - test

tests/test-cases/include-inputs/integration.include-inputs.test.ts

@@ -205,6 +205,26 @@ test_job:
     expect(writeStreams.stdoutLines[0]).toEqual(expected);
 });
 
+test("include-inputs for type boolean", async () => {
+    const writeStreams = new WriteStreamsMock();
+    await handler({
+        cwd: "tests/test-cases/include-inputs/input-templates/types/boolean",
+        preview: true,
+        jsonSchemaValidation: true, // this test depends on the json schema validation, do not set to false
+    }, writeStreams);
+
+    const expected = `---
+stages:
+  - .pre
+  - test
+  - .post
+scan-website:
+  script:
+    - echo true`;
+
+    expect(writeStreams.stdoutLines[0]).toEqual(expected);
+});
+
 test("include-inputs inputs validation for boolean", async () => {
     try {
         const writeStreams = new WriteStreamsMock();

tests/test-cases/script-blank/integration.script-blank.test.ts

@@ -14,6 +14,5 @@ test("script-blank <test-job>", async () => {
     await expect(handler({
         cwd: "tests/test-cases/script-blank",
         job: ["test-job"],
-        enableJsonSchemaValidation: false,
     }, writeStreams)).rejects.toThrow(chalk`{blue test-job} has empty script`);
 });