fix: Allow repeated include inputs interpolation (#1294)

* test: Add test case for repeated inputs interpolations

* fix: Allow repeated input interpolations

We have to make the first two chars optional, because the string might
have already been consumed up to the `$[[` by a previous iteration of
the `replace` call.

The last char has to exclude the `$` so that the current iteration of
the `replace` does not consume the beginning of what is supposed to be
part of the next iteration. This means that the current iteration might
not have a `lastChar` if it is immediately followed by the `$[[` of the
next iteration, so `lastChar` has to be optional as well.

Author: PigeonF

src/parser.ts

@@ -308,7 +308,7 @@ export class Parser {
 
             const interpolatedConfigurations = JSON.stringify(uninterpolatedConfigurations)
                 .replace(
-                    /(?<firstChar>.)(?<secondChar>.)\$\[\[\s*inputs.(?<interpolationKey>[\w-]+)\s*\|?\s*(?<interpolationFunctions>.*?)\s*\]\](?<lastChar>.)/g // https://regexr.com/81c16
+                    /(?<firstChar>.)?(?<secondChar>.)?\$\[\[\s*inputs.(?<interpolationKey>[\w-]+)\s*\|?\s*(?<interpolationFunctions>.*?)\s*\]\](?<lastChar>[^$])?/g // https://regexr.com/81c16
                     , (_: string, firstChar: string, secondChar: string, interpolationKey: string, interpolationFunctions: string, lastChar: string) => {
                         const configFilePath = path.relative(process.cwd(), filePath);
                         const context = {
@@ -318,6 +318,9 @@ export class Parser {
                             configFilePath,
                             ...ctx,
                         };
+                        firstChar ??= "";
+                        secondChar ??= "";
+                        lastChar ??= "";
 
                         const {inputValue, inputType} = parseIncludeInputs(context);
                         const firstTwoChar = firstChar + secondChar;

tests/test-cases/include-inputs/input-templates/interpolation-repeat/.gitlab-ci-input-template.yml

@@ -0,0 +1,8 @@
+---
+spec:
+  inputs:
+    name:
+---
+job $[[ inputs.name ]] $[[ inputs.name ]]:
+  script:
+    - echo $[[ inputs.name ]]$[[ inputs.name ]]

tests/test-cases/include-inputs/input-templates/interpolation-repeat/.gitlab-ci.yml

@@ -0,0 +1,7 @@
+---
+include:
+  - local: "/.gitlab-ci-input-template.yml"
+    inputs:
+      name: foo
+stages:
+  - test

tests/test-cases/include-inputs/integration.include-inputs.test.ts

@@ -135,6 +135,25 @@ scan-website:
     expect(writeStreams.stdoutLines[0]).toEqual(expected);
 });
 
+test("include-inputs interpolation repeated", async () => {
+    const writeStreams = new WriteStreamsMock();
+    await handler({
+        cwd: "tests/test-cases/include-inputs/input-templates/interpolation-repeat",
+        preview: true,
+    }, writeStreams);
+
+    const expected = `---
+stages:
+  - .pre
+  - test
+  - .post
+job foo foo:
+  script:
+    - echo foofoo`;
+
+    expect(writeStreams.stdoutLines[0]).toEqual(expected);
+});
+
 test("include-inputs inputs validation for array", async () => {
     try {
         const writeStreams = new WriteStreamsMock();