From 7c7e73e9e97715e24fe7a899310deb33bee61c8c Mon Sep 17 00:00:00 2001 From: Maneesh Tewani Date: Wed, 18 Jun 2025 17:17:38 -0700 Subject: [PATCH 1/4] Added extension change for firebase studio' --- packages/auth/src/core/util/handler.ts | 7 ++++++- packages/data-connect/test/util.ts | 5 ++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/auth/src/core/util/handler.ts b/packages/auth/src/core/util/handler.ts index 3b6aa674756..07bb8e46112 100644 --- a/packages/auth/src/core/util/handler.ts +++ b/packages/auth/src/core/util/handler.ts @@ -129,7 +129,12 @@ export async function _getRedirectUrl( function getHandlerBase({ config }: AuthInternal): string { if (!config.emulator) { - return `https://${config.authDomain}/${WIDGET_PATH}`; + const path = `https://${config.authDomain}/${WIDGET_PATH}`; + if(typeof process !== 'undefined' && process.env.FIREBASE_USE_HANDLER_EXT) { + // Static servers require extensions to infer Content-Type + return `${path}.html`; + } + return path; } return _emulatorUrl(config, EMULATOR_WIDGET_PATH); diff --git a/packages/data-connect/test/util.ts b/packages/data-connect/test/util.ts index 625c263c311..79ba62ab9f9 100644 --- a/packages/data-connect/test/util.ts +++ b/packages/data-connect/test/util.ts @@ -21,8 +21,11 @@ import { connectDataConnectEmulator, ConnectorConfig, DataConnect, - getDataConnect + executeMutation, + getDataConnect, + mutationRef } from '../src'; +import { removePost, removePostRef } from './dataconnect/connector/gen/web'; export const EMULATOR_PORT = process.env.DC_EMULATOR_PORT; const USE_EMULATOR = !!EMULATOR_PORT; From 11d58925e4707f45b4e162f0509046fc9a8a51af Mon Sep 17 00:00:00 2001 From: Maneesh Tewani Date: Wed, 18 Jun 2025 17:20:17 -0700 Subject: [PATCH 2/4] Create brown-trains-melt.md --- .changeset/brown-trains-melt.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/brown-trains-melt.md diff --git a/.changeset/brown-trains-melt.md b/.changeset/brown-trains-melt.md new file mode 100644 index 00000000000..9989095fae2 --- /dev/null +++ b/.changeset/brown-trains-melt.md @@ -0,0 +1,5 @@ +--- +"@firebase/auth": patch +--- + +Fix issue where using signInWithRedirect in Firebase Studio required a route rewrite for the auth handler widget. From a9480bf29877a9fca4b4a1031e8a89285182f43f Mon Sep 17 00:00:00 2001 From: Maneesh Tewani Date: Wed, 18 Jun 2025 17:20:49 -0700 Subject: [PATCH 3/4] Removed unnecessary changes --- packages/data-connect/test/util.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/data-connect/test/util.ts b/packages/data-connect/test/util.ts index 79ba62ab9f9..625c263c311 100644 --- a/packages/data-connect/test/util.ts +++ b/packages/data-connect/test/util.ts @@ -21,11 +21,8 @@ import { connectDataConnectEmulator, ConnectorConfig, DataConnect, - executeMutation, - getDataConnect, - mutationRef + getDataConnect } from '../src'; -import { removePost, removePostRef } from './dataconnect/connector/gen/web'; export const EMULATOR_PORT = process.env.DC_EMULATOR_PORT; const USE_EMULATOR = !!EMULATOR_PORT; From 24b6f37910a8aabebefc0114d7f4c33d8a0ec114 Mon Sep 17 00:00:00 2001 From: Maneesh Tewani Date: Wed, 18 Jun 2025 17:21:05 -0700 Subject: [PATCH 4/4] Formatting --- packages/auth/src/core/util/handler.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/auth/src/core/util/handler.ts b/packages/auth/src/core/util/handler.ts index 07bb8e46112..75ee9f8b651 100644 --- a/packages/auth/src/core/util/handler.ts +++ b/packages/auth/src/core/util/handler.ts @@ -130,7 +130,10 @@ export async function _getRedirectUrl( function getHandlerBase({ config }: AuthInternal): string { if (!config.emulator) { const path = `https://${config.authDomain}/${WIDGET_PATH}`; - if(typeof process !== 'undefined' && process.env.FIREBASE_USE_HANDLER_EXT) { + if ( + typeof process !== 'undefined' && + process.env.FIREBASE_USE_HANDLER_EXT + ) { // Static servers require extensions to infer Content-Type return `${path}.html`; }