Refactor to support multiple entry points for the lite SDK. Fixes import issues and makes code organization across /pipelines and /lite/pipeliens

Author: MarkDuckworth

packages/firestore/lite/pipelines/package.json

@@ -0,0 +1,14 @@
+{
+  "name": "@firebase/firestore-lite-pipelines",
+  "description": "Pipelines for the lite Firestore SDK",
+  "main": "../../dist/lite/pipelines.node.cjs.js",
+  "main-esm": "../../dist/lite/pipelines.node.mjs",
+  "module": "../../dist/lite/pipelines.browser.esm2017.js",
+  "browser": "../../dist/lite/pipelines.browser.esm2017.js",
+  "react-native": "../../dist/lite/pipelines.rn.esm2017.js",
+  "typings": "../../dist/lite/pipelines.d.ts",
+  "private": true,
+  "engines": {
+    "node": ">=18.0.0"
+  }
+}

packages/firestore/lite/pipelines.ts renamed to packages/firestore/lite/pipelines/pipelines.ts

@@ -45,19 +45,19 @@ export type {
   QueryDocumentSnapshot,
   Primitive,
   FieldValue
-} from './index';
+} from '../index';
 
-export { PipelineSource } from '../src/lite-api/pipeline-source';
+export { PipelineSource } from '../../src/lite-api/pipeline-source';
 
-export { PipelineResult } from '../src/lite-api/pipeline-result';
+export { PipelineResult } from '../../src/lite-api/pipeline-result';
 
-export { Pipeline } from '../src/lite-api/pipeline';
+export { Pipeline } from '../../src/lite-api/pipeline';
 
 export {
   useFluentPipelines,
   pipeline,
   execute
-} from '../src/lite-api/pipeline_impl';
+} from '../../src/lite-api/pipeline_impl';
 
 export {
   Stage,
@@ -76,7 +76,7 @@ export {
   Select,
   Sort,
   GenericStage
-} from '../src/lite-api/stage';
+} from '../../src/lite-api/stage';
 
 export {
   add,
@@ -212,4 +212,4 @@ export {
   Selectable,
   FilterCondition,
   Accumulator
-} from '../src/lite-api/expressions';
+} from '../../src/lite-api/expressions';

packages/firestore/package.json

@@ -49,11 +49,11 @@
     "trusted-type-check": "tsec -p tsconfig.json --noEmit",
     "api-report:main": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ../../repo-scripts/prune-dts/extract-public-api.ts --package firestore --packageRoot . --typescriptDts ./dist/firestore/src/index.d.ts --rollupDts ./dist/private.d.ts --untrimmedRollupDts ./dist/internal.d.ts --publicDts ./dist/index.d.ts",
     "api-report:all-packages": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ../../repo-scripts/prune-dts/extract-public-api.ts --package firestore --packageRoot . --typescriptDts ./dist/firestore/src/all_packages.d.ts --rollupDts ./dist/private.all_packages.d.ts --untrimmedRollupDts ./dist/internal.all_packages.d.ts --publicDts ./dist/all_packages.d.ts",
-    "api-report:pipelines": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ../../repo-scripts/prune-dts/extract-public-api.ts --package firestore-pipelines --packageRoot . --typescriptDts ./dist/firestore/src/pipelines.d.ts --rollupDts ./dist/private.pipelines.d.ts --untrimmedRollupDts ./dist/internal.pipelines.d.ts --publicDts ./dist/pipelines.d.ts --otherExportsPublicDtsFiles ./dist/index.d.ts",
+    "api-report:pipelines": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ../../repo-scripts/prune-dts/extract-public-api.ts --package firestore-pipelines --packageRoot . --typescriptDts ./dist/firestore/pipelines/pipelines.d.ts --rollupDts ./dist/private.pipelines.d.ts --untrimmedRollupDts ./dist/internal.pipelines.d.ts --publicDts ./dist/pipelines.d.ts --otherExportsPublicDtsFiles ./dist/index.d.ts",
     "api-report:lite": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ../../repo-scripts/prune-dts/extract-public-api.ts --package firestore-lite --packageRoot . --typescriptDts ./dist/firestore/lite/index.d.ts --rollupDts ./dist/lite/private.d.ts --untrimmedRollupDts ./dist/lite/internal.d.ts --publicDts ./dist/lite/index.d.ts",
-    "api-report:lite:pipelines": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ../../repo-scripts/prune-dts/extract-public-api.ts --package firestore-lite-pipelines --packageRoot . --typescriptDts ./dist/firestore/lite/pipelines.d.ts --rollupDts ./dist/lite/private.pipelines.d.ts --untrimmedRollupDts ./dist/lite/internal.pipelines.d.ts --publicDts ./dist/lite/pipelines.d.ts --otherExportsPublicDtsFiles ./dist/index.d.ts",
+    "api-report:lite:pipelines": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ../../repo-scripts/prune-dts/extract-public-api.ts --package firestore-lite-pipelines --packageRoot . --typescriptDts ./dist/firestore/lite/pipelines/pipelines.d.ts --rollupDts ./dist/lite/private.pipelines.d.ts --untrimmedRollupDts ./dist/lite/internal.pipelines.d.ts --publicDts ./dist/lite/pipelines.d.ts --otherExportsPublicDtsFiles ./dist/index.d.ts",
     "api-report:api-json": "rm -rf temp && api-extractor run --local --verbose",
-    "api-report": "run-s --npm-path npm api-report:main api-report:pipelines api-report:lite api-report:lite:pipelines && yarn api-report:api-json",
+    "api-report": "run-s --npm-path npm api-report:main api-report:pipelines api-report:all-packages api-report:lite api-report:lite:pipelines && yarn api-report:api-json",
     "doc": "api-documenter markdown --input temp --output docs",
     "typings:public": "node ../../scripts/build/use_typings.js ./dist/all-packages.d.ts"
   },
@@ -164,7 +164,7 @@
   "bugs": {
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
-  "types": "dist/all_packages.d.ts",
+  "types": "dist/index.d.ts",
   "nyc": {
     "extension": [
       ".ts"

packages/firestore/src/pipelines.node.ts renamed to packages/firestore/pipelines/pipelines.node.ts

@@ -15,4 +15,4 @@
  * limitations under the License.
  */
 
-export * from './api_pipelines';
+export * from '../src/api_pipelines';

packages/firestore/src/pipelines.rn.ts renamed to packages/firestore/pipelines/pipelines.rn.ts

@@ -15,4 +15,4 @@
  * limitations under the License.
  */
 
-export * from './api_pipelines';
+export * from '../src/api_pipelines';

packages/firestore/src/pipelines.ts renamed to packages/firestore/pipelines/pipelines.ts

@@ -45,6 +45,6 @@ export type {
   Primitive,
   FieldValue,
   SnapshotMetadata
-} from './api';
+} from '../src/api';
 
-export * from './api_pipelines';
+export * from '../src/api_pipelines';

packages/firestore/rollup.config.js

@@ -51,7 +51,6 @@ const browserPlugins = [
     cacheDir: tmp.dirSync(),
     abortOnError: true,
     transformers: [util.removeAssertAndPrefixInternalTransformer]
-    //transformers: [util.removeAssertTransformer]
   }),
   json({ preferConst: true }),
   terser(util.manglePrivatePropertiesOptions)
@@ -62,7 +61,7 @@ const allBuilds = [
   // this is an intermediate build used to generate the actual esm and cjs builds
   // which add build target reporting
   {
-    input: ['./src/index.node.ts', './src/pipelines.node.ts'],
+    input: ['./src/index.node.ts', './pipelines/pipelines.node.ts'],
     output: {
       dir: 'dist/intermediate',
       entryFileNames: '[name].mjs',
@@ -135,7 +134,7 @@ const allBuilds = [
   // this is an intermediate build used to generate the actual esm and cjs builds
   // which add build target reporting
   {
-    input: ['./src/index.ts', './src/pipelines.ts'],
+    input: ['./src/index.ts', './pipelines/pipelines.ts'],
     output: {
       dir: 'dist/intermediate',
       entryFileNames: '[name].js',
@@ -193,7 +192,7 @@ const allBuilds = [
   },
   // RN build
   {
-    input: ['./src/index.rn.ts', './src/pipelines.rn.ts'],
+    input: ['./src/index.rn.ts', './pipelines/pipelines.rn.ts'],
     output: {
       dir: 'dist/',
       entryFileNames: '[name].js',

packages/firestore/rollup.config.lite.js

@@ -56,7 +56,7 @@ const allBuilds = [
   // this is an intermediate build used to generate the actual esm and cjs builds
   // which add build target reporting
   {
-    input: ['./lite/index.ts', './lite/pipelines.ts'],
+    input: ['./lite/index.ts', './lite/pipelines/pipelines.ts'],
     output: {
       dir: 'dist/intermediate/lite/',
       entryFileNames: '[name].node.mjs',
@@ -133,7 +133,7 @@ const allBuilds = [
   // this is an intermediate build used to generate the actual esm and cjs builds
   // which add build target reporting
   {
-    input: ['./lite/index.ts', './lite/pipelines.ts'],
+    input: ['./lite/index.ts', './lite/pipelines/pipelines.ts'],
     output: {
       dir: 'dist/intermediate/lite/',
       entryFileNames: '[name].browser.js',
@@ -204,7 +204,7 @@ const allBuilds = [
   },
   // RN build
   {
-    input: ['./lite/index.ts', './lite/pipelines.ts'],
+    input: ['./lite/index.ts', './lite/pipelines/pipelines.ts'],
     output: {
       dir: 'dist/lite/',
       entryFileNames: '[name].rn.esm2017.js',

packages/firestore/test/integration/util/firebase_export.ts

@@ -51,5 +51,5 @@ export function newTestFirestore(
 }
 
 export * from '../../../src';
-export * from '../../../src/pipelines';
+export * from '../../../pipelines/pipelines';
 export { PrivateSettings };