Skip to content

Commit ca4dbcf

Browse files
authored
Set singleRun to true and remove from all karma start scripts (#8484)
1 parent 3670ab8 commit ca4dbcf

File tree

33 files changed

+56
-55
lines changed

33 files changed

+56
-55
lines changed

config/karma.base.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ const config = {
6666

6767
webpackMiddleware: { quiet: true, stats: { colors: true } },
6868

69-
singleRun: false,
69+
// Exit with an exit code of 0 if any of the tests fail.
70+
singleRun: true,
7071

7172
client: {
7273
mocha: {

integration/compat-interop/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"private": true,
44
"version": "0.1.0",
55
"scripts": {
6-
"test": "karma start --single-run",
6+
"test": "karma start",
77
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test",
88
"test:debug": "karma start --browsers Chrome --auto-watch"
99
},

integration/firebase/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"private": true,
44
"version": "0.2.1",
55
"scripts": {
6-
"test": "karma start --single-run",
6+
"test": "karma start",
77
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test"
88
},
99
"devDependencies": {

integration/firestore/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
"build:deps": "lerna run --scope @firebase/'{app,firestore}' --include-dependencies build",
77
"build:persistence": "INCLUDE_FIRESTORE_PERSISTENCE=true gulp compile-tests",
88
"build:memory": "INCLUDE_FIRESTORE_PERSISTENCE=false gulp compile-tests",
9-
"karma:singlerun": "karma start --single-run",
9+
"karma:singlerun": "karma start",
1010
"prettier": "prettier --write '*.js' '*.ts'",
11-
"test:persistence": " yarn build:persistence; karma start --single-run",
11+
"test:persistence": " yarn build:persistence; karma start",
1212
"test:persistence:debug": "yarn build:persistence; karma start --auto-watch --browsers Chrome",
13-
"test:memory": "yarn build:memory; karma start --single-run",
13+
"test:memory": "yarn build:memory; karma start",
1414
"test:memory:debug": "yarn build:memory; karma start --auto-watch --browsers Chrome"
1515
},
1616
"dependencies": {

packages/analytics-compat/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"dev": "rollup -c -w",
4848
"test": "run-p --npm-path npm lint test:browser",
4949
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser",
50-
"test:browser": "karma start --single-run",
50+
"test:browser": "karma start",
5151
"test:browser:debug": "karma start --browsers=Chrome --auto-watch",
5252
"trusted-type-check": "tsec -p tsconfig.json --noEmit",
5353
"add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../analytics/dist/analytics-public.d.ts -o dist/src/index.d.ts -a -r Analytics:FirebaseAnalytics -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/analytics"

packages/analytics/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
"test": "run-p --npm-path npm lint test:all",
3030
"test:all": "run-p --npm-path npm test:browser test:integration",
3131
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
32-
"test:browser": "karma start --single-run --nocache",
33-
"test:integration": "karma start ./karma.integration.conf.js --single-run --nocache",
32+
"test:browser": "karma start --nocache",
33+
"test:integration": "karma start ./karma.integration.conf.js --nocache",
3434
"trusted-type-check": "tsec -p tsconfig.json --noEmit",
3535
"api-report": "api-extractor run --local --verbose",
3636
"doc": "api-documenter markdown --input temp --output docs",

packages/app-check-compat/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"dev": "rollup -c -w",
2929
"test": "run-p --npm-path npm lint test:browser",
3030
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser",
31-
"test:browser": "karma start --single-run --nocache",
31+
"test:browser": "karma start --nocache",
3232
"trusted-type-check": "tsec -p tsconfig.json --noEmit",
3333
"add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../app-check/dist/app-check-public.d.ts -o dist/src/index.d.ts -a -r AppCheck:FirebaseAppCheck -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/app-check"
3434
},

packages/app-check/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"dev": "rollup -c -w",
2929
"test": "run-p --npm-path npm lint test:browser",
3030
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser",
31-
"test:browser": "karma start --single-run --nocache",
31+
"test:browser": "karma start --nocache",
3232
"trusted-type-check": "tsec -p tsconfig.json --noEmit",
3333
"api-report": "api-extractor run --local --verbose",
3434
"doc": "api-documenter markdown --input temp --output docs",

packages/app-compat/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"test": "run-p --npm-path npm lint test:all",
3333
"test:all": "run-p --npm-path npm test:browser test:node",
3434
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
35-
"test:browser": "karma start --single-run",
35+
"test:browser": "karma start",
3636
"test:browser:debug": "karma start --browsers Chrome --auto-watch",
3737
"test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha test/**/*.test.* src/**/*.test.ts --config ../../config/mocharc.node.js",
3838
"trusted-type-check": "tsec -p tsconfig.json --noEmit",

packages/app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"test": "run-p --npm-path npm lint test:all",
3030
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
3131
"test:all": "run-p --npm-path npm test:browser test:node",
32-
"test:browser": "karma start --single-run",
32+
"test:browser": "karma start",
3333
"test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha src/**/*.test.ts --config ../../config/mocharc.node.js",
3434
"trusted-type-check": "tsec -p tsconfig.json --noEmit",
3535
"api-report": "api-extractor run --local --verbose",

0 commit comments

Comments
 (0)