Skip to content

Commit 2bbe42f

Browse files
author
kjelko
committed
rename and clean up a few things
1 parent d1f6bfd commit 2bbe42f

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

packages/remote-config/src/storage/storage.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -355,19 +355,23 @@ export class IndexedDbStorage extends Storage {
355355
}
356356

357357
export class InMemoryStorage extends Storage {
358-
private db: { [key: string]: unknown } = {};
358+
private storage: { [key: string]: unknown } = {};
359359

360360
async get<T>(key: ProjectNamespaceKeyFieldValue): Promise<T> {
361-
return Promise.resolve(this.db[key] as T);
361+
return Promise.resolve(this.storage[key] as T);
362362
}
363363

364364
async set<T>(key: ProjectNamespaceKeyFieldValue, value: T): Promise<void> {
365-
this.db[key] = value;
365+
this.storage[key] = value;
366366
return Promise.resolve(undefined);
367367
}
368368

369369
async delete(key: ProjectNamespaceKeyFieldValue): Promise<void> {
370-
this.db[key] = undefined;
370+
this.storage[key] = undefined;
371371
return Promise.resolve();
372372
}
373+
374+
async setCustomSignals(customSignals: CustomSignals): Promise<CustomSignals> {
375+
return Promise.resolve({});
376+
}
373377
}

packages/remote-config/test/api.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,4 +123,4 @@ describe('Remote Config API', () => {
123123
await ensureInitialized(rc);
124124
expect(getString(rc, 'foobar')).to.equal('hello world');
125125
});
126-
});
126+
});

0 commit comments

Comments
 (0)