From 99f956f0f09555a02d0b27d1c8ce0baa3b6ff922 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 12:16:54 -0400 Subject: [PATCH 1/3] [skip ci] [no ci] Pending FIS work --- .github/workflows/installations.yml | 53 ++++++++--------------------- 1 file changed, 15 insertions(+), 38 deletions(-) diff --git a/.github/workflows/installations.yml b/.github/workflows/installations.yml index 6c97e8b82fc..34ff10a2b9e 100644 --- a/.github/workflows/installations.yml +++ b/.github/workflows/installations.yml @@ -6,6 +6,8 @@ on: paths: - 'FirebaseInstallations**' - '.github/workflows/installations.yml' + - '.github/workflows/common.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 10pm (PST) - cron uses UTC times @@ -28,46 +30,21 @@ jobs: product: FirebaseInstallations target: FirebaseInstallations-Unit-unit - pod-lib-lint: - # Don't run on private repo unless it is a PR. - if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' - - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - strategy: - matrix: - # TODO: macos tests are blocked by https://github.com/erikdoe/ocmock/pull/532 - target: [ios, tvos, macos --skip-tests, watchos] - build-env: - - os: macos-14 - xcode: Xcode_16.2 - test-specs: unit,integration - - os: macos-15 - xcode: Xcode_16.3 - test-specs: unit - runs-on: ${{ matrix.build-env.os }} - steps: - - uses: actions/checkout@v4 - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Setup Bundler - run: scripts/setup_bundler.sh - - name: Configure test keychain - run: scripts/configure_test_keychain.sh - - name: Install GoogleService-Info.plist - run: | + pod_lib_lint: + uses: ./.github/workflows/common_cocoapods.yml + with: + product: FirebaseInstallations + setup_command: | + scripts/configure_test_keychain.sh mkdir -p FirebaseInstallations/Source/Tests/Resources scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Installations/GoogleService-Info.plist.gpg \ FirebaseInstallations/Source/Tests/Resources/GoogleService-Info.plist "$plist_secret" - - name: Get boolean for secrets available - id: secrets - run: echo "::set-output name=val::$([[ -z $plist_secret ]] && echo "0" || echo "1")" - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer - - name: Build and test - run: | - export FIS_INTEGRATION_TESTS_REQUIRED=${{ steps.secrets.outputs.val }} - scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseInstallations.podspec \ - --platforms=${{ matrix.target }} --test-specs=${{ matrix.build-env.test-specs }} + export FIS_INTEGRATION_TESTS_REQUIRED=1 +# test_specs: unit + # TODO: macos tests are blocked by https://github.com/erikdoe/ocmock/pull/532 +# buildonly_platforms: macOS + secrets: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} quickstart: # Don't run on private repo unless it is a PR. @@ -129,7 +106,7 @@ jobs: flags: [ '--use-static-frameworks' ] - needs: pod-lib-lint + needs: pod_lib_lint steps: - uses: actions/checkout@v4 - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 From 089ae6de80399d7052bb5948be95f7d9eb21c06f Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 18:02:35 -0400 Subject: [PATCH 2/3] add permissions --- .github/workflows/installations.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/installations.yml b/.github/workflows/installations.yml index 34ff10a2b9e..a569b78028b 100644 --- a/.github/workflows/installations.yml +++ b/.github/workflows/installations.yml @@ -1,5 +1,8 @@ name: installations +permissions: + contents: read + on: workflow_dispatch: pull_request: From 07cf212345bda583120f759168c2b310e7676fee Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Fri, 30 May 2025 09:41:29 -0400 Subject: [PATCH 3/3] Update .github/workflows/installations.yml --- .github/workflows/installations.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/installations.yml b/.github/workflows/installations.yml index a569b78028b..3defdd7af2f 100644 --- a/.github/workflows/installations.yml +++ b/.github/workflows/installations.yml @@ -43,9 +43,6 @@ jobs: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Installations/GoogleService-Info.plist.gpg \ FirebaseInstallations/Source/Tests/Resources/GoogleService-Info.plist "$plist_secret" export FIS_INTEGRATION_TESTS_REQUIRED=1 -# test_specs: unit - # TODO: macos tests are blocked by https://github.com/erikdoe/ocmock/pull/532 -# buildonly_platforms: macOS secrets: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}