From 047bf57df531ffa9dc14b5e0af9551bb512cc69c Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Wed, 28 May 2025 17:11:58 -0400 Subject: [PATCH 01/18] [Infra] Make mlmodeldownloader.yml use reusable CocoaPods workflow --- .github/workflows/common_cocoapods.yml | 5 ++++ .github/workflows/mlmodeldownloader.yml | 36 +++++++------------------ 2 files changed, 14 insertions(+), 27 deletions(-) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index 6a575554bb4..c983cb4e6bd 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -66,6 +66,9 @@ on: # This is useful for additional set up, like starting an emulator or # downloading test data. # + # Note, this step has env var set to decrypt plists. Use "$plist_secret" + # in the given command. + # # Example: `FirebaseFunctions/Backend/start.sh synchronous` setup_command: type: string @@ -101,6 +104,8 @@ jobs: run: sed -i "" "s/s.swift_version[[:space:]]*=[[:space:]]*'5.9'/s.swift_version = '6.0'/" ${{ inputs.product }}.podspec - name: Run setup command, if needed. if: inputs.setup_command != '' + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} run: ${{ inputs.setup_command }} - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14' diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 7569188c374..1c89c5c4b3e 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -6,6 +6,8 @@ on: paths: - 'FirebaseMLModelDownloader**' - '.github/workflows/mlmodeldownloader.yml' + - '.github/workflows/common.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 11pm (PST) - cron uses UTC times @@ -27,35 +29,15 @@ jobs: product: FirebaseMLModelDownloader target: FirebaseMLModelDownloader-Unit-unit - pod-lib-lint: - if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - strategy: - matrix: - target: [ios, tvos, macos, watchos] - build-env: - - os: macos-14 - xcode: Xcode_16.2 - - os: macos-15 - xcode: Xcode_16.2 - runs-on: ${{ matrix.build-env.os }} - steps: - - uses: actions/checkout@v4 - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Setup Bundler - run: scripts/setup_bundler.sh - - name: Configure test keychain - run: scripts/configure_test_keychain.sh - - name: Install GoogleService-Info.plist - run: | + pod_lib_lint: + uses: ./.github/workflows/common_cocoapods.yml + with: + product: FirebaseMLModelDownloader + setup_command: | + scripts/configure_test_keychain.sh mkdir FirebaseMLModelDownloader/Tests/Integration/Resources scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" - - name: Xcode - run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer - - name: Build and test - run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseMLModelDownloader.podspec --platforms=${{ matrix.target }}) mlmodeldownloader-cron-only: if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk' @@ -65,7 +47,7 @@ jobs: strategy: matrix: target: [ios, tvos, macos] - needs: pod-lib-lint + needs: pod_lib_lint steps: - uses: actions/checkout@v4 - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 From 2763ba8b9c7513b031daaf33dab05e37ab04bbf6 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 29 May 2025 10:20:17 -0400 Subject: [PATCH 02/18] debug --- .github/workflows/mlmodeldownloader.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 1c89c5c4b3e..845b184b34e 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -38,6 +38,10 @@ jobs: mkdir FirebaseMLModelDownloader/Tests/Integration/Resources scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" + ls + ls FirebaseMLModelDownloader/Tests/Integration/Resources + pwd + mlmodeldownloader-cron-only: if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk' From e576761fa8cf5e646227c8a2bfba54ea899daecd Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 29 May 2025 10:22:06 -0400 Subject: [PATCH 03/18] debug: disable workflow triggers for non ml workflows --- .github/workflows/abtesting.yml | 2 +- .github/workflows/appdistribution.yml | 2 +- .github/workflows/auth.yml | 2 +- .github/workflows/core.yml | 2 +- .github/workflows/core_extension.yml | 2 +- .github/workflows/core_internal.yml | 2 +- .github/workflows/crashlytics.yml | 2 +- .github/workflows/database.yml | 2 +- .github/workflows/dynamiclinks.yml | 2 +- .github/workflows/firebase_app_check.yml | 2 +- .github/workflows/firebaseai.yml | 2 +- .github/workflows/functions.yml | 2 +- .github/workflows/inappmessaging.yml | 2 +- .github/workflows/messaging.yml | 2 +- .github/workflows/performance.yml | 2 +- .github/workflows/remoteconfig.yml | 2 +- .github/workflows/sessions.yml | 2 +- .github/workflows/shared-swift.yml | 2 +- .github/workflows/vertexai.yml | 2 +- 19 files changed, 19 insertions(+), 19 deletions(-) diff --git a/.github/workflows/abtesting.yml b/.github/workflows/abtesting.yml index f874410e988..79308a3630b 100644 --- a/.github/workflows/abtesting.yml +++ b/.github/workflows/abtesting.yml @@ -11,7 +11,7 @@ on: - 'Interop/Analytics/Public/*.h' - '.github/workflows/abtesting.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am(PST) - cron uses UTC times diff --git a/.github/workflows/appdistribution.yml b/.github/workflows/appdistribution.yml index 059a5ab88b6..a9fa683e654 100644 --- a/.github/workflows/appdistribution.yml +++ b/.github/workflows/appdistribution.yml @@ -10,7 +10,7 @@ on: - 'FirebaseAppDistribution**' - '.github/workflows/appdistribution.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am (PST) - cron uses UTC times diff --git a/.github/workflows/auth.yml b/.github/workflows/auth.yml index 31a5f7584e9..bc2be33669b 100644 --- a/.github/workflows/auth.yml +++ b/.github/workflows/auth.yml @@ -11,7 +11,7 @@ on: - 'FirebaseAuth/Interop/*.h' - '.github/workflows/auth.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'scripts/gha-encrypted/AuthSample/SwiftApplication.plist.gpg' - 'Gemfile*' schedule: diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 70b8cb92612..902429306c5 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -10,7 +10,7 @@ on: - 'FirebaseCore**' - '.github/workflows/core.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/core_extension.yml b/.github/workflows/core_extension.yml index 15b86f38538..884cbf9555d 100644 --- a/.github/workflows/core_extension.yml +++ b/.github/workflows/core_extension.yml @@ -11,7 +11,7 @@ on: - 'FirebaseCore/Extension/**' - '.github/workflows/core_extension.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/core_internal.yml b/.github/workflows/core_internal.yml index 02ae537a6ff..c8ef829be71 100644 --- a/.github/workflows/core_internal.yml +++ b/.github/workflows/core_internal.yml @@ -11,7 +11,7 @@ on: - 'FirebaseCore/Internal/**' - '.github/workflows/core_internal.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 05f492d68d3..b6b8fbf5de9 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -11,7 +11,7 @@ on: - 'FirebaseCrashlytics.podspec' - '.github/workflows/crashlytics.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Interop/Analytics/Public/*.h' - 'Gemfile*' schedule: diff --git a/.github/workflows/database.yml b/.github/workflows/database.yml index 694ed7b48e5..04628852695 100644 --- a/.github/workflows/database.yml +++ b/.github/workflows/database.yml @@ -14,7 +14,7 @@ on: - 'FirebaseAuth/Interop/*.h' - '.github/workflows/database.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' - 'scripts/run_database_emulator.sh' schedule: diff --git a/.github/workflows/dynamiclinks.yml b/.github/workflows/dynamiclinks.yml index b6c2ff19c0b..48d7bf0745a 100644 --- a/.github/workflows/dynamiclinks.yml +++ b/.github/workflows/dynamiclinks.yml @@ -11,7 +11,7 @@ on: - '.github/workflows/dynamiclinks.yml' - 'Interop/Analytics/Public/*.h' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am (PST) - cron uses UTC times diff --git a/.github/workflows/firebase_app_check.yml b/.github/workflows/firebase_app_check.yml index 5e5c749d808..41b65d493bb 100644 --- a/.github/workflows/firebase_app_check.yml +++ b/.github/workflows/firebase_app_check.yml @@ -10,7 +10,7 @@ on: - 'FirebaseAppCheck**' - '.github/workflows/firebase_app_check.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 11pm (PST) - cron uses UTC times diff --git a/.github/workflows/firebaseai.yml b/.github/workflows/firebaseai.yml index 1184ce74897..022c1ef9209 100644 --- a/.github/workflows/firebaseai.yml +++ b/.github/workflows/firebaseai.yml @@ -6,7 +6,7 @@ on: - 'FirebaseAI**' - '.github/workflows/firebaseai.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'scripts/quickstart_build_spm.sh' - 'scripts/quickstart_spm_xcodeproj.sh' - 'Gemfile*' diff --git a/.github/workflows/functions.yml b/.github/workflows/functions.yml index bd279cb3f55..5a4d6271ed6 100644 --- a/.github/workflows/functions.yml +++ b/.github/workflows/functions.yml @@ -11,7 +11,7 @@ on: - 'FirebaseSharedSwift**' - '.github/workflows/functions.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'FirebaseAuth/Interop/*.h' - 'FirebaseMessaging/Interop/*.h' - 'FirebaseTestingSupport/Functions/**' diff --git a/.github/workflows/inappmessaging.yml b/.github/workflows/inappmessaging.yml index 6650fbb8fc9..931bc97e5d5 100644 --- a/.github/workflows/inappmessaging.yml +++ b/.github/workflows/inappmessaging.yml @@ -11,7 +11,7 @@ on: - 'Interop/Analytics/Public/*.h' - '.github/workflows/inappmessaging.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 10pm (PST) - cron uses UTC times diff --git a/.github/workflows/messaging.yml b/.github/workflows/messaging.yml index 71d8c111578..006579d61b7 100644 --- a/.github/workflows/messaging.yml +++ b/.github/workflows/messaging.yml @@ -17,7 +17,7 @@ on: - '.github/workflows/messaging.yml' # Re-usable workflows being used by this file. - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' # Rebuild on Ruby infrastructure changes - 'Gemfile*' schedule: diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index b5e0beea295..024a36f8297 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -17,7 +17,7 @@ on: - '.github/workflows/performance.yml' # Re-usable workflows depended on by this file. - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' # Rebuild on Ruby infrastructure changes - 'Gemfile*' schedule: diff --git a/.github/workflows/remoteconfig.yml b/.github/workflows/remoteconfig.yml index 3f23f427b3a..346142ab42c 100644 --- a/.github/workflows/remoteconfig.yml +++ b/.github/workflows/remoteconfig.yml @@ -11,7 +11,7 @@ on: - 'Interop/Analytics/Public/*.h' - '.github/workflows/remoteconfig.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' - 'scripts/generate_access_token.sh' - 'scripts/gha-encrypted/RemoteConfigSwiftAPI/**' diff --git a/.github/workflows/sessions.yml b/.github/workflows/sessions.yml index 976b3886c1f..7d5873600f0 100644 --- a/.github/workflows/sessions.yml +++ b/.github/workflows/sessions.yml @@ -11,7 +11,7 @@ on: - 'FirebaseSessions.podspec' - '.github/workflows/sessions.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 9am (PST) - cron uses UTC times diff --git a/.github/workflows/shared-swift.yml b/.github/workflows/shared-swift.yml index b1292ebb253..95e1231ca50 100644 --- a/.github/workflows/shared-swift.yml +++ b/.github/workflows/shared-swift.yml @@ -10,7 +10,7 @@ on: - 'FirebaseSharedSwift**' - '.github/workflows/shared-swift.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/vertexai.yml b/.github/workflows/vertexai.yml index c5db31d75df..b81e446c55d 100644 --- a/.github/workflows/vertexai.yml +++ b/.github/workflows/vertexai.yml @@ -10,7 +10,7 @@ on: - 'FirebaseVertexAI**' - '.github/workflows/vertexai.yml' - '.github/workflows/common.yml' - - '.github/workflows/common_cocoapods.yml' +# - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 11pm (PST) - cron uses UTC times From 1d3c7571a024086807acf6ad0e071437f33ba7ab Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 29 May 2025 10:24:07 -0400 Subject: [PATCH 04/18] debug: maybe this will work --- .github/workflows/abtesting.yml | 2 +- .github/workflows/appdistribution.yml | 2 +- .github/workflows/auth.yml | 2 +- .github/workflows/core.yml | 2 +- .github/workflows/core_extension.yml | 2 +- .github/workflows/core_internal.yml | 2 +- .github/workflows/crashlytics.yml | 2 +- .github/workflows/database.yml | 2 +- .github/workflows/dynamiclinks.yml | 2 +- .github/workflows/firebase_app_check.yml | 2 +- .github/workflows/firebaseai.yml | 2 +- .github/workflows/functions.yml | 2 +- .github/workflows/inappmessaging.yml | 2 +- .github/workflows/messaging.yml | 2 +- .github/workflows/performance.yml | 2 +- .github/workflows/remoteconfig.yml | 2 +- .github/workflows/sessions.yml | 2 +- .github/workflows/shared-swift.yml | 2 +- .github/workflows/vertexai.yml | 2 +- 19 files changed, 19 insertions(+), 19 deletions(-) diff --git a/.github/workflows/abtesting.yml b/.github/workflows/abtesting.yml index 79308a3630b..dbf8ddf275b 100644 --- a/.github/workflows/abtesting.yml +++ b/.github/workflows/abtesting.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseABTesting**' - 'Interop/Analytics/Public/*.h' - - '.github/workflows/abtesting.yml' + # - '.github/workflows/abtesting.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/appdistribution.yml b/.github/workflows/appdistribution.yml index a9fa683e654..ab22a19e40d 100644 --- a/.github/workflows/appdistribution.yml +++ b/.github/workflows/appdistribution.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseAppDistribution**' - - '.github/workflows/appdistribution.yml' + # - '.github/workflows/appdistribution.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/auth.yml b/.github/workflows/auth.yml index bc2be33669b..4c694bfb6b8 100644 --- a/.github/workflows/auth.yml +++ b/.github/workflows/auth.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseAuth**' - 'FirebaseAuth/Interop/*.h' - - '.github/workflows/auth.yml' + # - '.github/workflows/auth.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'scripts/gha-encrypted/AuthSample/SwiftApplication.plist.gpg' diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 902429306c5..75523c1d1df 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseCore**' - - '.github/workflows/core.yml' + # - '.github/workflows/core.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/core_extension.yml b/.github/workflows/core_extension.yml index 884cbf9555d..2ed0fcc2fa5 100644 --- a/.github/workflows/core_extension.yml +++ b/.github/workflows/core_extension.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseCoreExtension.podspec' - 'FirebaseCore/Extension/**' - - '.github/workflows/core_extension.yml' + # - '.github/workflows/core_extension.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/core_internal.yml b/.github/workflows/core_internal.yml index c8ef829be71..0e6fd6b69b0 100644 --- a/.github/workflows/core_internal.yml +++ b/.github/workflows/core_internal.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseCoreInternal.podspec' - 'FirebaseCore/Internal/**' - - '.github/workflows/core_internal.yml' + # - '.github/workflows/core_internal.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index b6b8fbf5de9..6cba70b9a76 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -9,7 +9,7 @@ on: paths: - 'Crashlytics**' - 'FirebaseCrashlytics.podspec' - - '.github/workflows/crashlytics.yml' + # - '.github/workflows/crashlytics.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Interop/Analytics/Public/*.h' diff --git a/.github/workflows/database.yml b/.github/workflows/database.yml index 04628852695..e5e9fd14df5 100644 --- a/.github/workflows/database.yml +++ b/.github/workflows/database.yml @@ -12,7 +12,7 @@ on: - 'FirebaseSharedSwift**' - 'Example/Database/**' - 'FirebaseAuth/Interop/*.h' - - '.github/workflows/database.yml' + # - '.github/workflows/database.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/dynamiclinks.yml b/.github/workflows/dynamiclinks.yml index 48d7bf0745a..85523752b77 100644 --- a/.github/workflows/dynamiclinks.yml +++ b/.github/workflows/dynamiclinks.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseDynamicLinks**' - - '.github/workflows/dynamiclinks.yml' + # - '.github/workflows/dynamiclinks.yml' - 'Interop/Analytics/Public/*.h' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' diff --git a/.github/workflows/firebase_app_check.yml b/.github/workflows/firebase_app_check.yml index 41b65d493bb..b9d438cc0a5 100644 --- a/.github/workflows/firebase_app_check.yml +++ b/.github/workflows/firebase_app_check.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseAppCheck**' - - '.github/workflows/firebase_app_check.yml' + # - '.github/workflows/firebase_app_check.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/firebaseai.yml b/.github/workflows/firebaseai.yml index 022c1ef9209..ab7b2cd864a 100644 --- a/.github/workflows/firebaseai.yml +++ b/.github/workflows/firebaseai.yml @@ -4,7 +4,7 @@ on: pull_request: paths: - 'FirebaseAI**' - - '.github/workflows/firebaseai.yml' + # - '.github/workflows/firebaseai.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'scripts/quickstart_build_spm.sh' diff --git a/.github/workflows/functions.yml b/.github/workflows/functions.yml index 5a4d6271ed6..ebe6746b2fb 100644 --- a/.github/workflows/functions.yml +++ b/.github/workflows/functions.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseFunctions**' - 'FirebaseSharedSwift**' - - '.github/workflows/functions.yml' + # - '.github/workflows/functions.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'FirebaseAuth/Interop/*.h' diff --git a/.github/workflows/inappmessaging.yml b/.github/workflows/inappmessaging.yml index 931bc97e5d5..08ef8f40690 100644 --- a/.github/workflows/inappmessaging.yml +++ b/.github/workflows/inappmessaging.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseInAppMessaging**' - 'Interop/Analytics/Public/*.h' - - '.github/workflows/inappmessaging.yml' + # - '.github/workflows/inappmessaging.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/messaging.yml b/.github/workflows/messaging.yml index 006579d61b7..d2b90630d27 100644 --- a/.github/workflows/messaging.yml +++ b/.github/workflows/messaging.yml @@ -14,7 +14,7 @@ on: # Podspec - 'FirebaseMessaging.podspec' # This file - - '.github/workflows/messaging.yml' + # - '.github/workflows/messaging.yml' # Re-usable workflows being used by this file. - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index 024a36f8297..0fa4d21f94e 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -14,7 +14,7 @@ on: # Podspec - 'FirebasePerformance.podspec' # YML configuration file - - '.github/workflows/performance.yml' + # - '.github/workflows/performance.yml' # Re-usable workflows depended on by this file. - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' diff --git a/.github/workflows/remoteconfig.yml b/.github/workflows/remoteconfig.yml index 346142ab42c..e4ff629356a 100644 --- a/.github/workflows/remoteconfig.yml +++ b/.github/workflows/remoteconfig.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseRemoteConfig**' - 'Interop/Analytics/Public/*.h' - - '.github/workflows/remoteconfig.yml' + # - '.github/workflows/remoteconfig.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/sessions.yml b/.github/workflows/sessions.yml index 7d5873600f0..96de33f2c10 100644 --- a/.github/workflows/sessions.yml +++ b/.github/workflows/sessions.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseSessions**' - 'FirebaseSessions.podspec' - - '.github/workflows/sessions.yml' + # - '.github/workflows/sessions.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/shared-swift.yml b/.github/workflows/shared-swift.yml index 95e1231ca50..e973488d8e9 100644 --- a/.github/workflows/shared-swift.yml +++ b/.github/workflows/shared-swift.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseSharedSwift**' - - '.github/workflows/shared-swift.yml' + # - '.github/workflows/shared-swift.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/vertexai.yml b/.github/workflows/vertexai.yml index b81e446c55d..73c5982c3e6 100644 --- a/.github/workflows/vertexai.yml +++ b/.github/workflows/vertexai.yml @@ -8,7 +8,7 @@ on: paths: - 'FirebaseAI**' - 'FirebaseVertexAI**' - - '.github/workflows/vertexai.yml' + # - '.github/workflows/vertexai.yml' - '.github/workflows/common.yml' # - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' From 2a07499f36640200bee7b2449a3e125ebff9fb45 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 29 May 2025 10:25:29 -0400 Subject: [PATCH 05/18] debug: only lint ios --- .github/workflows/mlmodeldownloader.yml | 119 ++++++++++++------------ 1 file changed, 60 insertions(+), 59 deletions(-) diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 845b184b34e..97076e4f9c4 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -18,21 +18,22 @@ concurrency: cancel-in-progress: true jobs: - spm: - uses: ./.github/workflows/common.yml - with: - target: FirebaseMLModelDownloaderUnit + # spm: + # uses: ./.github/workflows/common.yml + # with: + # target: FirebaseMLModelDownloaderUnit - catalyst: - uses: ./.github/workflows/common_catalyst.yml - with: - product: FirebaseMLModelDownloader - target: FirebaseMLModelDownloader-Unit-unit + # catalyst: + # uses: ./.github/workflows/common_catalyst.yml + # with: + # product: FirebaseMLModelDownloader + # target: FirebaseMLModelDownloader-Unit-unit pod_lib_lint: uses: ./.github/workflows/common_cocoapods.yml with: product: FirebaseMLModelDownloader + platforms: iOS setup_command: | scripts/configure_test_keychain.sh mkdir FirebaseMLModelDownloader/Tests/Integration/Resources @@ -43,54 +44,54 @@ jobs: pwd - mlmodeldownloader-cron-only: - if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk' - runs-on: macos-15 - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - strategy: - matrix: - target: [ios, tvos, macos] - needs: pod_lib_lint - steps: - - uses: actions/checkout@v4 - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer - - name: Setup Bundler - run: scripts/setup_bundler.sh - - name: Configure test keychain - run: scripts/configure_test_keychain.sh - - name: Install GoogleService-Info.plist - run: | - mkdir FirebaseMLModelDownloader/Tests/Integration/Resources - scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ - FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" - - name: PodLibLint MLModelDownloader Cron - run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseMLModelDownloader.podspec --platforms=${{ matrix.target }} --use-static-frameworks + # mlmodeldownloader-cron-only: + # if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk' + # runs-on: macos-15 + # env: + # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + # strategy: + # matrix: + # target: [ios, tvos, macos] + # needs: pod_lib_lint + # steps: + # - uses: actions/checkout@v4 + # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + # - name: Xcode + # run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer + # - name: Setup Bundler + # run: scripts/setup_bundler.sh + # - name: Configure test keychain + # run: scripts/configure_test_keychain.sh + # - name: Install GoogleService-Info.plist + # run: | + # mkdir FirebaseMLModelDownloader/Tests/Integration/Resources + # scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ + # FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" + # - name: PodLibLint MLModelDownloader Cron + # run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseMLModelDownloader.podspec --platforms=${{ matrix.target }} --use-static-frameworks - mlmodeldownloader-sample-build-test: - # Don't run on private repo unless it is a PR. - if: github.repository == 'Firebase/firebase-ios-sdk' && (github.event_name == 'schedule' || github.event_name == 'pull_request') - env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - runs-on: macos-15 - steps: - - uses: actions/checkout@v4 - - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 - with: - cache_key: build-test${{ matrix.os }} - - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - - name: Xcode - run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer - - name: Setup Bundler - run: scripts/setup_bundler.sh - - name: Install GoogleService-Info.plist - run: | - mkdir FirebaseMLModelDownloader/Apps/Sample/Resources - scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ - FirebaseMLModelDownloader/Apps/Sample/Resources/GoogleService-Info.plist "$plist_secret" - - name: Prereqs - run: scripts/install_prereqs.sh MLModelDownloaderSample iOS - - name: Build - run: ([ -z $plist_secret ] || scripts/build.sh MLModelDownloaderSample iOS) + # mlmodeldownloader-sample-build-test: + # # Don't run on private repo unless it is a PR. + # if: github.repository == 'Firebase/firebase-ios-sdk' && (github.event_name == 'schedule' || github.event_name == 'pull_request') + # env: + # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + # runs-on: macos-15 + # steps: + # - uses: actions/checkout@v4 + # - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 + # with: + # cache_key: build-test${{ matrix.os }} + # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + # - name: Xcode + # run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer + # - name: Setup Bundler + # run: scripts/setup_bundler.sh + # - name: Install GoogleService-Info.plist + # run: | + # mkdir FirebaseMLModelDownloader/Apps/Sample/Resources + # scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ + # FirebaseMLModelDownloader/Apps/Sample/Resources/GoogleService-Info.plist "$plist_secret" + # - name: Prereqs + # run: scripts/install_prereqs.sh MLModelDownloaderSample iOS + # - name: Build + # run: ([ -z $plist_secret ] || scripts/build.sh MLModelDownloaderSample iOS) From decd09749780906ac766ed70ded79d4e6aa118dc Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 10:30:54 -0400 Subject: [PATCH 06/18] debug --- .github/workflows/mlmodeldownloader.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 97076e4f9c4..b55ebad8841 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -1,5 +1,8 @@ name: mlmodeldownloader +permissions: + contents: read + on: workflow_dispatch: pull_request: @@ -39,8 +42,7 @@ jobs: mkdir FirebaseMLModelDownloader/Tests/Integration/Resources scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" - ls - ls FirebaseMLModelDownloader/Tests/Integration/Resources + ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist pwd From ce45900ff69bdd3fa0442f43894b0689390d683d Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 10:35:44 -0400 Subject: [PATCH 07/18] Debug --- .github/workflows/common_cocoapods.yml | 1 + .github/workflows/mlmodeldownloader.yml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index c983cb4e6bd..3f6bc2c2887 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -106,6 +106,7 @@ jobs: if: inputs.setup_command != '' env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + MY_SECRET: "hello, world!" run: ${{ inputs.setup_command }} - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14' diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index b55ebad8841..b293da8e55a 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -42,8 +42,8 @@ jobs: mkdir FirebaseMLModelDownloader/Tests/Integration/Resources scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" + echo "$MY_SECRET" ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist - pwd # mlmodeldownloader-cron-only: From 41ed70cd3ddfd5ea38aab6f641b55358be9074fd Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 10:40:06 -0400 Subject: [PATCH 08/18] debug --- .github/workflows/common_cocoapods.yml | 2 +- .github/workflows/mlmodeldownloader.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index 3f6bc2c2887..12547ac37bf 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -106,7 +106,7 @@ jobs: if: inputs.setup_command != '' env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - MY_SECRET: "hello, world!" + MY_SECRET_14904: ${{ secrets.MY_SECRET_14904 }} run: ${{ inputs.setup_command }} - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14' diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index b293da8e55a..002d8da3e05 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -42,7 +42,7 @@ jobs: mkdir FirebaseMLModelDownloader/Tests/Integration/Resources scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" - echo "$MY_SECRET" + echo "$MY_SECRET_14904" ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist From 5a916d4b48dae4987fa8425fdeec145af3725ac3 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 10:42:45 -0400 Subject: [PATCH 09/18] Debug --- .github/workflows/common_cocoapods.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index 12547ac37bf..ba363dabd2e 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -107,7 +107,9 @@ jobs: env: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} MY_SECRET_14904: ${{ secrets.MY_SECRET_14904 }} - run: ${{ inputs.setup_command }} + run: | + echo "$MY_SECRET_14904" + ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14' with: From c1aef79584b77187d5a163af3eb09b066a4708d5 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 10:52:45 -0400 Subject: [PATCH 10/18] debug --- .github/workflows/common_cocoapods.yml | 4 ++++ .github/workflows/mlmodeldownloader.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index ba363dabd2e..ea080244612 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -5,6 +5,10 @@ permissions: on: workflow_call: + secrets: + MY_SECRET_14904: + required: false + inputs: # The product to test be tested (e.g. `FirebaseABTesting`). product: diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 002d8da3e05..fc63d7bd072 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -44,6 +44,7 @@ jobs: FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" echo "$MY_SECRET_14904" ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist + secrets: ${{ secrets.MY_SECRET_14904 }} # mlmodeldownloader-cron-only: From 4f9540524f8c2a17481abceb28ee20fce27eb5a3 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 10:53:59 -0400 Subject: [PATCH 11/18] fix syntax --- .github/workflows/mlmodeldownloader.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index fc63d7bd072..3a3e9f469bc 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -44,7 +44,7 @@ jobs: FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" echo "$MY_SECRET_14904" ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist - secrets: ${{ secrets.MY_SECRET_14904 }} + secrets: ${{ secrets.MY_SECRET_14904 }} # mlmodeldownloader-cron-only: From 69a4d9ab34f92c3d6db030c91af02d5c2696a511 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 10:55:28 -0400 Subject: [PATCH 12/18] debug --- .github/workflows/mlmodeldownloader.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 3a3e9f469bc..f00ceda9646 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -44,7 +44,8 @@ jobs: FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" echo "$MY_SECRET_14904" ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist - secrets: ${{ secrets.MY_SECRET_14904 }} + secrets: + MY_SECRET_14904: ${{ secrets.MY_SECRET_14904 }} # mlmodeldownloader-cron-only: From 3d3d7d52ff5d8f8f51ae8bf668e4a4d6403bc772 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 11:10:42 -0400 Subject: [PATCH 13/18] real attempt --- .github/workflows/common_cocoapods.yml | 9 +++------ .github/workflows/mlmodeldownloader.yml | 3 +-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index ea080244612..861a65f03ca 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -6,7 +6,7 @@ permissions: on: workflow_call: secrets: - MY_SECRET_14904: + plist_secret: required: false inputs: @@ -109,11 +109,8 @@ jobs: - name: Run setup command, if needed. if: inputs.setup_command != '' env: - plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - MY_SECRET_14904: ${{ secrets.MY_SECRET_14904 }} - run: | - echo "$MY_SECRET_14904" - ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist + plist_secret: ${{ secrets.plist_secret }} + run: ${{ inputs.setup_command }} - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14' with: diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index f00ceda9646..2f0f2eba262 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -45,8 +45,7 @@ jobs: echo "$MY_SECRET_14904" ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist secrets: - MY_SECRET_14904: ${{ secrets.MY_SECRET_14904 }} - + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} # mlmodeldownloader-cron-only: # if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk' From 4eb14697c24a0e689dcdde14e2a5c4ba9a1349d2 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 11:23:42 -0400 Subject: [PATCH 14/18] add comment and remove debug logic --- .github/workflows/common_cocoapods.yml | 18 ++++++++++++++++++ .github/workflows/mlmodeldownloader.yml | 2 -- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index 861a65f03ca..a3b5cb5a6b4 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -5,6 +5,24 @@ permissions: on: workflow_call: + # Re-usable workflows do not automatically inherit the caller's secrets. + # + # If the calling workflow uses a secret in the `setup_command` input, then + # it also must pass the secret to the re-usable workflow. + # + # Example: + # + # pod_lib_lint: + # uses: ./.github/workflows/common_cocoapods.yml + # with: + # product: FirebaseFoo + # setup_command: | + # scripts/decrypt_gha_secret.sh \ + # /path/to/GoogleService-Info.plist.gpg \ + # /path/to/dest/GoogleService-Info.plist "$plist_secret" + # secrets: + # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + # secrets: plist_secret: required: false diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 2f0f2eba262..2b7a84a99cb 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -42,8 +42,6 @@ jobs: mkdir FirebaseMLModelDownloader/Tests/Integration/Resources scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" - echo "$MY_SECRET_14904" - ls FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist secrets: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} From 522d7905135954500dcb7df36989989bc7bc5970 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 29 May 2025 11:58:12 -0400 Subject: [PATCH 15/18] DNM Nc/ml ci fork1 (#14911) --- .github/workflows/mlmodeldownloader.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 2b7a84a99cb..c46e4fda1e5 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -36,9 +36,9 @@ jobs: uses: ./.github/workflows/common_cocoapods.yml with: product: FirebaseMLModelDownloader - platforms: iOS + platforms: macOS +# scripts/configure_test_keychain.sh setup_command: | - scripts/configure_test_keychain.sh mkdir FirebaseMLModelDownloader/Tests/Integration/Resources scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" From ddc1bf5de8f953d51d2177ef7e7213c100ef1174 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 29 May 2025 12:00:41 -0400 Subject: [PATCH 16/18] revert changes --- .github/workflows/abtesting.yml | 4 ++-- .github/workflows/appdistribution.yml | 4 ++-- .github/workflows/auth.yml | 4 ++-- .github/workflows/core.yml | 4 ++-- .github/workflows/core_extension.yml | 4 ++-- .github/workflows/core_internal.yml | 4 ++-- .github/workflows/crashlytics.yml | 4 ++-- .github/workflows/database.yml | 4 ++-- .github/workflows/dynamiclinks.yml | 4 ++-- .github/workflows/firebase_app_check.yml | 4 ++-- .github/workflows/firebaseai.yml | 4 ++-- .github/workflows/functions.yml | 4 ++-- .github/workflows/inappmessaging.yml | 4 ++-- .github/workflows/messaging.yml | 4 ++-- .github/workflows/performance.yml | 4 ++-- .github/workflows/remoteconfig.yml | 4 ++-- .github/workflows/sessions.yml | 4 ++-- .github/workflows/shared-swift.yml | 4 ++-- .github/workflows/vertexai.yml | 4 ++-- 19 files changed, 38 insertions(+), 38 deletions(-) diff --git a/.github/workflows/abtesting.yml b/.github/workflows/abtesting.yml index dbf8ddf275b..f874410e988 100644 --- a/.github/workflows/abtesting.yml +++ b/.github/workflows/abtesting.yml @@ -9,9 +9,9 @@ on: paths: - 'FirebaseABTesting**' - 'Interop/Analytics/Public/*.h' - # - '.github/workflows/abtesting.yml' + - '.github/workflows/abtesting.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am(PST) - cron uses UTC times diff --git a/.github/workflows/appdistribution.yml b/.github/workflows/appdistribution.yml index ab22a19e40d..059a5ab88b6 100644 --- a/.github/workflows/appdistribution.yml +++ b/.github/workflows/appdistribution.yml @@ -8,9 +8,9 @@ on: pull_request: paths: - 'FirebaseAppDistribution**' - # - '.github/workflows/appdistribution.yml' + - '.github/workflows/appdistribution.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am (PST) - cron uses UTC times diff --git a/.github/workflows/auth.yml b/.github/workflows/auth.yml index 4c694bfb6b8..31a5f7584e9 100644 --- a/.github/workflows/auth.yml +++ b/.github/workflows/auth.yml @@ -9,9 +9,9 @@ on: paths: - 'FirebaseAuth**' - 'FirebaseAuth/Interop/*.h' - # - '.github/workflows/auth.yml' + - '.github/workflows/auth.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'scripts/gha-encrypted/AuthSample/SwiftApplication.plist.gpg' - 'Gemfile*' schedule: diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 75523c1d1df..70b8cb92612 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -8,9 +8,9 @@ on: pull_request: paths: - 'FirebaseCore**' - # - '.github/workflows/core.yml' + - '.github/workflows/core.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/core_extension.yml b/.github/workflows/core_extension.yml index 2ed0fcc2fa5..15b86f38538 100644 --- a/.github/workflows/core_extension.yml +++ b/.github/workflows/core_extension.yml @@ -9,9 +9,9 @@ on: paths: - 'FirebaseCoreExtension.podspec' - 'FirebaseCore/Extension/**' - # - '.github/workflows/core_extension.yml' + - '.github/workflows/core_extension.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/core_internal.yml b/.github/workflows/core_internal.yml index 0e6fd6b69b0..02ae537a6ff 100644 --- a/.github/workflows/core_internal.yml +++ b/.github/workflows/core_internal.yml @@ -9,9 +9,9 @@ on: paths: - 'FirebaseCoreInternal.podspec' - 'FirebaseCore/Internal/**' - # - '.github/workflows/core_internal.yml' + - '.github/workflows/core_internal.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 2am (PST) - cron uses UTC times diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 6cba70b9a76..05f492d68d3 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -9,9 +9,9 @@ on: paths: - 'Crashlytics**' - 'FirebaseCrashlytics.podspec' - # - '.github/workflows/crashlytics.yml' + - '.github/workflows/crashlytics.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Interop/Analytics/Public/*.h' - 'Gemfile*' schedule: diff --git a/.github/workflows/database.yml b/.github/workflows/database.yml index e5e9fd14df5..694ed7b48e5 100644 --- a/.github/workflows/database.yml +++ b/.github/workflows/database.yml @@ -12,9 +12,9 @@ on: - 'FirebaseSharedSwift**' - 'Example/Database/**' - 'FirebaseAuth/Interop/*.h' - # - '.github/workflows/database.yml' + - '.github/workflows/database.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' - 'scripts/run_database_emulator.sh' schedule: diff --git a/.github/workflows/dynamiclinks.yml b/.github/workflows/dynamiclinks.yml index 85523752b77..b6c2ff19c0b 100644 --- a/.github/workflows/dynamiclinks.yml +++ b/.github/workflows/dynamiclinks.yml @@ -8,10 +8,10 @@ on: pull_request: paths: - 'FirebaseDynamicLinks**' - # - '.github/workflows/dynamiclinks.yml' + - '.github/workflows/dynamiclinks.yml' - 'Interop/Analytics/Public/*.h' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 1am (PST) - cron uses UTC times diff --git a/.github/workflows/firebase_app_check.yml b/.github/workflows/firebase_app_check.yml index b9d438cc0a5..5e5c749d808 100644 --- a/.github/workflows/firebase_app_check.yml +++ b/.github/workflows/firebase_app_check.yml @@ -8,9 +8,9 @@ on: pull_request: paths: - 'FirebaseAppCheck**' - # - '.github/workflows/firebase_app_check.yml' + - '.github/workflows/firebase_app_check.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 11pm (PST) - cron uses UTC times diff --git a/.github/workflows/firebaseai.yml b/.github/workflows/firebaseai.yml index ab7b2cd864a..1184ce74897 100644 --- a/.github/workflows/firebaseai.yml +++ b/.github/workflows/firebaseai.yml @@ -4,9 +4,9 @@ on: pull_request: paths: - 'FirebaseAI**' - # - '.github/workflows/firebaseai.yml' + - '.github/workflows/firebaseai.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'scripts/quickstart_build_spm.sh' - 'scripts/quickstart_spm_xcodeproj.sh' - 'Gemfile*' diff --git a/.github/workflows/functions.yml b/.github/workflows/functions.yml index ebe6746b2fb..bd279cb3f55 100644 --- a/.github/workflows/functions.yml +++ b/.github/workflows/functions.yml @@ -9,9 +9,9 @@ on: paths: - 'FirebaseFunctions**' - 'FirebaseSharedSwift**' - # - '.github/workflows/functions.yml' + - '.github/workflows/functions.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'FirebaseAuth/Interop/*.h' - 'FirebaseMessaging/Interop/*.h' - 'FirebaseTestingSupport/Functions/**' diff --git a/.github/workflows/inappmessaging.yml b/.github/workflows/inappmessaging.yml index 08ef8f40690..6650fbb8fc9 100644 --- a/.github/workflows/inappmessaging.yml +++ b/.github/workflows/inappmessaging.yml @@ -9,9 +9,9 @@ on: paths: - 'FirebaseInAppMessaging**' - 'Interop/Analytics/Public/*.h' - # - '.github/workflows/inappmessaging.yml' + - '.github/workflows/inappmessaging.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 10pm (PST) - cron uses UTC times diff --git a/.github/workflows/messaging.yml b/.github/workflows/messaging.yml index d2b90630d27..71d8c111578 100644 --- a/.github/workflows/messaging.yml +++ b/.github/workflows/messaging.yml @@ -14,10 +14,10 @@ on: # Podspec - 'FirebaseMessaging.podspec' # This file - # - '.github/workflows/messaging.yml' + - '.github/workflows/messaging.yml' # Re-usable workflows being used by this file. - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' # Rebuild on Ruby infrastructure changes - 'Gemfile*' schedule: diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index 0fa4d21f94e..b5e0beea295 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -14,10 +14,10 @@ on: # Podspec - 'FirebasePerformance.podspec' # YML configuration file - # - '.github/workflows/performance.yml' + - '.github/workflows/performance.yml' # Re-usable workflows depended on by this file. - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' # Rebuild on Ruby infrastructure changes - 'Gemfile*' schedule: diff --git a/.github/workflows/remoteconfig.yml b/.github/workflows/remoteconfig.yml index e4ff629356a..3f23f427b3a 100644 --- a/.github/workflows/remoteconfig.yml +++ b/.github/workflows/remoteconfig.yml @@ -9,9 +9,9 @@ on: paths: - 'FirebaseRemoteConfig**' - 'Interop/Analytics/Public/*.h' - # - '.github/workflows/remoteconfig.yml' + - '.github/workflows/remoteconfig.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' - 'scripts/generate_access_token.sh' - 'scripts/gha-encrypted/RemoteConfigSwiftAPI/**' diff --git a/.github/workflows/sessions.yml b/.github/workflows/sessions.yml index 96de33f2c10..976b3886c1f 100644 --- a/.github/workflows/sessions.yml +++ b/.github/workflows/sessions.yml @@ -9,9 +9,9 @@ on: paths: - 'FirebaseSessions**' - 'FirebaseSessions.podspec' - # - '.github/workflows/sessions.yml' + - '.github/workflows/sessions.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 9am (PST) - cron uses UTC times diff --git a/.github/workflows/shared-swift.yml b/.github/workflows/shared-swift.yml index e973488d8e9..b1292ebb253 100644 --- a/.github/workflows/shared-swift.yml +++ b/.github/workflows/shared-swift.yml @@ -8,9 +8,9 @@ on: pull_request: paths: - 'FirebaseSharedSwift**' - # - '.github/workflows/shared-swift.yml' + - '.github/workflows/shared-swift.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: diff --git a/.github/workflows/vertexai.yml b/.github/workflows/vertexai.yml index 73c5982c3e6..c5db31d75df 100644 --- a/.github/workflows/vertexai.yml +++ b/.github/workflows/vertexai.yml @@ -8,9 +8,9 @@ on: paths: - 'FirebaseAI**' - 'FirebaseVertexAI**' - # - '.github/workflows/vertexai.yml' + - '.github/workflows/vertexai.yml' - '.github/workflows/common.yml' -# - '.github/workflows/common_cocoapods.yml' + - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' schedule: # Run every day at 11pm (PST) - cron uses UTC times From c51ed7b718a084bd9f9fd0e8d19cdef751b21411 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Thu, 29 May 2025 12:01:23 -0400 Subject: [PATCH 17/18] Update mlmodeldownloader.yml --- .github/workflows/mlmodeldownloader.yml | 120 ++++++++++++------------ 1 file changed, 59 insertions(+), 61 deletions(-) diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index c46e4fda1e5..6e16642d311 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -21,23 +21,21 @@ concurrency: cancel-in-progress: true jobs: - # spm: - # uses: ./.github/workflows/common.yml - # with: - # target: FirebaseMLModelDownloaderUnit + spm: + uses: ./.github/workflows/common.yml + with: + target: FirebaseMLModelDownloaderUnit - # catalyst: - # uses: ./.github/workflows/common_catalyst.yml - # with: - # product: FirebaseMLModelDownloader - # target: FirebaseMLModelDownloader-Unit-unit + catalyst: + uses: ./.github/workflows/common_catalyst.yml + with: + product: FirebaseMLModelDownloader + target: FirebaseMLModelDownloader-Unit-unit pod_lib_lint: uses: ./.github/workflows/common_cocoapods.yml with: product: FirebaseMLModelDownloader - platforms: macOS -# scripts/configure_test_keychain.sh setup_command: | mkdir FirebaseMLModelDownloader/Tests/Integration/Resources scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ @@ -45,54 +43,54 @@ jobs: secrets: plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - # mlmodeldownloader-cron-only: - # if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk' - # runs-on: macos-15 - # env: - # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - # strategy: - # matrix: - # target: [ios, tvos, macos] - # needs: pod_lib_lint - # steps: - # - uses: actions/checkout@v4 - # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - # - name: Xcode - # run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer - # - name: Setup Bundler - # run: scripts/setup_bundler.sh - # - name: Configure test keychain - # run: scripts/configure_test_keychain.sh - # - name: Install GoogleService-Info.plist - # run: | - # mkdir FirebaseMLModelDownloader/Tests/Integration/Resources - # scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ - # FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" - # - name: PodLibLint MLModelDownloader Cron - # run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseMLModelDownloader.podspec --platforms=${{ matrix.target }} --use-static-frameworks + mlmodeldownloader-cron-only: + if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk' + runs-on: macos-15 + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + strategy: + matrix: + target: [ios, tvos, macos] + needs: pod_lib_lint + steps: + - uses: actions/checkout@v4 + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + - name: Xcode + run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer + - name: Setup Bundler + run: scripts/setup_bundler.sh + - name: Configure test keychain + run: scripts/configure_test_keychain.sh + - name: Install GoogleService-Info.plist + run: | + mkdir FirebaseMLModelDownloader/Tests/Integration/Resources + scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ + FirebaseMLModelDownloader/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret" + - name: PodLibLint MLModelDownloader Cron + run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseMLModelDownloader.podspec --platforms=${{ matrix.target }} --use-static-frameworks - # mlmodeldownloader-sample-build-test: - # # Don't run on private repo unless it is a PR. - # if: github.repository == 'Firebase/firebase-ios-sdk' && (github.event_name == 'schedule' || github.event_name == 'pull_request') - # env: - # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} - # runs-on: macos-15 - # steps: - # - uses: actions/checkout@v4 - # - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 - # with: - # cache_key: build-test${{ matrix.os }} - # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 - # - name: Xcode - # run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer - # - name: Setup Bundler - # run: scripts/setup_bundler.sh - # - name: Install GoogleService-Info.plist - # run: | - # mkdir FirebaseMLModelDownloader/Apps/Sample/Resources - # scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ - # FirebaseMLModelDownloader/Apps/Sample/Resources/GoogleService-Info.plist "$plist_secret" - # - name: Prereqs - # run: scripts/install_prereqs.sh MLModelDownloaderSample iOS - # - name: Build - # run: ([ -z $plist_secret ] || scripts/build.sh MLModelDownloaderSample iOS) + mlmodeldownloader-sample-build-test: + # Don't run on private repo unless it is a PR. + if: github.repository == 'Firebase/firebase-ios-sdk' && (github.event_name == 'schedule' || github.event_name == 'pull_request') + env: + plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} + runs-on: macos-15 + steps: + - uses: actions/checkout@v4 + - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 + with: + cache_key: build-test${{ matrix.os }} + - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 + - name: Xcode + run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer + - name: Setup Bundler + run: scripts/setup_bundler.sh + - name: Install GoogleService-Info.plist + run: | + mkdir FirebaseMLModelDownloader/Apps/Sample/Resources + scripts/decrypt_gha_secret.sh scripts/gha-encrypted/MLModelDownloader/GoogleService-Info.plist.gpg \ + FirebaseMLModelDownloader/Apps/Sample/Resources/GoogleService-Info.plist "$plist_secret" + - name: Prereqs + run: scripts/install_prereqs.sh MLModelDownloaderSample iOS + - name: Build + run: ([ -z $plist_secret ] || scripts/build.sh MLModelDownloaderSample iOS) From eee92ddb0a32eeef1658ac83b88864ee0c89892c Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Thu, 29 May 2025 12:06:44 -0400 Subject: [PATCH 18/18] improve comment --- .github/workflows/common_cocoapods.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/common_cocoapods.yml b/.github/workflows/common_cocoapods.yml index a3b5cb5a6b4..50834b04431 100644 --- a/.github/workflows/common_cocoapods.yml +++ b/.github/workflows/common_cocoapods.yml @@ -88,8 +88,9 @@ on: # This is useful for additional set up, like starting an emulator or # downloading test data. # - # Note, this step has env var set to decrypt plists. Use "$plist_secret" - # in the given command. + # Note, this step has an env var set to decrypt plists. Use + # "$plist_secret" in the given command. See `secrets` documentation + # at top of this file. # # Example: `FirebaseFunctions/Backend/start.sh synchronous` setup_command: