Not showing next message if only mark as read.

[igorjacauna]

Step 1: Describe your environment

• Xcode version: 13.14.1
• Firebase SDK version: 8.8.0
• Installation method: CocoaPods
• Firebase Component: Messaging
• Target platform(s): iOS

Step 2: Describe the problem

We are implementing FIRInAppMessagingDisplay to create custom UI for InAppMessage.

We found a problem with Card message.

When we have a stack of messages, we stuck when a Card message arrives. And after shows Card message no messages shows up

Steps to reproduce:

Have one event called screen_event and 3 messages bind to it, message A of type ImageOnly, message B of typeCard and message C of type Banner.

1. We trigger the event screen_event when screen get focused. The message A of type ImageOnly is showed and we call impressionDetectedForMessage for it. After that user dismissed or clicked on message.
2. After while we trigger the screen_event again and the B message is showed and we call impressionDetectedForMessage for it. Our custom component for message of type Card are showed embed to layout, i.e., there is no dismiss button. The user do not interact with the message, once is embeded on layout he scroll the screen for example.
3. After while we trigger again the event screen_event, but the message C is not showed.

The problem is that after message B of type Card shows up, next message are not showed. But if user interact with message B of type Card and we call messageClicked everything works. And if we trigger the event screen_event again the message C of type Banner shows up.

Seems like impressionDetectedForMessage not working with type Card. The flow of messages only works when call messageClicked for message of type Card for others types impressionDetectedForMessage works fine

[rizafran]

Thanks for reaching out, @igorjacauna. To make sure that we're on the same page, could you provide a minimal repro or code snippet to see how all the 3 messages appear in your app? Also, is the issue reproducible using the latest version?

[igorjacauna]

Hi @rizafran we discovery that the problem is with any type of message. If we only mark it as read, the next message does not shows up, only if we mark as clicked or dismissed.

Just for comparison of behavior, on Android the flow has no problem, the messages from stack show up when we trigger the event screen_event

Setup

I have configured 3 messages that has the event screen_event bind to each one:

1. Image Only
2. Card
3. Modal

On screen we hava a button that fire the event screen_event and when we shows a Card message, we shows a button that mark it as clicked

Explanation:

We click on button that fire the screen_event and the expected behavior is the messages shows up in order. But when Card shows up the flow stuck on it. And the 3rd message only shows if we mark the Card message as clicked.

Steps

1. Click on button to trigger screen_event
2. The Image Only shows up
3. Close the Image Only
4. Click on button to trigger screen_event
5. The Card shows up embedded to layout
6. Do nothing
7. Click on button to trigger screen_event
8. Nothing happen
9. Click on button to mark Card as clicked
10. Click on button to trigger screen_event
11. Modal shows up

Every time a message shows up we try to mark it as read. No error shows up on Console

Record

[rizafran]

Thanks for sharing the steps, @igorjacauna. As mentioned, is it possible for you to provide a minimal repro that I can run locally or a code snippet on how you display the 3 types of messages? Also, is it reproducible using the latest SDK version?

[igorjacauna]

Hi @rizafran, we tried with the latest SDK version and the problem is present there too.

In our code we have two classes:

• InAppMessageDisplay: Receives the message from Firebase
• InAppMessageManager: Handle which data and fire event to our ReactNative layer to shows the message

To clarify, we use this with ReactNative using Native Modules. And every time we receive a message we send it to ReactNative and when it is rendered on it we call markAsImpressionDetected and if we fire the event to get next message without call markAsClicked or markAsDismissed nothing is coming from Firebase. Only if we call markAsClicked or markAsDismissed. On Android this not happen, it works if we call only markAsImpressionDetected

In AppDelegate.m we set our custom Display class

InAppMessageDisplay *display = [[InAppMessageDisplay alloc] init];
[FIRInAppMessaging inAppMessaging].messageDisplayComponent = display;

InAppMessageDisplay

#import <Foundation/Foundation.h>
#import <Firebase.h>
#import "InAppMessageDisplay.h"
#import "InAppMessageManager.h"

NSString *const kFIRAppReady = @"FIRAppReadyToConfigureSDKNotification";

@implementation InAppMessageDisplay : NSObject

+ (void)load {
  [[NSNotificationCenter defaultCenter] addObserver:self
                                           selector:@selector(didReceiveConfigureSDKNotification:)
                                               name:kFIRAppReady
                                             object:nil];
}

+ (void)didReceiveConfigureSDKNotification:(NSNotification *)notification {

  InAppMessageDisplay *display = [[InAppMessageDisplay alloc] init];
  [FIRInAppMessaging inAppMessaging].messageDisplayComponent = display;
}

- (void)displayMessage:(FIRInAppMessagingDisplayMessage *)messageForDisplay
       displayDelegate:(id<FIRInAppMessagingDisplayDelegate>)displayDelegate {
  if ([messageForDisplay isKindOfClass:[FIRInAppMessagingModalDisplay class]]) {
    InAppMessageManager *emitter = [InAppMessageManager allocWithZone: nil];
    [emitter FIAMReceivedModal:messageForDisplay displayDelegate:displayDelegate];
  } else if ([messageForDisplay isKindOfClass:[FIRInAppMessagingBannerDisplay class]]) {
    InAppMessageManager *emitter = [InAppMessageManager allocWithZone: nil];
    [emitter FIAMReceivedBanner:messageForDisplay displayDelegate:displayDelegate];
  } else if ([messageForDisplay isKindOfClass:[FIRInAppMessagingImageOnlyDisplay class]]) {
    InAppMessageManager *emitter = [InAppMessageManager allocWithZone: nil];
    [emitter FIAMReceivedImageOnly:messageForDisplay displayDelegate:displayDelegate];
  } else if ([messageForDisplay isKindOfClass:[FIRInAppMessagingCardDisplay class]]) {
    InAppMessageManager *emitter = [InAppMessageManager allocWithZone: nil];
    [emitter FIAMReceivedCard:messageForDisplay displayDelegate:displayDelegate];
  }
}
@end

InAppMessageManager

#import <Foundation/Foundation.h>
#import <React/RCTLog.h>
#import "InAppMessageDisplay.h"
#import "InAppMessageManager.h"

@implementation InAppMessageManager

RCT_EXPORT_MODULE();

- (nullable FIRInAppMessagingDisplayMessage *)inAppMessage {
  return nil;
}

- (NSMutableDictionary *) displayDelegateDict {
    if (!_displayDelegateDict) {
      _displayDelegateDict = [NSMutableDictionary new];
    }
    return _displayDelegateDict;
}

- (NSMutableDictionary *) inAppMessageDict {
    if (!_inAppMessageDict) {
      _inAppMessageDict = [NSMutableDictionary new];
    }
    return _inAppMessageDict;
}

+ (id)allocWithZone:(NSZone *)zone {
    static InAppMessageManager *sharedInstance = nil;
    static dispatch_once_t onceToken;
    dispatch_once(&onceToken, ^{
        sharedInstance = [super allocWithZone:zone];
    });
    return sharedInstance;
}

- (NSArray<NSString *> *)supportedEvents {
    return @[@"OnDisplayInAppMessage"];
}

RCT_EXPORT_METHOD(markAsImpressionDetected:(NSString *)messageId){
  if ([self.displayDelegateDict objectForKey:messageId]) {
    [[self.displayDelegateDict objectForKey:messageId] impressionDetectedForMessage:[self.inAppMessageDict objectForKey:messageId]];
  }
}

RCT_EXPORT_METHOD(markAsClicked:(NSString *)messageId){
  NSString *actionURL = @"";
  if ([[self.inAppMessageDict objectForKey:messageId] isKindOfClass:[FIRInAppMessagingModalDisplay class]]) {
    FIRInAppMessagingModalDisplay *message = [self.inAppMessageDict objectForKey:messageId];
    if (message.actionURL.absoluteString) {
      actionURL = message.actionURL.absoluteString;
    }
  } else if ([[self.inAppMessageDict objectForKey:messageId] isKindOfClass:[FIRInAppMessagingBannerDisplay class]]) {
    FIRInAppMessagingBannerDisplay *message = [self.inAppMessageDict objectForKey:messageId];
    if (message.actionURL.absoluteString) {
      actionURL = message.actionURL.absoluteString;
    }
  } else if ([[self.inAppMessageDict objectForKey:messageId] isKindOfClass:[FIRInAppMessagingImageOnlyDisplay class]]) {
    FIRInAppMessagingImageOnlyDisplay *message = [self.inAppMessageDict objectForKey:messageId];
    if (message.actionURL.absoluteString) {
      actionURL = message.actionURL.absoluteString;
    }
  } else if ([[self.inAppMessageDict objectForKey:messageId] isKindOfClass:[FIRInAppMessagingCardDisplay class]]) {
    FIRInAppMessagingCardDisplay *message = [self.inAppMessageDict objectForKey:messageId];
    if (message.primaryActionURL.absoluteString) {
      actionURL = message.primaryActionURL.absoluteString;
    }
  }
  if ([self.displayDelegateDict objectForKey:messageId]) {
    NSURL *url = [NSURL URLWithString:actionURL];
    FIRInAppMessagingAction *action =
            [[FIRInAppMessagingAction alloc] initWithActionText:nil
                                                      actionURL:url];
    [[self.displayDelegateDict objectForKey:messageId] messageClicked:[self.inAppMessageDict objectForKey:messageId] withAction: action];
  }
}

RCT_EXPORT_METHOD(markAsDismissed:(NSString *)messageId){
  if ([self.displayDelegateDict objectForKey:messageId]) {
    [[self.displayDelegateDict objectForKey:messageId] messageDismissed:[self.inAppMessageDict objectForKey:messageId] dismissType:FIRInAppMessagingDismissTypeAuto];
  }
}

- (void)FIAMReceivedModal: (FIRInAppMessagingModalDisplay *)inAppMessage
        displayDelegate:(id<FIRInAppMessagingDisplayDelegate>)displayDelegate {
  
  [self sendEventWithName:@"OnDisplayInAppMessage" body:@{
    @"type":@"Modal"
  }];
  self.displayDelegate = displayDelegate;
  [self.displayDelegateDict setObject:displayDelegate forKey:inAppMessage.campaignInfo.messageID];
  [self.inAppMessageDict setObject:inAppMessage forKey:inAppMessage.campaignInfo.messageID];
}

- (void)FIAMReceivedBanner: (FIRInAppMessagingBannerDisplay *)inAppMessage
        displayDelegate:(id<FIRInAppMessagingDisplayDelegate>)displayDelegate {
  [self sendEventWithName:@"OnDisplayInAppMessage" body:@{
    @"type":@"Banner"
  }];
  self.displayDelegate = displayDelegate;
  [self.displayDelegateDict setObject:displayDelegate forKey:inAppMessage.campaignInfo.messageID];
  [self.inAppMessageDict setObject:inAppMessage forKey:inAppMessage.campaignInfo.messageID];
}

- (void)FIAMReceivedImageOnly: (FIRInAppMessagingImageOnlyDisplay *)inAppMessage
        displayDelegate:(id<FIRInAppMessagingDisplayDelegate>)displayDelegate {
  [self sendEventWithName:@"OnDisplayInAppMessage" body:@{
    @"type":@"ImageOnly"
  }];
  self.displayDelegate = displayDelegate;
  [self.displayDelegateDict setObject:displayDelegate forKey:inAppMessage.campaignInfo.messageID];
  [self.inAppMessageDict setObject:inAppMessage forKey:inAppMessage.campaignInfo.messageID];
}

- (void)FIAMReceivedCard: (FIRInAppMessagingCardDisplay *)inAppMessage
        displayDelegate:(id<FIRInAppMessagingDisplayDelegate>)displayDelegate {
  [self sendEventWithName:@"OnDisplayInAppMessage" body:@{
    @"type":@"Card"
  }];
  self.displayDelegate = displayDelegate;
  [self.displayDelegateDict setObject:displayDelegate forKey:inAppMessage.campaignInfo.messageID];
  [self.inAppMessageDict setObject:inAppMessage forKey:inAppMessage.campaignInfo.messageID];
}

@end