Skip to content

Fix FIAM SwiftUI colors #8416

Open
Open
@paulb777

Description

@paulb777

SwiftUI preview support for FIAM was added in #8351. However, it was only tested for iOS and broke the tvOS CI because of using unsupported tvOS colors in SwiftUIPreviewHelpers.swift for backgroundColor, primaryButtonBackgroundColor, and secondaryButtonBackgroundColor. A placeholder fix was added in #8403 to fix CI.

The default colors still need to be reviewed in the sample app at FirebaseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/ and updated to work well for both iOS and tvOS previews.

Consider an additional check within these helpers that returns a light or dark color (for tvOS) based on interface style.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions