Fix the NumberEquals logic.

ehsannas · ehsannas · commit c1519bc3b779 · 2025-05-30T11:56:01.000-07:00
diff --git a/Firestore/core/src/model/value_util.cc b/Firestore/core/src/model/value_util.cc
@@ -705,7 +705,7 @@ ComparisonResult UpperBoundCompare(const google_firestore_v1_Value& left,
 
 bool NumberEquals(const google_firestore_v1_Value& left,
                   const google_firestore_v1_Value& right) {
-  if (IsDecimal128Value(left) || IsDecimal128Value(right)) {
+  if (IsDecimal128Value(left) && IsDecimal128Value(right)) {
     return Compare128BitNumbers(left, right) == util::ComparisonResult::Same;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -705,7 +705,7 @@ ComparisonResult UpperBoundCompare(const google_firestore_v1_Value& left,`
`705`	`705`
`706`	`706`	`bool NumberEquals(const google_firestore_v1_Value& left,`
`707`	`707`	`const google_firestore_v1_Value& right) {`
`708`		`- if (IsDecimal128Value(left) \|\| IsDecimal128Value(right)) {`
	`708`	`+ if (IsDecimal128Value(left) && IsDecimal128Value(right)) {`
`709`	`709`	`return Compare128BitNumbers(left, right) == util::ComparisonResult::Same;`
`710`	`710`	`}`
`711`	`711`