[auth-swift] Fix Sample build warnings

Author: paulb777

FirebaseAuth/Tests/SampleSwift/AuthenticationExample/Utility/DataSourceProvider/DataSourceProvider.swift

@@ -43,6 +43,7 @@ class DataSourceProvider<DataSource: DataSourceProvidable>: NSObject, UITableVie
     return sectionItem(at: indexPath)
   }
 
+  @discardableResult
   public func updateItem(at indexPath: IndexPath, item: Item) -> DataSource.Section.Item {
     return editSectionItem(at: indexPath, item: item)
   }

FirebaseAuth/Tests/SampleSwift/AuthenticationExample/ViewControllers/AuthViewController.swift

@@ -408,7 +408,8 @@ class AuthViewController: UIViewController, DataSourceProviderDelegate {
         return // Handle error case, returning early
       }
 
-      if let tokenResult = tokenResult, let claims = tokenResult.claims as? [String: Any] {
+      if let tokenResult = tokenResult {
+        let claims = tokenResult.claims
         var message = "Token refresh succeeded\n\n"
         for (key, value) in claims {
           message += "\(key): \(value)\n"
@@ -612,7 +613,7 @@ class AuthViewController: UIViewController, DataSourceProviderDelegate {
       if self.actionCodeRequestType == .email {
         AppManager.shared.auth().sendPasswordReset(withEmail: email, completion: completionHandler)
       } else {
-        guard let actionCodeContinueURL = self.actionCodeContinueURL else {
+        guard self.actionCodeContinueURL != nil else {
           print("Error: Action code continue URL is nil.")
           return
         }
@@ -684,9 +685,8 @@ class AuthViewController: UIViewController, DataSourceProviderDelegate {
       print("Check action code succeeded")
       let email = info.email
       let previousEmail = info.previousEmail
-      let message = previousEmail != nil ? "\(previousEmail!) -> \(email)" : email
       let operation = self.nameForActionCodeOperation(info.operation)
-      showAlert(for: operation)
+      showAlert(for: operation, message: previousEmail ?? email)
     }
     showTextInputPrompt(with: "OOB Code:") {
       oobCode in
@@ -724,7 +724,7 @@ class AuthViewController: UIViewController, DataSourceProviderDelegate {
         return
       }
       print("Verify password resest code succeeded.")
-      showAlert(for: "Code verified for email: \(email)")
+      showAlert(for: "Code verified for email: \(email ?? "missing email")")
     }
     showTextInputPrompt(with: "OOB Code: ") {
       oobCode in
@@ -1030,7 +1030,7 @@ class AuthViewController: UIViewController, DataSourceProviderDelegate {
     return nil
   }
 
-  func showAlert(for message: String) {
+  func showAlert(for title: String, message: String? = nil) {
     let alertController = UIAlertController(
       title: message,
       message: nil,

FirebaseAuth/Tests/SampleSwift/AuthenticationExample/ViewControllers/SettingsViewController.swift

@@ -132,7 +132,7 @@ class SettingsViewController: UIViewController, DataSourceProviderDelegate {
     let tokenType = token.type == .prod ? "Production" : "Sandbox"
     let message = "token: \(token.string)\ntype: \(tokenType)"
 
-    let prompt = UIAlertController(title: nil, message: "Clear APNs Token?",
+    let prompt = UIAlertController(title: "Clear APNs Token?", message: message,
                                    preferredStyle: .alert)
     let okAction = UIAlertAction(title: "OK", style: .default) { action in
       AppManager.shared.auth().tokenManager.token = nil
@@ -144,7 +144,8 @@ class SettingsViewController: UIViewController, DataSourceProviderDelegate {
 
   func clearAppCredential() {
     if let credential = AppManager.shared.auth().appCredentialManager.credential {
-      let prompt = UIAlertController(title: nil, message: "Clear APNs Token?",
+      let message = "receipt:\(credential.receipt) secret:\(credential.secret ?? "nil")"
+      let prompt = UIAlertController(title: "Clear App Credential", message: message,
                                      preferredStyle: .alert)
       let okAction = UIAlertAction(title: "OK", style: .default) { action in
         AppManager.shared.auth().appCredentialManager.clearCredential()

FirebaseAuth/Tests/SampleSwift/README.md

@@ -12,15 +12,7 @@ Firebase Auth offers multiple ways to authenticate users. In this sample, we dem
 
 Ready? Let's get started! 🏎💨
 
-Run `pod install`. This command will install all of the required cocoapods for this sample and generate a `.xcworkspace` project. Go ahead and open the `AuthenticationExample.xcworkspace` project.
-
-### Terminal commands to clone and open the project!
-```bash
-$ pod install --repo-update
-
-$ open AuthenticationExample.xcworkspace
-
-```
+Open the `AuthenticationExample.xcodeproj` project.
 
 ## Connecting to the [Firebase Console](https://console.firebase.google.com)