Skip to content

Commit 9f2f41f

Browse files
authored
[Config] Mark two RCNConfigSettings properties atomic (#13925)
1 parent 569bc38 commit 9f2f41f

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

FirebaseRemoteConfig/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# Unreleased
2+
- [fixed] Mark two internal properties as `atomic` to prevent concurrency
3+
related crash. (#13898)
4+
15
# 11.0.0
26
- [fixed] RemoteConfigValue stringValue is now `nonnull`. This may break some builds. (#10870)
37
- [removed] **Breaking change**: The deprecated `FirebaseRemoteConfigSwift`

FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,11 @@
4141
/// Device data version of checkin information.
4242
@property(nonatomic, copy) NSString *deviceDataVersion;
4343
/// InstallationsID.
44-
@property(nonatomic, copy) NSString *configInstallationsIdentifier;
44+
/// @note The property is atomic because it is accessed across multiple threads.
45+
@property(atomic, copy) NSString *configInstallationsIdentifier;
4546
/// Installations token.
46-
@property(nonatomic, copy) NSString *configInstallationsToken;
47+
/// @note The property is atomic because it is accessed across multiple threads.
48+
@property(atomic, copy) NSString *configInstallationsToken;
4749

4850
/// A list of successful fetch timestamps in milliseconds.
4951
/// TODO Not used anymore. Safe to remove.

0 commit comments

Comments
 (0)