Remove remaining FieldValue factory method usages.

Author: ehsannas

Firestore/Example/Tests/API/FIRFieldValueTests.mm

@@ -14,14 +14,8 @@
  * limitations under the License.
  */
 
-#import <FirebaseFirestore/FIRBsonBinaryData.h>
-#import <FirebaseFirestore/FIRBsonObjectId.h>
-#import <FirebaseFirestore/FIRBsonTimestamp.h>
 #import <FirebaseFirestore/FIRFieldValue.h>
-#import <FirebaseFirestore/FIRInt32Value.h>
-#import <FirebaseFirestore/FIRRegexValue.h>
 #import <FirebaseFirestore/FIRVectorValue.h>
-#import "Firestore/Example/Tests/Util/FSTHelpers.h"
 
 #import <XCTest/XCTest.h>
 
@@ -48,38 +42,6 @@ - (void)testEquals {
   XCTAssertNotEqual([deleted hash], [serverTimestamp hash]);
 }
 
-- (void)testCanCreateRegexValue {
-  FIRRegexValue *regex = [FIRFieldValue regexWithPattern:@"^foo" options:@"x"];
-  XCTAssertEqual(regex.pattern, @"^foo");
-  XCTAssertEqual(regex.options, @"x");
-}
-
-- (void)testCanCreateInt32Value {
-  FIRInt32Value *int1 = [FIRFieldValue int32WithValue:1234];
-  XCTAssertEqual(int1.value, 1234);
-
-  FIRInt32Value *int2 = [FIRFieldValue int32WithValue:-1234];
-  XCTAssertEqual(int2.value, -1234);
-}
-
-- (void)testCanCreateBsonObjectId {
-  FIRBsonObjectId *objectId = [FIRFieldValue bsonObjectIdWithValue:@"foo"];
-  XCTAssertEqual(objectId.value, @"foo");
-}
-
-- (void)testCanCreateBsonTimestamp {
-  FIRBsonTimestamp *timestamp = [FIRFieldValue bsonTimestampWithSeconds:123 increment:456];
-  XCTAssertEqual(timestamp.seconds, 123U);
-  XCTAssertEqual(timestamp.increment, 456U);
-}
-
-- (void)testCanCreateBsonBinaryData {
-  FIRBsonBinaryData *binData = [FIRFieldValue bsonBinaryDataWithSubtype:128
-                                                                   data:FSTTestData(1, 2, 3, -1)];
-  XCTAssertEqual(binData.subtype, 128);
-  XCTAssertTrue([binData.data isEqualToData:FSTTestData(1, 2, 3, -1)]);
-}
-
 @end
 
-NS_ASSUME_NONNULL_END
+NS_ASSUME_NONNULL_END

Firestore/core/src/index/firestore_index_value_writer.cc

@@ -19,6 +19,7 @@
 #include <cmath>
 #include <limits>
 #include <string>
+#include <vector>
 
 #include "Firestore/core/src/model/resource_path.h"
 #include "Firestore/core/src/model/value_util.h"