Fix lint errors.

Author: ehsannas

Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm

@@ -198,6 +198,10 @@ + (void)setUpDefaults {
   // SSL certs.
   NSString *project = [[NSProcessInfo processInfo] environment][@"PROJECT_ID"];
   NSString *targetBackend = [[NSProcessInfo processInfo] environment][@"TARGET_BACKEND"];
+  // Forcing use of nightly.Add commentMore actions
+  // TODO(types/ehsann): remove this before merging into main.
+  targetBackend = @"nightly";
+  project = @"firestore-sdk-nightly";
   NSString *host;
   if (targetBackend) {
     if ([targetBackend isEqualToString:@"emulator"]) {

Firestore/core/src/util/quadruple.cc

@@ -12,17 +12,23 @@
 //  See the License for the specific language governing permissions and
 //  limitations under the License.
 
-#include "quadruple.h"
-#include <ctype.h>
-#include <stdint.h>
+#include "Firestore/core/src/util/quadruple.h"
+
+#include <cctype>
 #include <cmath>
+#include <cstdint>
 #include <limits>
-#include "quadruple_builder.h"
+#include <vector>
+
+#include "Firestore/core/src/util/quadruple_builder.h"
 
 namespace firebase {
 namespace firestore {
 namespace util {
 
+using std::signbit;
+using std::fpclassify;
+
 namespace {
 constexpr int64_t kHashCodeOfNan = 7652541255;
 }
@@ -241,4 +247,4 @@ int64_t Quadruple::HashValue() const {
 
 }  // namespace util
 }  // namespace firestore
-}  // namespace firebase
+}  // namespace firebase

Firestore/core/src/util/quadruple.h

@@ -12,14 +12,14 @@
 //  See the License for the specific language governing permissions and
 //  limitations under the License.
 
-#include <stdint.h>
+#include <cstdint>
 #include <iomanip>
 #include <ios>
 #include <sstream>
 #include <string>
 
-#ifndef FIRESTORE_CORE_UTIL_QUADRUPLE_H_
-#define FIRESTORE_CORE_UTIL_QUADRUPLE_H_
+#ifndef FIRESTORE_CORE_SRC_UTIL_QUADRUPLE_H_
+#define FIRESTORE_CORE_SRC_UTIL_QUADRUPLE_H_
 
 namespace firebase {
 namespace firestore {
@@ -97,4 +97,4 @@ class Quadruple {
 }  // namespace firestore
 }  // namespace firebase
 
-#endif  // FIRESTORE_CORE_UTIL_QUADRUPLE_H_
+#endif  // FIRESTORE_CORE_SRC_UTIL_QUADRUPLE_H_

Firestore/core/src/util/quadruple_builder.cc

@@ -13,7 +13,7 @@
 //  See the License for the specific language governing permissions and
 //  limitations under the License.
 
-#include "quadruple_builder.h"
+#include "Firestore/core/src/util/quadruple_builder.h"
 
 #include <array>
 #include <cmath>
@@ -244,7 +244,6 @@ static std::array<std::array<uint64_t, 4>, 33> NEG_POWERS_OF_2 = {
      {{static_cast<uint64_t>(-9), 0x3b9aca0000000000LL, 0x0000000000000000LL,
        0x0000000000000001LL}},  // ***
                                 // 7: 2^-(2^6) =   2^-64
-                                // =   5.42101086242752217003726400434970855712890625E-20
                                 // =
                                 // 0.542101086242752217003726400434970855712890625e-19
      {{static_cast<uint64_t>(-19), 0x8ac7230489e80000LL, 0x0000000000000000LL,
@@ -660,8 +659,8 @@ void QuadrupleBuilder::multPacked3x64_simply(std::array<uint64_t, 4>& factor1,
   for (int32_t i = (0); i < (static_cast<int32_t>((result).size())); i++) {
     result[i] = 0LL;
   }
-  // TODO2 19.01.16 21:23:06 for the next version -- rebuild the table of powers
-  // to make the numbers unpacked, to avoid packing/unpacking
+  // TODO(dgay): 19.01.16 21:23:06 for the next version -- rebuild the table of
+  //  powers to make the numbers unpacked, to avoid packing/unpacking
   unpack_3x64_to_6x32(factor1, this->buffer6x32A);
   unpack_3x64_to_6x32(factor2, this->buffer6x32B);
   for (int32_t i = (6) - 1; i >= (0); i--) {  // compute partial 32-bit products

Firestore/core/src/util/quadruple_builder.h

@@ -16,11 +16,12 @@
 #ifndef FIRESTORE_CORE_SRC_UTIL_QUADRUPLE_BUILDER_H_
 #define FIRESTORE_CORE_SRC_UTIL_QUADRUPLE_BUILDER_H_
 
-#include <math.h>
-#include <array>
 #include <bit>
 #include <cstddef>
 #include <cstdint>
+
+#include <array>
+#include <cmath>
 #include <string>
 #include <vector>
 
@@ -95,4 +96,4 @@ class QuadrupleBuilder {
 }  // namespace firestore
 }  // namespace firebase
 
-#endif
+#endif  // FIRESTORE_CORE_SRC_UTIL_QUADRUPLE_BUILDER_H_