Skip to content

Commit e4c2368

Browse files
rlazodaymxn
andauthored
Use constants for library group task name (#5329)
Addressess pending comments from PR #5297 --------- Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
1 parent f00c02f commit e4c2368

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

buildSrc/src/main/java/com/google/firebase/gradle/plugins/PublishingPlugin.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import org.gradle.kotlin.dsl.register
6161
* - [PUBLISH_RELEASING_LIBS_TO_LOCAL_TASK][registerPublishReleasingLibrariesToMavenLocalTask]
6262
* - [SEMVER_CHECK_TASK][registerSemverCheckForReleaseTask]
6363
* - [PUBLISH_ALL_TO_BUILD_TASK][registerPublishAllToBuildDir]
64+
* - [LIBRARY_GROUPS_TASK][registerLibraryGroupsTask]
6465
*
6566
* Additionally, this plugin registers the [PostReleasePlugin] via [registerPostReleasePlugin] for
6667
* each releasing library.
@@ -105,7 +106,7 @@ abstract class PublishingPlugin : Plugin<Project> {
105106
registerSemverCheckForReleaseTask(project, releasingProjects)
106107
registerPublishAllToBuildDir(project, allFirebaseLibraries)
107108
registerPostReleasePlugin(releasingProjects)
108-
registerLibraryGroupsTaks(project, libraryGroups)
109+
registerLibraryGroupsTask(project, libraryGroups)
109110

110111
val buildMavenZip =
111112
project.tasks.register<Zip>(BUILD_MAVEN_ZIP_TASK) {
@@ -155,11 +156,11 @@ abstract class PublishingPlugin : Plugin<Project> {
155156
}
156157
}
157158

158-
protected fun registerLibraryGroupsTaks(
159+
private fun registerLibraryGroupsTask(
159160
project: Project,
160161
libraryGroups: Map<String, List<FirebaseLibraryExtension>>
161162
) {
162-
project.tasks.register("libraryGroups") {
163+
project.tasks.register(LIBRARY_GROUPS_TASK) {
163164
for (libraryGroup in libraryGroups) {
164165
println(
165166
"${libraryGroup.key} -> ${libraryGroup.value.joinToString(" | ") { it.artifactName }}"
@@ -539,6 +540,7 @@ abstract class PublishingPlugin : Plugin<Project> {
539540
const val SEMVER_CHECK_TASK = "semverCheckForRelease"
540541
const val RELEASE_GENEATOR_TASK = "generateReleaseConfig"
541542
const val VALIDATE_POM_TASK = "validatePomForRelease"
543+
const val LIBRARY_GROUPS_TASK = "libraryGroups"
542544
const val PUBLISH_RELEASING_LIBS_TO_BUILD_TASK = "publishReleasingLibrariesToBuildDir"
543545
const val PUBLISH_RELEASING_LIBS_TO_LOCAL_TASK = "publishReleasingLibrariesToMavenLocal"
544546
const val GENERATE_KOTLINDOC_FOR_RELEASE_TASK = "generateKotlindocForRelease"

0 commit comments

Comments
 (0)