Skip to content

Commit 6a03d4c

Browse files
authored
Update benchmark app (#6527)
The old version stop working due to a combination of gradle version and outdated deps
1 parent 1f9e582 commit 6a03d4c

File tree

6 files changed

+15
-13
lines changed

6 files changed

+15
-13
lines changed

ci/fireci/fireciplugins/macrobenchmark/run/test_project_builder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def _copy_template_project(self):
6060
self.logger.debug(f'Copied project template files into "{self.project_dir}"')
6161

6262
def _download_gradle_wrapper(self):
63-
args = ['wrapper', '--gradle-version', '7.5.1', '--project-dir', str(self.project_dir)]
63+
args = ['wrapper', '--gradle-version', '8.4', '--project-dir', str(self.project_dir)]
6464
execute('./gradlew', *args, logger=self.logger)
6565
self.logger.debug(f'Created gradle wrapper in "{self.project_dir}"')
6666

health-metrics/benchmark/template/app/build.gradle.mustache

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ plugins {
2323
android {
2424
compileSdkVersion 32
2525
26+
namespace "com.google.firebase.benchmark"
27+
2628
defaultConfig {
2729
applicationId 'com.google.firebase.benchmark'
2830
minSdkVersion 29
@@ -70,7 +72,7 @@ dependencies {
7072
implementation 'androidx.appcompat:appcompat:1.5.0'
7173
implementation 'com.google.android.material:material:1.6.1'
7274
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
73-
testImplementation libs.junit
75+
testImplementation 'junit:junit:4.13.2'
7476
androidTestImplementation "androidx.test.ext:junit:1.1.5"
7577
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
7678
}

health-metrics/benchmark/template/app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3-
xmlns:tools="http://schemas.android.com/tools"
4-
package="com.google.firebase.benchmark">
3+
xmlns:tools="http://schemas.android.com/tools">
54

65
<application
76
android:allowBackup="true"

health-metrics/benchmark/template/build.gradle

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313
// limitations under the License.
1414

1515
plugins {
16-
id 'com.android.application' version '7.2.2' apply false
17-
id 'com.android.library' version '7.2.2' apply false
16+
id 'com.android.application' version '8.2.1' apply false
17+
id 'com.android.library' version '8.2.1' apply false
1818
id 'com.android.test' version '7.2.2' apply false
1919
id 'org.jetbrains.kotlin.android' version '1.8.22' apply false
2020

21-
id 'com.google.gms.google-services' version '4.3.15' apply false
22-
id 'com.google.firebase.crashlytics' version '2.9.1' apply false
23-
id 'com.google.firebase.firebase-perf' version '1.4.1' apply false
21+
id 'com.google.gms.google-services' version '4.4.2' apply false
22+
id 'com.google.firebase.crashlytics' version '3.0.2' apply false
23+
id 'com.google.firebase.firebase-perf' version '1.4.2' apply false
2424
}
2525

2626
task clean(type: Delete) {

health-metrics/benchmark/template/macrobenchmark/build.gradle

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ plugins {
1818
}
1919

2020
android {
21-
compileSdkVersion 32
21+
compileSdkVersion 34
22+
23+
namespace "com.google.firebase.macrobenchmark"
2224

2325
compileOptions {
2426
sourceCompatibility JavaVersion.VERSION_1_8
@@ -51,7 +53,7 @@ android {
5153
dependencies {
5254
implementation 'androidx.benchmark:benchmark-macro-junit4:1.1.0'
5355
implementation 'androidx.test.espresso:espresso-core:3.4.0'
54-
implementation libs.androidx.test.junit
56+
implementation 'androidx.test.ext:junit:1.1.5'
5557
implementation 'androidx.test.uiautomator:uiautomator:2.2.0'
5658
}
5759

health-metrics/benchmark/template/macrobenchmark/src/main/AndroidManifest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3-
package="com.google.firebase.macrobenchmark">
2+
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
43

54
<queries>
65
<package android:name="com.google.firebase.benchmark" />

0 commit comments

Comments
 (0)