Skip to content

Commit 4273a23

Browse files
davidmotsonDavid Motsonashvili
andauthored
swap out the datatransport backend for ml modeldownloader (#5365)
Co-authored-by: David Motsonashvili <davidmotson@google.com>
1 parent 15c3197 commit 4273a23

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

firebase-ml-modeldownloader/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
# Unreleased
2+
* [changed] Internal infrastructure improvements.
3+
24
* [changed] Added Kotlin extensions (KTX) APIs from `com.google.firebase:firebase-ml-modeldownloader-ktx`
35
to `com.google.firebase:firebase-ml-modeldownloader` under the `com.google.firebase.ml.modeldownloader` package.
46
For details, see the

firebase-ml-modeldownloader/firebase-ml-modeldownloader.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ dependencies {
9090
implementation 'com.google.firebase:firebase-encoders:17.0.0'
9191
implementation 'com.google.firebase:firebase-installations-interop:17.1.0'
9292
implementation 'javax.inject:javax.inject:1'
93-
implementation('com.google.firebase:firebase-datatransport:18.1.7'){
93+
implementation('com.google.firebase:firebase-datatransport:18.2.0'){
9494
exclude group: 'com.google.firebase', module: 'firebase-common'
9595
exclude group: 'com.google.firebase', module: 'firebase-components'
9696
}

firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/FirebaseModelDownloaderRegistrar.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.google.firebase.components.ComponentRegistrar;
2727
import com.google.firebase.components.Dependency;
2828
import com.google.firebase.components.Qualified;
29+
import com.google.firebase.datatransport.TransportBackend;
2930
import com.google.firebase.installations.FirebaseInstallationsApi;
3031
import com.google.firebase.platforminfo.LibraryVersionComponent;
3132
import java.util.Arrays;
@@ -47,13 +48,15 @@ public class FirebaseModelDownloaderRegistrar implements ComponentRegistrar {
4748
public List<Component<?>> getComponents() {
4849
Qualified<Executor> bgExecutor = Qualified.qualified(Background.class, Executor.class);
4950
Qualified<Executor> blockingExecutor = Qualified.qualified(Blocking.class, Executor.class);
51+
Qualified<TransportFactory> transportFactory =
52+
Qualified.qualified(TransportBackend.class, TransportFactory.class);
5053
return Arrays.asList(
5154
Component.builder(FirebaseModelDownloader.class)
5255
.name(LIBRARY_NAME)
5356
.add(Dependency.required(Context.class))
5457
.add(Dependency.required(FirebaseApp.class))
5558
.add(Dependency.requiredProvider(FirebaseInstallationsApi.class))
56-
.add(Dependency.requiredProvider(TransportFactory.class))
59+
.add(Dependency.requiredProvider(transportFactory))
5760
.add(Dependency.required(bgExecutor))
5861
.add(Dependency.required(blockingExecutor))
5962
.factory(
@@ -64,7 +67,7 @@ public List<Component<?>> getComponents() {
6467
.setFis(c.getProvider(FirebaseInstallationsApi.class))
6568
.setBlockingExecutor(c.get(blockingExecutor))
6669
.setBgExecutor(c.get(bgExecutor))
67-
.setTransportFactory(c.getProvider(TransportFactory.class))
70+
.setTransportFactory(c.getProvider(transportFactory))
6871
.build()
6972
.getModelDownloader())
7073
.build(),

0 commit comments

Comments
 (0)