1414
1515package com .google .firebase .crashlytics .internal .persistence ;
1616
17- import android .annotation .SuppressLint ;
18- import android .app .Application ;
1917import android .content .Context ;
20- import android .os .Build .VERSION ;
21- import android .os .Build .VERSION_CODES ;
2218import androidx .annotation .Nullable ;
2319import androidx .annotation .VisibleForTesting ;
2420import com .google .firebase .crashlytics .internal .Logger ;
21+ import com .google .firebase .crashlytics .internal .ProcessDetailsProvider ;
22+ import com .google .firebase .crashlytics .internal .common .CommonUtils ;
2523import java .io .File ;
2624import java .io .FilenameFilter ;
2725import java .util .Arrays ;
5250 * convention, any use of new File(...) or similar outside of this class is a code smell.
5351 */
5452public class FileStore {
53+
54+ /** Deprecated old file system for systems that are not process aware. */
5555 private static final String CRASHLYTICS_PATH_V1 = ".com.google.firebase.crashlytics.files.v1" ;
56+
57+ /** Deprecated old file system, process aware. Use v3, there is no use for this system anymore. */
5658 private static final String CRASHLYTICS_PATH_V2 = ".com.google.firebase.crashlytics.files.v2" ;
59+
60+ /** Current file system, avoids long file names. */
61+ private static final String CRASHLYTICS_PATH_V3 = ".crashlytics.v3" ;
62+
5763 private static final String SESSIONS_PATH = "open-sessions" ;
5864 private static final String NATIVE_SESSION_SUBDIR = "native" ;
5965 private static final String REPORTS_PATH = "reports" ;
6066 private static final String PRIORITY_REPORTS_PATH = "priority-reports" ;
6167 private static final String NATIVE_REPORTS_PATH = "native-reports" ;
6268
69+ final String processName ;
6370 private final File filesDir ;
6471 private final File crashlyticsDir ;
6572 private final File sessionsDir ;
@@ -68,10 +75,12 @@ public class FileStore {
6875 private final File nativeReportsDir ;
6976
7077 public FileStore (Context context ) {
78+ processName =
79+ ProcessDetailsProvider .INSTANCE .getCurrentProcessDetails (context ).getProcessName ();
7180 filesDir = context .getFilesDir ();
7281 String crashlyticsPath =
73- useV2FileSystem ()
74- ? CRASHLYTICS_PATH_V2 + File .pathSeparator + sanitizeName (Application . getProcessName () )
82+ useV3FileSystem ()
83+ ? CRASHLYTICS_PATH_V3 + File .separator + sanitizeName (processName )
7584 : CRASHLYTICS_PATH_V1 ;
7685 crashlyticsDir = prepareBaseDir (new File (filesDir , crashlyticsPath ));
7786 sessionsDir = prepareBaseDir (new File (crashlyticsDir , SESSIONS_PATH ));
@@ -88,21 +97,35 @@ public void deleteAllCrashlyticsFiles() {
8897 /** Clean up files from previous file systems. */
8998 public void cleanupPreviousFileSystems () {
9099 // Clean up pre-versioned file systems.
91- cleanupDir (new File (filesDir , ".com.google.firebase.crashlytics" ));
92- cleanupDir (new File (filesDir , ".com.google.firebase.crashlytics-ndk" ));
93-
94- // Clean up v1 file system.
95- if (useV2FileSystem ()) {
96- cleanupDir (new File (filesDir , CRASHLYTICS_PATH_V1 ));
100+ cleanupFileSystemDir (".com.google.firebase.crashlytics" );
101+ cleanupFileSystemDir (".com.google.firebase.crashlytics-ndk" );
102+
103+ // Clean up old versioned file systems.
104+ if (useV3FileSystem ()) {
105+ cleanupFileSystemDir (CRASHLYTICS_PATH_V1 );
106+ // The v2 file system named dirs like ".com....v2:process_name"
107+ cleanupFileSystemDirs (CRASHLYTICS_PATH_V2 + File .pathSeparator );
97108 }
98109 }
99110
100- private void cleanupDir (File dir ) {
111+ private void cleanupFileSystemDir (String child ) {
112+ File dir = new File (filesDir , child );
101113 if (dir .exists () && recursiveDelete (dir )) {
102114 Logger .getLogger ().d ("Deleted previous Crashlytics file system: " + dir .getPath ());
103115 }
104116 }
105117
118+ private void cleanupFileSystemDirs (String prefix ) {
119+ if (filesDir .exists ()) {
120+ String [] list = filesDir .list ((dir , name ) -> name .startsWith (prefix ));
121+ if (list != null ) {
122+ for (String child : list ) {
123+ cleanupFileSystemDir (child );
124+ }
125+ }
126+ }
127+ }
128+
106129 static boolean recursiveDelete (File fileOrDirectory ) {
107130 File [] files = fileOrDirectory .listFiles ();
108131 if (files != null ) {
@@ -113,12 +136,16 @@ static boolean recursiveDelete(File fileOrDirectory) {
113136 return fileOrDirectory .delete ();
114137 }
115138
116- /** @return internal File used by Crashlytics, that is not specific to a session */
139+ /**
140+ * @return internal File used by Crashlytics, that is not specific to a session
141+ */
117142 public File getCommonFile (String filename ) {
118143 return new File (crashlyticsDir , filename );
119144 }
120145
121- /** @return all common (non session specific) files matching the given filter. */
146+ /**
147+ * @return all common (non session specific) files matching the given filter.
148+ */
122149 public List <File > getCommonFiles (FilenameFilter filter ) {
123150 return safeArrayToList (crashlyticsDir .listFiles (filter ));
124151 }
@@ -206,14 +233,21 @@ private static <T> List<T> safeArrayToList(@Nullable T[] array) {
206233 return (array == null ) ? Collections .emptyList () : Arrays .asList (array );
207234 }
208235
209- @ SuppressLint ( "AnnotateVersionCheck" )
210- private static boolean useV2FileSystem () {
211- return VERSION . SDK_INT >= VERSION_CODES . P ;
236+ private boolean useV3FileSystem () {
237+ // If the process name is known, use the v3 file system.
238+ return ! processName . isEmpty () ;
212239 }
213240
214- /** Replace potentially unsafe chars with underscores to make a safe file name. */
241+ /**
242+ * Replace potentially unsafe chars with underscores to make a safe file name.
243+ *
244+ * <p>If the filename is too long, hash it to a short name.
245+ */
215246 @ VisibleForTesting
216247 static String sanitizeName (String filename ) {
248+ if (filename .length () > 40 ) {
249+ return CommonUtils .sha1 (filename );
250+ }
217251 return filename .replaceAll ("[^a-zA-Z0-9.]" , "_" );
218252 }
219253}
0 commit comments