Update latestReleasedVersion on version bump (#5462)

daymxn · web-flow · commit 1ec75d4a2b0e · 2023-10-23T12:31:00.000-05:00
Per [b/306709509](https://b.corp.google.com/issues/306709509), This fixes an oversight in which we were not updating the `latestReleasedVersion` during our version bumps. Additionally, this fixes the following: - [b/306713770](https://b.corp.google.com/issues/306713770) -> Update the `latestReleasedVersion` for libraries where it's invalid - [b/300682493](https://b.corp.google.com/issues/300682493) -> Add condition to `moveUnreleasedChanges` task for changelog file existence
diff --git a/appcheck/firebase-appcheck-debug-testing/gradle.properties b/appcheck/firebase-appcheck-debug-testing/gradle.properties
@@ -1,2 +1,2 @@
 version=17.1.1
-latestReleasedVersion=17.0.1
+latestReleasedVersion=17.1.0
diff --git a/appcheck/firebase-appcheck-debug/gradle.properties b/appcheck/firebase-appcheck-debug/gradle.properties
@@ -1,2 +1,2 @@
 version=17.1.1
-latestReleasedVersion=17.0.1
+latestReleasedVersion=17.1.0
diff --git a/appcheck/firebase-appcheck-interop/gradle.properties b/appcheck/firebase-appcheck-interop/gradle.properties
@@ -1,2 +1,2 @@
 version=17.1.1
-latestReleasedVersion=17.0.1
+latestReleasedVersion=17.1.0
diff --git a/appcheck/firebase-appcheck-playintegrity/gradle.properties b/appcheck/firebase-appcheck-playintegrity/gradle.properties
@@ -1,2 +1,2 @@
 version=17.1.1
-latestReleasedVersion=17.0.1
+latestReleasedVersion=17.1.0
diff --git a/appcheck/firebase-appcheck/gradle.properties b/appcheck/firebase-appcheck/gradle.properties
@@ -1,2 +1,2 @@
 version=17.1.1
-latestReleasedVersion=17.0.1
+latestReleasedVersion=17.1.0
diff --git a/buildSrc/src/main/java/com/google/firebase/gradle/plugins/PostReleasePlugin.kt b/buildSrc/src/main/java/com/google/firebase/gradle/plugins/PostReleasePlugin.kt
@@ -52,6 +52,10 @@ class PostReleasePlugin : Plugin<Project> {
    * is set to the current version of said module. After a release, this `version` should be bumped
    * up to differentiate between code at HEAD, and the latest released version.
    *
+   * Furthermore, this file may optionally contain a `latestReleasedVersion` variable (if the SDK
+   * has released). If this property is present, it should be updated to the related version that
+   * went out during the release.
+   *
    * @see VersionBumpTask
    *
    * @param project the [Project] to register this task to
@@ -72,7 +76,9 @@ class PostReleasePlugin : Plugin<Project> {
    * @param project the [Project] to register this task to
    */
   fun registerMoveUnreleasedChangesTask(project: Project) =
-    project.tasks.register<MoveUnreleasedChangesTask>("moveUnreleasedChanges")
+    project.tasks.register<MoveUnreleasedChangesTask>("moveUnreleasedChanges") {
+      onlyIf("CHANGELOG.md file must be present") { project.file("CHANGELOG.md").exists() }
+    }
 
   /**
    * Registers the `updatePinnedDependencies` for the provided [Project]
diff --git a/buildSrc/src/main/java/com/google/firebase/gradle/plugins/VersionBumpTask.kt b/buildSrc/src/main/java/com/google/firebase/gradle/plugins/VersionBumpTask.kt
@@ -24,22 +24,29 @@ import org.gradle.api.tasks.TaskAction
 import org.gradle.kotlin.dsl.provideDelegate
 
 /**
- * Bumps the `version` property of the specified [versionFile].
+ * Bumps the `version` property of the specified [versionFile], and sets the
+ * `latestReleasedVersion`.
  *
  * Primarily utilized as a post-release clean up task in which we bump the versions of released
- * modules to be one patch higher than their currently released counterparts.
+ * modules to be one patch higher than their currently released counterparts, and update their
+ * latest released version.
  *
  * @see PostReleasePlugin
  *
  * @property versionFile A [File] that contains the `version` property. Defaults to the
  * `gradle.properties` file at the project's root.
+ * @property releasedVersion A [ModuleVersion] of what to bump from. Defaults to the project
+ * version.
  * @property newVersion A [ModuleVersion] of what to set the version to. Defaults to one patch
- * higher than the existing version.
+ * higher than [releasedVersion]
  */
 abstract class VersionBumpTask : DefaultTask() {
   @get:[Optional InputFile]
   abstract val versionFile: Property<File>
 
+  @get:[Optional Input]
+  abstract val releasedVersion: Property<ModuleVersion>
+
   @get:[Optional Input]
   abstract val newVersion: Property<ModuleVersion>
 
@@ -50,18 +57,23 @@ abstract class VersionBumpTask : DefaultTask() {
   @TaskAction
   fun build() {
     versionFile.get().rewriteLines {
-      if (it.startsWith("version=")) "version=${newVersion.get()}" else it
+      when {
+        it.startsWith("version=") -> "version=${newVersion.get()}"
+        it.startsWith("latestReleasedVersion") -> "latestReleasedVersion=${releasedVersion.get()}"
+        else -> it
+      }
     }
   }
 
   fun configure() {
     versionFile.convention(project.file("gradle.properties"))
-    newVersion.convention(computeNewVersion())
+    releasedVersion.convention(computeReleasedVersion())
+    newVersion.convention(releasedVersion.map { it.bump() })
   }
 
-  fun computeNewVersion(): ModuleVersion? {
+  fun computeReleasedVersion(): ModuleVersion? {
     val version: String? by project
 
-    return version?.let { ModuleVersion.fromStringOrNull(it)?.bump() }
+    return version?.let { ModuleVersion.fromStringOrNull(it) }
   }
 }
diff --git a/firebase-config/gradle.properties b/firebase-config/gradle.properties
@@ -15,6 +15,6 @@
 #
 
 version=21.5.1
-latestReleasedVersion=21.4.1
+latestReleasedVersion=21.5.0
 android.enableUnitTestBinaryResources=true
 
diff --git a/firebase-crashlytics-ndk/gradle.properties b/firebase-crashlytics-ndk/gradle.properties
@@ -1,2 +1,2 @@
 version=18.5.1
-latestReleasedVersion=18.4.3
+latestReleasedVersion=18.5.0
diff --git a/firebase-crashlytics/gradle.properties b/firebase-crashlytics/gradle.properties
@@ -1,2 +1,2 @@
 version=18.5.1
-latestReleasedVersion=18.4.3
+latestReleasedVersion=18.5.0
diff --git a/firebase-database/gradle.properties b/firebase-database/gradle.properties
@@ -13,5 +13,5 @@
 # limitations under the License.
 
 version=20.3.1
-latestReleasedVersion=20.2.2
+latestReleasedVersion=20.3.0
 android.enableUnitTestBinaryResources=true
diff --git a/firebase-dynamic-links/gradle.properties b/firebase-dynamic-links/gradle.properties
@@ -13,5 +13,5 @@
 # limitations under the License.
 
 version=21.2.1
-latestReleasedVersion=21.1.0
+latestReleasedVersion=21.2.0
 android.enableUnitTestBinaryResources=true
diff --git a/firebase-firestore/gradle.properties b/firebase-firestore/gradle.properties
@@ -1,2 +1,2 @@
 version=24.9.1
-latestReleasedVersion=24.8.1
+latestReleasedVersion=24.9.0
diff --git a/firebase-functions/gradle.properties b/firebase-functions/gradle.properties
@@ -1,3 +1,3 @@
 version=20.4.1
-latestReleasedVersion=20.3.1
+latestReleasedVersion=20.4.0
 android.enableUnitTestBinaryResources=true
diff --git a/firebase-inappmessaging-display/gradle.properties b/firebase-inappmessaging-display/gradle.properties
@@ -1,2 +1,2 @@
 version=20.4.1
-latestReleasedVersion=20.3.5
+latestReleasedVersion=20.4.0
diff --git a/firebase-inappmessaging/gradle.properties b/firebase-inappmessaging/gradle.properties
@@ -1,2 +1,2 @@
 version=20.4.1
-latestReleasedVersion=20.3.5
+latestReleasedVersion=20.4.0
diff --git a/firebase-installations/gradle.properties b/firebase-installations/gradle.properties
@@ -1,2 +1,2 @@
 version=17.2.1
-latestReleasedVersion=17.1.4
+latestReleasedVersion=17.2.0
diff --git a/firebase-messaging-directboot/gradle.properties b/firebase-messaging-directboot/gradle.properties
@@ -1,3 +1,3 @@
 version=23.3.1
-latestReleasedVersion=23.2.1
+latestReleasedVersion=23.3.0
 android.enableUnitTestBinaryResources=true
diff --git a/firebase-messaging/gradle.properties b/firebase-messaging/gradle.properties
@@ -1,3 +1,3 @@
 version=23.3.1
-latestReleasedVersion=23.2.1
+latestReleasedVersion=23.3.0
 android.enableUnitTestBinaryResources=true
diff --git a/firebase-ml-modeldownloader/gradle.properties b/firebase-ml-modeldownloader/gradle.properties
@@ -1,2 +1,2 @@
 version=24.2.1
-latestReleasedVersion=24.1.3
+latestReleasedVersion=24.2.0
diff --git a/firebase-perf/gradle.properties b/firebase-perf/gradle.properties
@@ -16,6 +16,6 @@
 #
 
 version=20.5.1
-latestReleasedVersion=20.4.1
+latestReleasedVersion=20.5.0
 android.enableUnitTestBinaryResources=true
 
diff --git a/firebase-sessions/gradle.properties b/firebase-sessions/gradle.properties
@@ -13,4 +13,4 @@
 # limitations under the License.
 
 version=1.1.1
-latestReleasedVersion=1.0.2
+latestReleasedVersion=1.1.0
diff --git a/firebase-storage/gradle.properties b/firebase-storage/gradle.properties
@@ -13,5 +13,5 @@
 # limitations under the License.
 
 version=20.3.1
-latestReleasedVersion=20.2.1
+latestReleasedVersion=20.3.0
 android.enableUnitTestBinaryResources=true

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`version=17.1.1`
`2`		`-latestReleasedVersion=17.0.1`
	`2`	`+latestReleasedVersion=17.1.0`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,6 @@`
`15`	`15`	`#`
`16`	`16`
`17`	`17`	`version=21.5.1`
`18`		`-latestReleasedVersion=21.4.1`
	`18`	`+latestReleasedVersion=21.5.0`
`19`	`19`	`android.enableUnitTestBinaryResources=true`
`20`	`20`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`version=18.5.1`
`2`		`-latestReleasedVersion=18.4.3`
	`2`	`+latestReleasedVersion=18.5.0`