From b67efc135fc1dea1aab2bef36a8c7e72c05fe7f0 Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Mon, 27 May 2024 16:25:04 -0400 Subject: [PATCH 1/4] change: Deprecate Node versions that reached EoL --- .github/workflows/ci.yml | 2 +- README.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e4fb651cc4..cf3a257871 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,7 @@ jobs: strategy: matrix: - node-version: [14.x, 16.x] + node-version: [14.x, 16.x, 18.x, 20.x, 22.x] steps: - uses: actions/checkout@v4 diff --git a/README.md b/README.md index 2d466926a7..f45c6a377b 100644 --- a/README.md +++ b/README.md @@ -59,8 +59,8 @@ requests, code review feedback, and also pull requests. ## Supported Environments -We support Node.js 14 and higher. However, Node.js 14 support is deprecated. We strongly encourage -you to use Node.js 16 or higher as we will drop support for Node.js 14 in the next major version. +We support Node.js 14 and higher. However, Node.js 14, 16, and 18 support is deprecated. We strongly encourage +you to use Node.js 20 or higher as we will drop support for Node.js 14, 16, and 18 in the next major version. Please also note that the Admin SDK should only be used in server-side/back-end environments controlled by the app developer. From d35b6909618aad7994f119b617c88da3364d5912 Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Tue, 28 May 2024 15:08:13 -0400 Subject: [PATCH 2/4] change expected error to regex --- test/unit/app/firebase-app.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/app/firebase-app.spec.ts b/test/unit/app/firebase-app.spec.ts index 31301b2b1f..2211f4f457 100644 --- a/test/unit/app/firebase-app.spec.ts +++ b/test/unit/app/firebase-app.spec.ts @@ -182,7 +182,7 @@ describe('FirebaseApp', () => { process.env[FIREBASE_CONFIG_VAR] = '{,,'; expect(() => { firebaseNamespace.initializeApp(); - }).to.throw('Failed to parse app options file: SyntaxError: Unexpected token ,'); + }).to.throw(/Failed to parse app options file: SyntaxError:/); }); it('should throw when the environment variable points to an empty file', () => { From 569193e5fdf0d32e0c13ef06d86ebaf2bce4af70 Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Tue, 28 May 2024 15:16:46 -0400 Subject: [PATCH 3/4] update readme.md --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index f45c6a377b..3c01d0731e 100644 --- a/README.md +++ b/README.md @@ -59,8 +59,8 @@ requests, code review feedback, and also pull requests. ## Supported Environments -We support Node.js 14 and higher. However, Node.js 14, 16, and 18 support is deprecated. We strongly encourage -you to use Node.js 20 or higher as we will drop support for Node.js 14, 16, and 18 in the next major version. +We support Node.js 14 and higher. However, Node.js 14, and 16 support is deprecated. We strongly encourage +you to use Node.js 18 or higher as we will drop support for Node.js 14 and 16 in the next major version. Please also note that the Admin SDK should only be used in server-side/back-end environments controlled by the app developer. From feb555aa4b277e25c74bca844cdca74e94c30816 Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Tue, 28 May 2024 15:19:03 -0400 Subject: [PATCH 4/4] update readme.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3c01d0731e..4eafa48814 100644 --- a/README.md +++ b/README.md @@ -59,7 +59,7 @@ requests, code review feedback, and also pull requests. ## Supported Environments -We support Node.js 14 and higher. However, Node.js 14, and 16 support is deprecated. We strongly encourage +We support Node.js 14 and higher. However, Node.js 14 and 16 support is deprecated. We strongly encourage you to use Node.js 18 or higher as we will drop support for Node.js 14 and 16 in the next major version. Please also note that the Admin SDK should only