Skip to content

Commit 7682836

Browse files
committed
improve tests and fix javadoc
1 parent f8796de commit 7682836

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/main/java/com/google/firebase/FirebaseOptions.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ public int getReadTimeout() {
214214
* Returns the write timeout in milliseconds, which is applied to outgoing REST calls
215215
* made by the SDK.
216216
*
217-
* @return Read timeout in milliseconds. 0 indicates an infinite timeout.
217+
* @return Write timeout in milliseconds. 0 indicates an infinite timeout.
218218
*/
219219
public int getWriteTimeout() {
220220
return writeTimeout;
@@ -511,11 +511,11 @@ public Builder setReadTimeout(int readTimeout) {
511511
}
512512

513513
/**
514-
* Sets the read timeout for outgoing HTTP (REST) calls made by the SDK. This does not affect
514+
* Sets the write timeout for outgoing HTTP (REST) calls made by the SDK. This does not affect
515515
* the {@link com.google.firebase.database.FirebaseDatabase} and
516516
* {@link com.google.firebase.cloud.FirestoreClient} APIs.
517517
*
518-
* @param writeTimeout Read timeout in milliseconds. Must not be negative.
518+
* @param writeTimeout Write timeout in milliseconds. Must not be negative.
519519
* @return This <code>Builder</code> instance is returned so subsequent calls can be chained.
520520
*/
521521
public Builder setWriteTimeout(int writeTimeout) {

src/test/java/com/google/firebase/FirebaseOptionsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public void createOptionsWithAllValuesSet() throws IOException {
8787
.setThreadManager(MOCK_THREAD_MANAGER)
8888
.setConnectTimeout(30000)
8989
.setReadTimeout(60000)
90-
.setWriteTimeout(60000)
90+
.setWriteTimeout(90000)
9191
.setFirestoreOptions(firestoreOptions)
9292
.build();
9393
assertEquals(FIREBASE_DB_URL, firebaseOptions.getDatabaseUrl());
@@ -98,7 +98,7 @@ public void createOptionsWithAllValuesSet() throws IOException {
9898
assertSame(MOCK_THREAD_MANAGER, firebaseOptions.getThreadManager());
9999
assertEquals(30000, firebaseOptions.getConnectTimeout());
100100
assertEquals(60000, firebaseOptions.getReadTimeout());
101-
assertEquals(60000, firebaseOptions.getWriteTimeout());
101+
assertEquals(90000, firebaseOptions.getWriteTimeout());
102102
assertSame(firestoreOptions, firebaseOptions.getFirestoreOptions());
103103

104104
GoogleCredentials credentials = firebaseOptions.getCredentials();

src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -979,7 +979,7 @@ public void testTimeout() throws Exception {
979979
.setHttpTransport(transport)
980980
.setConnectTimeout(30000)
981981
.setReadTimeout(60000)
982-
.setWriteTimeout(60000)
982+
.setWriteTimeout(90000)
983983
.build());
984984
FirebaseAuth auth = FirebaseAuth.getInstance();
985985
FirebaseUserManager userManager = auth.getUserManager();
@@ -990,7 +990,7 @@ public void testTimeout() throws Exception {
990990
HttpRequest request = interceptor.getResponse().getRequest();
991991
assertEquals(30000, request.getConnectTimeout());
992992
assertEquals(60000, request.getReadTimeout());
993-
assertEquals(60000, request.getWriteTimeout());
993+
assertEquals(90000, request.getWriteTimeout());
994994
}
995995

996996
@Test

src/test/java/com/google/firebase/internal/FirebaseRequestInitializerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class FirebaseRequestInitializerTest {
3838
private static final int MAX_RETRIES = 5;
3939
private static final int CONNECT_TIMEOUT_MILLIS = 30000;
4040
private static final int READ_TIMEOUT_MILLIS = 60000;
41-
private static final int WRITE_TIMEOUT_MILLIS = 60000;
41+
private static final int WRITE_TIMEOUT_MILLIS = 90000;
4242

4343
@After
4444
public void tearDown() {

0 commit comments

Comments
 (0)