Skip to content

Commit dd252a8

Browse files
authored
Fixing an auth test case that is dependent on ADC (#251)
* Fixing ADC related test * Removed temp test case
1 parent 8e14899 commit dd252a8

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

auth/auth_test.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,9 @@ func TestNewClientWithoutCredentials(t *testing.T) {
119119
}
120120
client, err := NewClient(context.Background(), conf)
121121
if err != nil {
122-
t.Errorf("NewClient() = (%v,%v); want = (nil, error)", client, err)
122+
t.Fatal(err)
123123
}
124+
124125
if _, ok := client.signer.(*iamSigner); !ok {
125126
t.Errorf("NewClient().signer = %#v; want = iamSigner", client.signer)
126127
}
@@ -147,8 +148,9 @@ func TestNewClientWithServiceAccountID(t *testing.T) {
147148
}
148149
client, err := NewClient(context.Background(), conf)
149150
if err != nil {
150-
t.Errorf("NewClient() = (%v,%v); want = (nil, error)", client, err)
151+
t.Fatal(err)
151152
}
153+
152154
if _, ok := client.signer.(*iamSigner); !ok {
153155
t.Errorf("NewClient().signer = %#v; want = iamSigner", client.signer)
154156
}
@@ -181,12 +183,14 @@ func TestNewClientWithUserCredentials(t *testing.T) {
181183
}
182184
conf := &internal.AuthConfig{
183185
Creds: creds,
186+
Opts: []option.ClientOption{option.WithCredentials(creds)},
184187
Version: "test-version",
185188
}
186189
client, err := NewClient(context.Background(), conf)
187190
if err != nil {
188-
t.Errorf("NewClient() = (%v,%v); want = (nil, error)", client, err)
191+
t.Fatal(err)
189192
}
193+
190194
if _, ok := client.signer.(*iamSigner); !ok {
191195
t.Errorf("NewClient().signer = %#v; want = iamSigner", client.signer)
192196
}

0 commit comments

Comments
 (0)