Skip to content

Commit 494dfce

Browse files
authored
Fixing an error formatting bug in FCM tests (#225)
* Fixing an error formatting bug in FCM tests * Further improved error message
1 parent b9e12c7 commit 494dfce

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

messaging/messaging_test.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1086,9 +1086,10 @@ func TestInvalidSubscribe(t *testing.T) {
10861086
}
10871087
for _, tc := range invalidTopicMgtArgs {
10881088
t.Run(tc.name, func(t *testing.T) {
1089-
name, err := client.SubscribeToTopic(ctx, tc.tokens, tc.topic)
1089+
resp, err := client.SubscribeToTopic(ctx, tc.tokens, tc.topic)
10901090
if err == nil || err.Error() != tc.want {
1091-
t.Errorf("SubscribeToTopic(%s) = (%q, %v); want = (%q, %q)", tc.name, name, err, "", tc.want)
1091+
t.Errorf(
1092+
"SubscribeToTopic(%s) = (%#v, %v); want = (nil, %q)", tc.name, resp, err, tc.want)
10921093
}
10931094
})
10941095
}
@@ -1128,9 +1129,10 @@ func TestInvalidUnsubscribe(t *testing.T) {
11281129
}
11291130
for _, tc := range invalidTopicMgtArgs {
11301131
t.Run(tc.name, func(t *testing.T) {
1131-
name, err := client.UnsubscribeFromTopic(ctx, tc.tokens, tc.topic)
1132+
resp, err := client.UnsubscribeFromTopic(ctx, tc.tokens, tc.topic)
11321133
if err == nil || err.Error() != tc.want {
1133-
t.Errorf("UnsubscribeFromTopic(%s) = (%q, %v); want = (%q, %q)", tc.name, name, err, "", tc.want)
1134+
t.Errorf(
1135+
"UnsubscribeFromTopic(%s) = (%#v, %v); want = (nil, %q)", tc.name, resp, err, tc.want)
11341136
}
11351137
})
11361138
}
@@ -1182,14 +1184,14 @@ func TestTopicManagementError(t *testing.T) {
11821184
resp = tc.resp
11831185
tmr, err := client.SubscribeToTopic(ctx, []string{"id1"}, "topic")
11841186
if err == nil || err.Error() != tc.want || !tc.check(err) {
1185-
t.Errorf("SubscribeToTopic() = (%q, %v); want = (%q, %q)", tmr, err, "", tc.want)
1187+
t.Errorf("SubscribeToTopic() = (%#v, %v); want = (nil, %q)", tmr, err, tc.want)
11861188
}
11871189
}
11881190
for _, tc := range cases {
11891191
resp = tc.resp
11901192
tmr, err := client.UnsubscribeFromTopic(ctx, []string{"id1"}, "topic")
11911193
if err == nil || err.Error() != tc.want {
1192-
t.Errorf("UnsubscribeFromTopic() = (%q, %v); want = (%q, %q)", tmr, err, "", tc.want)
1194+
t.Errorf("UnsubscribeFromTopic() = (%#v, %v); want = (nil, %q)", tmr, err, tc.want)
11931195
}
11941196
}
11951197
}

0 commit comments

Comments
 (0)