Skip to content

Commit ba5257a

Browse files
author
Ashley Gau
authored
Merge pull request #197 from joaqcid/fix-bq-import
fix(fs-bq-import-collection): update bigquery lib and insert api usage
2 parents a2bf4a9 + 81d9b4e commit ba5257a

File tree

4 files changed

+9
-15
lines changed

4 files changed

+9
-15
lines changed

firestore-bigquery-export/firestore-bigquery-change-tracker/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@
2222
"author": "Jan Wyszynski <wyszynski@google.com>",
2323
"license": "Apache-2.0",
2424
"dependencies": {
25-
"@google-cloud/bigquery": "^2.1.0",
25+
"@google-cloud/bigquery": "^4.7.0",
2626
"firebase-admin": "^7.1.1",
2727
"firebase-functions": "^2.2.1",
28-
"lodash": "^4.17.14",
29-
"sql-formatter": "^2.3.3",
3028
"generate-schema": "^2.6.0",
31-
"inquirer": "^6.4.0"
29+
"inquirer": "^6.4.0",
30+
"lodash": "^4.17.14",
31+
"sql-formatter": "^2.3.3"
3232
},
3333
"devDependencies": {
3434
"chai": "^4.2.0",

firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/index.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import {
2424
FirestoreDocumentChangeEvent,
2525
} from "../tracker";
2626
import * as logs from "../logs";
27-
import { BigQuery } from "@google-cloud/bigquery";
2827

2928
export interface FirestoreBigQueryEventHistoryTrackerConfig {
3029
datasetId: string;
@@ -51,9 +50,6 @@ export class FirestoreBigQueryEventHistoryTracker
5150

5251
async record(events: FirestoreDocumentChangeEvent[]) {
5352
await this.initialize();
54-
const options = {
55-
raw: true,
56-
};
5753
const rows = events.map((event) => {
5854
return {
5955
insertId: event.eventId,
@@ -66,23 +62,23 @@ export class FirestoreBigQueryEventHistoryTracker
6662
},
6763
};
6864
});
69-
await this.insertData(rows, options);
65+
await this.insertData(rows);
7066
}
7167

7268
/**
7369
* Inserts rows of data into the BigQuery raw change log table.
7470
*/
75-
private async insertData(rows: bigquery.RowMetadata[], options: object) {
76-
const payload = {
71+
private async insertData(rows: bigquery.RowMetadata[]) {
72+
const options = {
7773
skipInvalidRows: false,
7874
ignoreUnkownValues: false,
79-
rows: rows,
75+
raw: true,
8076
};
8177
try {
8278
const dataset = this.bq.dataset(this.config.datasetId);
8379
const table = dataset.table(this.rawChangeLogTableName());
8480
logs.dataInserting(rows.length);
85-
await table.insert(payload, options);
81+
await table.insert(rows, options);
8682
logs.dataInserted(rows.length);
8783
} catch (e) {
8884
// Reinitializing in case the destintation table is modified.

firestore-bigquery-export/scripts/import/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
"license": "Apache-2.0",
2626
"dependencies": {
2727
"@firebaseextensions/firestore-bigquery-change-tracker": "^1.0.1",
28-
"@google-cloud/bigquery": "^2.1.0",
2928
"firebase-admin": "^7.1.1",
3029
"firebase-functions": "^2.2.1",
3130
"generate-schema": "^2.6.0",

firestore-bigquery-export/scripts/import/src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
* limitations under the License.
1717
*/
1818

19-
import * as bigquery from "@google-cloud/bigquery";
2019
import * as firebase from "firebase-admin";
2120
import * as fs from "fs";
2221
import * as inquirer from "inquirer";

0 commit comments

Comments
 (0)