Merge branch 'next' into @ehesp/#310

Author: Salakar

auth-mailchimp-sync/POSTINSTALL.md

@@ -6,7 +6,7 @@ You can test out this extension right away:
 
 1.  Click **Add User** to add a test user.
 
-1.  In a few seconds, go to your Mailchimp audience page, you'll see the test user's email appear in the list.
+1.  In a few seconds, go to your Mailchimp audience page, you'll see the test user's email appear.
 
 ### Using the extension
 

auth-mailchimp-sync/functions/lib/logs.js

@@ -21,10 +21,10 @@ exports.complete = () => {
     console.log("Completed execution of extension");
 };
 exports.errorAddUser = (err) => {
-    console.error("Error when adding user to Mailchimp list", err);
+    console.error("Error when adding user to Mailchimp audience", err);
 };
 exports.errorRemoveUser = (err) => {
-    console.error("Error when removing user from Mailchimp list", err);
+    console.error("Error when removing user from Mailchimp audience", err);
 };
 exports.init = () => {
     console.log("Initializing extension with configuration", obfuscatedConfig);

auth-mailchimp-sync/functions/src/logs.ts

@@ -26,11 +26,11 @@ export const complete = () => {
 };
 
 export const errorAddUser = (err: Error) => {
-  console.error("Error when adding user to Mailchimp list", err);
+  console.error("Error when adding user to Mailchimp audience", err);
 };
 
 export const errorRemoveUser = (err: Error) => {
-  console.error("Error when removing user from Mailchimp list", err);
+  console.error("Error when removing user from Mailchimp audience", err);
 };
 
 export const init = () => {

delete-user-data/functions/lib/index.js

@@ -109,9 +109,6 @@ const clearStorageData = (storagePaths, uid) => __awaiter(this, void 0, void 0,
     logs.storageDeleted();
 });
 const clearFirestoreData = (firestorePaths, uid) => __awaiter(this, void 0, void 0, function* () {
-    // admin.firestore().settings({
-    //   timestampsInSnapshots: true,
-    // });
     logs.firestoreDeleting();
     const paths = extractUserPaths(firestorePaths, uid);
     const promises = paths.map((path) => __awaiter(this, void 0, void 0, function* () {

delete-user-data/functions/src/index.ts

@@ -112,9 +112,6 @@ const clearStorageData = async (storagePaths: string, uid: string) => {
 };
 
 const clearFirestoreData = async (firestorePaths: string, uid: string) => {
-  // admin.firestore().settings({
-  //   timestampsInSnapshots: true,
-  // });
   logs.firestoreDeleting();
 
   const paths = extractUserPaths(firestorePaths, uid);

firestore-bigquery-export/firestore-bigquery-change-tracker/package.json

@@ -5,7 +5,7 @@
     "url": "github.com/firebase/extensions.git",
     "directory": "firestore-bigquery-export/firestore-bigquery-change-tracker"
   },
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Core change-tracker library for Cloud Firestore Collection BigQuery Exports",
   "main": "./lib/index.js",
   "scripts": {

firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/index.ts

@@ -87,13 +87,13 @@ export class FirestoreBigQueryEventHistoryTracker implements FirestoreEventHisto
   buildDataRow(
     eventId: string,
     changeType: ChangeType,
-    timestamp: Date,
+    timestamp: string,
     document_name: string,
     data?: Object
   ): bigquery.RowMetadata {
     // This must match firestoreToBQTable().
     return {
-      timestamp: timestamp.toISOString(),
+      timestamp: timestamp,
       event_id: eventId,
       document_name: document_name,
       operation: ChangeType[changeType],

firestore-bigquery-export/firestore-bigquery-change-tracker/src/tracker.ts

@@ -25,7 +25,10 @@ export enum ChangeType {
 }
 
 export interface FirestoreDocumentChangeEvent {
-  timestamp: Date;
+  // The timestamp represented in ISO format.
+  // Date is not appropriate because it only has millisecond precision.
+  // Cloud Firestore timestamps have microsecond precision.
+  timestamp: string;
   operation: ChangeType;
   documentName: string;
   eventId: string;

firestore-bigquery-export/functions/lib/index.js

@@ -36,7 +36,7 @@ exports.fsexportbigquery = functions.handler.firestore.document.onWrite((change,
     try {
         const changeType = util_1.getChangeType(change);
         yield eventTracker.record([{
-                timestamp: util_1.getTimestamp(context, change),
+                timestamp: context.timestamp,
                 operation: changeType,
                 documentName: context.resource.name,
                 eventId: context.eventId,

firestore-bigquery-export/functions/lib/logs.js

@@ -90,7 +90,7 @@ exports.bigQueryViewValidating = (viewName) => {
     console.log(`Validating existing BigQuery view: ${viewName}`);
 };
 exports.complete = () => {
-    console.log("Completed mod execution");
+    console.log("Completed execution of extension");
 };
 exports.dataInserted = (rowCount) => {
     console.log(`Inserted ${rowCount} row(s) of data into BigQuery`);
@@ -105,10 +105,10 @@ exports.error = (err) => {
     console.error("Error when mirroring data to BigQuery", err);
 };
 exports.init = () => {
-    console.log("Initializing mod with configuration", config_1.default);
+    console.log("Initializing extension with configuration", config_1.default);
 };
 exports.start = () => {
-    console.log("Started mod execution with configuration", config_1.default);
+    console.log("Started execution of extension with configuration", config_1.default);
 };
 exports.timestampMissingValue = (fieldName) => {
     console.warn(`Missing value for timestamp field: ${fieldName}, using default timestamp instead.`);