FS-7797 changed http method used when uploading external urls

Author: bkwi

filestack/uploads/external_url.py

@@ -31,5 +31,6 @@ def upload_external_url(url, apikey, store_params=None, security=None):
     if security is not None:
         url_elements.insert(3, security.as_url_string())
 
-    response = requests.post('/'.join(url_elements))
+    # TODO: use processing endpoint and "store" task for uploading external urls
+    response = requests.get('/'.join(url_elements))
     return response.json()['handle']

tests/client_test.py

@@ -29,7 +29,7 @@ def test_wrong_storage():
 
 
 def test_store_external_url(client):
-    @urlmatch(netloc=r'cdn.filestackcontent\.com', method='post', scheme='https')
+    @urlmatch(netloc=r'cdn.filestackcontent\.com', method='get', scheme='https')
     def api_store(url, request):
         return response(200, {'handle': HANDLE})
 

tests/uploads/test_upload_external_url.py

@@ -13,7 +13,7 @@
 apikey = 'TESTAPIKEY'
 
 
-@patch('filestack.uploads.external_url.requests.post')
+@patch('filestack.uploads.external_url.requests.get')
 def test_upload(post_mock):
     post_mock.return_value = DummyHttpResponse(json_dict={'handle': 'newHandle'})
 
@@ -31,7 +31,7 @@ def test_upload(post_mock):
         'store=container:bucket-name,workflows:["uuid-1","uuid-2"]'
     ],
 ])
-@patch('filestack.uploads.external_url.requests.post')
+@patch('filestack.uploads.external_url.requests.get')
 def test_upload_with_store_params(post_mock, store_params, expected_store_task):
     post_mock.return_value = DummyHttpResponse(json_dict={'handle': 'newHandle'})
 
@@ -42,7 +42,7 @@ def test_upload_with_store_params(post_mock, store_params, expected_store_task):
     assert expected_store_task in req_url
 
 
-@patch('filestack.uploads.external_url.requests.post')
+@patch('filestack.uploads.external_url.requests.get')
 def test_upload_with_security(post_mock):
     post_mock.return_value = DummyHttpResponse(json_dict={'handle': 'newHandle'})
     security = Security({'expiry': 123123123123, 'call': ['write']}, 'SECRET')
@@ -54,7 +54,7 @@ def test_upload_with_security(post_mock):
     post_mock.assert_called_once_with(expected_url)
 
 
-@patch('filestack.uploads.external_url.requests.post')
+@patch('filestack.uploads.external_url.requests.get')
 def test_upload_exception(post_mock):
     error_message = 'Oops!'
     post_mock.side_effect = Exception(error_message)