Deprecate Exception in favour of custom exception class (#57)

Author: sidmitra

filestack/exceptions.py

@@ -0,0 +1,7 @@
+class FilestackHTTPError(Exception):
+    """
+    Custom HTTPError instead of requests.exceptions.HTTPError to add response body.
+
+    References:
+        - https://github.com/psf/requests/pull/4234
+    """

filestack/utils.py

@@ -3,8 +3,10 @@
 import random
 from functools import partial
 import requests as original_requests
+from requests.exceptions import HTTPError
 
 from filestack import config
+from filestack.exceptions import FilestackHTTPError
 
 
 def unique_id(length=10):
@@ -30,8 +32,10 @@ def handle_request(self, name, *args, **kwargs):
         requests_method = getattr(original_requests, name)
         response = requests_method(*args, **kwargs)
 
-        if not response.ok:
-            raise Exception(response.text)
+        try:
+            response.raise_for_status()
+        except HTTPError as e:
+            raise FilestackHTTPError(response.text) from e
 
         return response
 

tests/helpers.py

@@ -1,3 +1,4 @@
+from requests.exceptions import HTTPError
 
 
 class DummyHttpResponse:
@@ -11,3 +12,12 @@ def __init__(self, ok=True, status_code=200, json_dict=None, content=b'', header
 
     def json(self):
         return self.json_dict
+
+    def raise_for_status(self):
+        """
+        Return a dummy error if 'ok' was specified as False.
+
+        Note that in the original 'requests', response.ok calls raise_for_status() instead
+        """
+        if not self.ok:
+            raise HTTPError("HTTP request failed.")