Use Client's storage when uploading external urls (#62)

Author: bkwi

filestack/models/client.py

@@ -120,7 +120,7 @@ def upload_url(self, url, store_params=None, security=None):
             :class:`filestack.Filelink`: new Filelink object
         """
         sec = security or self.security
-        upload_response = upload_external_url(url, self.apikey, store_params, security=sec)
+        upload_response = upload_external_url(url, self.apikey, self.storage, store_params, security=sec)
         return filestack.models.Filelink(
             handle=upload_response['handle'],
             apikey=self.apikey,

filestack/uploads/external_url.py

@@ -2,8 +2,10 @@
 from filestack.utils import requests
 
 
-def upload_external_url(url, apikey, store_params=None, security=None):
+def upload_external_url(url, apikey, storage, store_params=None, security=None):
     store_params = store_params or {}
+    if storage and not store_params.get('location'):
+        store_params['location'] = storage
 
     # remove params that are currently not supported in external url upload
     for item in ('mimetype', 'upload_tags'):

tests/uploads/test_upload_external_url.py

@@ -10,22 +10,24 @@
 apikey = 'TESTAPIKEY'
 
 
-@pytest.mark.parametrize('store_params, security, expected_store_tasks', [
+@pytest.mark.parametrize('default_storage, store_params, security, expected_store_tasks', [
     (
-        {'location': 's3'},
+        'S3,',
+        {'location': 'gcs'},
         None,
         [
             {
-                'name': 'store', 'params': {'location': 's3'}
+                'name': 'store', 'params': {'location': 'gcs'}
             }
         ]
     ),
     (
+        'gcs',
         {'path': 'new-path/', 'mimetype': 'application/json'},
         type('SecurityMock', (), {'policy_b64': 'abc', 'signature': '123'}),
         [
             {
-                'name': 'store', 'params': {'path': 'new-path/'}
+                'name': 'store', 'params': {'path': 'new-path/', 'location': 'gcs'}
             },
             {
                 'name': 'security', 'params': {'policy': 'abc', 'signature': '123'}
@@ -34,15 +36,17 @@
     )
 ])
 @patch('filestack.uploads.external_url.requests.post')
-def test_upload_with_store_params(post_mock, store_params, security, expected_store_tasks):
+def test_upload_with_store_params(post_mock, default_storage, store_params, security, expected_store_tasks):
     expected_payload = {
         'apikey': 'TESTAPIKEY',
         'sources': ['http://image.url'],
         'tasks': expected_store_tasks
     }
     post_mock.return_value = DummyHttpResponse(json_dict={'handle': 'newHandle'})
 
-    upload_response = upload_external_url(url, apikey, store_params=store_params, security=security)
+    upload_response = upload_external_url(
+        url, apikey, default_storage, store_params=store_params, security=security
+    )
     assert upload_response['handle'] == 'newHandle'
     post_args, _ = post_mock.call_args
     post_mock.assert_called_once_with('{}/process'.format(config.CDN_URL), json=expected_payload)