Skip to content

Commit 1a6fbf8

Browse files
author
Bartek Kwiecien
committed
Added minify_js task
1 parent 4905970 commit 1a6fbf8

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

filestack/mixins/imagetransformation.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,10 @@ def pdf_info(self, colorinfo=None):
126126
def pdf_convert(self, pageorientation=None, pageformat=None, pages=None):
127127
return self._add_transform_task('pdfconvert', locals())
128128

129+
def minify_js(self, gzip=None, use_babel_polyfill=None, keep_fn_name=None, keep_class_name=None,
130+
mangle=None, merge_vars=None, remove_console=None, remove_undefined=None, targets=None):
131+
return self._add_transform_task('minify_js', locals())
132+
129133
def minify_css(self, level=None, gzip=None):
130134
return self._add_transform_task('minify_css', locals())
131135

filestack/utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ def return_transform_task(transformation, params):
4343
transform_tasks = []
4444

4545
for key, value in params.items():
46-
4746
if isinstance(value, list):
4847
value = str(value).replace("'", "").replace('"', '').replace(" ", "")
4948
if isinstance(value, bool):

tests/transformation_test.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,12 +263,18 @@ def test_minify_css(transform):
263263
target_url = '{}/{}/minify_css/{}'.format(config.CDN_URL, APIKEY, EXTERNAL_URL)
264264
result = transform.minify_css()
265265
assert result.url == target_url
266-
266+
267267

268268
def test_minify_css_with_params(transform):
269269
target_url = '{}/{}/minify_css=gzip:false,level:1/{}'.format(config.CDN_URL, APIKEY, EXTERNAL_URL)
270270
result = transform.minify_css(level=1, gzip=False)
271-
assert result.url == target_url
271+
assert result.url == target_url
272+
273+
274+
def test_minify_js(transform):
275+
target_url = '{}/{}/minify_js=gzip:false,targets:not dead,> 1%/{}'.format(config.CDN_URL, APIKEY, EXTERNAL_URL)
276+
result = transform.minify_js(gzip=False, targets='not dead,> 1%')
277+
assert result.url == target_url
272278

273279

274280
def quality(transform):

0 commit comments

Comments
 (0)