Skip to content

Conversation

@grafst
Copy link
Contributor

@grafst grafst commented Oct 9, 2025

Description

When I want to omit a field from tabbing in a filament form i can add
->extraInputAttributes(['tabindex' => '-1'])
so far so good.
However this doesn't work on a select with the ->searchable() option, because that is not composed in the select.blade.php but rather in a javascript utility.

Visual changes

tabindex

Functional changes

We propagate the extra input Attributes via the selectFormComponent into the select utility and set them on the input and also on the clear button.

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date, since this would be expected behaviour.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Oct 9, 2025
@danharrin danharrin added enhancement New feature or request pending review labels Oct 10, 2025
@danharrin danharrin added this to the v4 milestone Oct 10, 2025
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing on L11

Please ensure that classes are merged on the element, not replaced

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Roadmap Oct 11, 2025
@grafst
Copy link
Contributor Author

grafst commented Oct 15, 2025

We merged the id attribute into the div. the other attributes (autofocus, disabled) can't be merged because they are not attributes on the searchable select but rather are handled by the select.js utility.
Sorry if im missing or misunderstanding something.
please advise :)

@danharrin
Copy link
Member

That isn't what I meant, we don't need ->merge(['id'=>$id], escape: false))

If a class attribute is passed, it should merge with the other classes on the element that are already there instead of replacing them. The merging needs to be done in JS

@grafst
Copy link
Contributor Author

grafst commented Oct 28, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pending changes

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants