Skip to content

Commit 8c32f95

Browse files
[CI][Github] Remove MAX_PARALLEL_*_JOBS Args from Windows Runs (llvm#147770)
This patch removes setting the MAX_PARLLEL_COMPILE_JOBS and MAX_PARALLEL_LINK_JOBS env variables in the windows runs. These were originally used to control the parallelism on the old infrastructure and we set them on the new infrastructure explicitly so that we could maintain both at the same time. Now it does not make sense to keep them explicitly set that we do not need to explicitly control the parallelism given the amount of RAM we have on the machines. This also adds a maintnenace cost as evidenced by the fact that these have been incorrect (64 instead of 32) for quite a while.
1 parent 30a2b8b commit 8c32f95

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

.ci/monolithic-windows.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,7 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \
7474
-D MLIR_ENABLE_BINDINGS_PYTHON=ON \
7575
-D CMAKE_EXE_LINKER_FLAGS="/MANIFEST:NO" \
7676
-D CMAKE_MODULE_LINKER_FLAGS="/MANIFEST:NO" \
77-
-D CMAKE_SHARED_LINKER_FLAGS="/MANIFEST:NO" \
78-
-D LLVM_PARALLEL_COMPILE_JOBS=${MAX_PARALLEL_COMPILE_JOBS} \
79-
-D LLVM_PARALLEL_LINK_JOBS=${MAX_PARALLEL_LINK_JOBS}
77+
-D CMAKE_SHARED_LINKER_FLAGS="/MANIFEST:NO"
8078

8179
echo "::endgroup::"
8280
echo "::group::ninja"

.github/workflows/premerge.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,6 @@ jobs:
110110
if: ${{ steps.vars.outputs.windows-projects != '' }}
111111
shell: cmd
112112
run: |
113-
set MAX_PARALLEL_COMPILE_JOBS=64
114-
set MAX_PARALLEL_LINK_JOBS=64
115113
call C:\\BuildTools\\Common7\\Tools\\VsDevCmd.bat -arch=amd64 -host_arch=amd64
116114
bash .ci/monolithic-windows.sh "${{ steps.vars.outputs.windows-projects }}" "${{ steps.vars.outputs.windows-check-targets }}"
117115
- name: Upload Artifacts

0 commit comments

Comments
 (0)