Devcontainer for Fedify #142
moreal
started this conversation in
Show and tell
Replies: 1 comment 2 replies
-
Providing a dev container out of box would be a good idea! It would be really useful, especially for first-time contributors. Also, about management cost: I don't believe it's that expensive—go for it! |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
🙌🏻 Introduction
Hi, I tried to make devcontainer1 configuration and you can see here. It does:
deno
,bun
,node
,pnpm
.deno task codegen
2.vscode/extensions.json
3🤔 Why not pull request?
I think the devcontainer will be helpful to setup Fedify development environment for new contributors, and use as isolated development environment even for hard contributors. But I don't want to open this as PR, yet.
It is because I'm not sure about the below items:
I wonder the opinion of maintainers and other contributors.
Footnotes
https://containers.dev/ ↩
In details,
deno task -c src/deno.json codegen; deno task -c cli/deno.json
. I added these instructions because CONTRIBUTING.md says it; https://github.com/dahlia/fedify/blob/451def15df40bf08d3d38830d3f132b22994090d/CONTRIBUTING.md?plain=1#L66 ↩https://code.visualstudio.com/docs/devcontainers/containers#_adding-an-extension-to-devcontainerjson ↩
Beta Was this translation helpful? Give feedback.
All reactions