Remove typescript from peerDependencies of @feathers/schema

[SvenFackert]

Hi everyone,

I have noticed, that the @feathers/schema package.json lists typescript as a peerDependency (here). Although it is already listed in the devDependencies. Is there any reason to it?

I am asking, because since version 7 of npm, peerDependencies get automatically installed with npm I. When running e. g. npm i --omit=dev for production, the peerDependency typescript gets installed too, although it should probably only be installed on a dev setup.

What do you think? Could this be removed in future versions?

Kind regards
Sven

[daffl]

This was necessary to ensure a minimum TypeScript version because schema does not work with TypeScript 4 (which is causing very difficult to debug errors). I think the problem is that the version is updated when it probably shouldn't be.

[SvenFackert]

Thanks for the quick reply! I see. But wouldn't it be sufficient to list TypeScript in the devDependencies then? That would ensure that the correct version gets installed on a dev setup. If TypeScript is not necessary for runtime/production, I would not add it to peerDependencies, as these get automatically installed even when installing with npm i --omit=dev. Or am I missing something here?

[daffl]

devDependencies never get installed for dependent packages, only for your own project. I don't know another way to ensure a version of a development dependency other than adding it as a peer.

[SvenFackert]

Ah, I see. I think both solutions are not perfect yet:

1. adding it to peers as it currently is -> typescript gets installed into dependencies on prod, which means you need to completely turn off installation of peers, which might omit packages that are peerDependencies for production/runtime
2. not adding it to peers and only mention the version compatibility in README -> will probably not be read by users so the difficult to debug errors will appear again..

What about a post install script in the feathers/authentication package that installs a suitable typescript version for development only inside the node_modules of the authentication package?