paramsFromClient pollutes context by default

[FossPrime]

feathers-hooks-common/src/hooks/params-from-client.ts

Line 22 in 15ddaa6

delete params.query.$client;

While whitelisting is a good security feature, it is the adapter's job to complain about invalid query parameters, not ours.

It makes it difficult to compose hooks with this as it damages the context if used at app level/around/provider and also in services.

Proposal:

   const foreignParamCount = 0
    // in an Object.keys(ctx.params.query?.$client) loop, foreignParamCount++
	if (foreignParamCount === 0) {
      delete ctx.params.query.$client
    }

The alternative is to dump repetitive code like this in all over userland hooks:

delete ctx.params.query.$client.sudo
if (Object.keys(ctx.params.query.$client).length === 0) {
  delete ctx.params.query.$client
}

[fratzinger]

Just a quick headsup. I started working on a massive rewrite of the package (#764). It's not released yet and will take a few weeks.

This should be fine then, see https://github.com/feathersjs-ecosystem/feathers-hooks-common/blob/modernize/src/hooks/params-from-client2/params-from-client2.ts