Update client window when changing creative windows. (#479)

* Fix client not sending updates about removed items.

* Removes option from Server. And removed unit tests

* Revert "Datapack parsing (#455)"

This reverts commit 7e46ec7.

* removed unused variable.

Author: Tracreed

feather/server/src/packet_handlers.rs

@@ -50,7 +50,7 @@ pub fn handle_packet(
         ClientPlayPacket::PlayerDigging(packet) => handle_player_digging(game, packet, player_id),
 
         ClientPlayPacket::CreativeInventoryAction(packet) => {
-            inventory::handle_creative_inventory_action(player, packet)
+            inventory::handle_creative_inventory_action(player, packet, server)
         }
         ClientPlayPacket::ClickWindow(packet) => {
             inventory::handle_click_window(server, player, packet)

feather/server/src/packet_handlers/inventory.rs

@@ -9,6 +9,7 @@ use crate::{ClientId, Server};
 pub fn handle_creative_inventory_action(
     player: EntityRef,
     packet: CreativeInventoryAction,
+    server: &mut Server,
 ) -> SysResult {
     if *player.get::<Gamemode>()? != Gamemode::Creative {
         bail!("cannot use Creative Inventory Action outside of creative mode");
@@ -23,6 +24,12 @@ pub fn handle_creative_inventory_action(
         window
             .inner()
             .set_item(packet.slot as usize, packet.clicked_item)?;
+
+        // Sends the client updates about window changes.
+        // Is required to make delete inventory button reflect in-game.
+        let client_id = *player.get::<ClientId>()?;
+        let client = server.clients.get(client_id).unwrap();
+        client.send_window_items(&window);
     }
 
     Ok(())
@@ -75,88 +82,3 @@ fn _handle_click_window(player: &EntityRef, packet: &ClickWindow) -> SysResult {
 
     Ok(())
 }
-
-#[cfg(test)]
-mod tests {
-    use base::{Inventory, Item, ItemStack};
-    use common::Game;
-
-    use super::*;
-
-    #[test]
-    fn creative_inventory_action_survival_mode() {
-        let mut game = Game::new();
-        let entity = game.ecs.spawn((Gamemode::Survival, player_window()));
-        let player = game.ecs.entity(entity).unwrap();
-
-        let packet = CreativeInventoryAction {
-            slot: 10,
-            clicked_item: Some(ItemStack::new(Item::Diamond, 64)),
-        };
-        handle_creative_inventory_action(player, packet).unwrap_err();
-
-        assert!(game
-            .ecs
-            .get::<Window>(entity)
-            .unwrap()
-            .item(10)
-            .unwrap()
-            .is_none());
-    }
-
-    #[test]
-    fn creative_inventory_action_non_player_window() {
-        let mut game = Game::new();
-        let entity = game.ecs.spawn((
-            Window::new(BackingWindow::Generic9x3 {
-                player: Inventory::player(),
-                block: Inventory::chest(),
-            }),
-            Gamemode::Creative,
-        ));
-        let player = game.ecs.entity(entity).unwrap();
-
-        let packet = CreativeInventoryAction {
-            slot: 5,
-            clicked_item: Some(ItemStack::new(Item::Diamond, 64)),
-        };
-        handle_creative_inventory_action(player, packet).unwrap_err();
-
-        assert!(game
-            .ecs
-            .get::<Window>(entity)
-            .unwrap()
-            .item(5)
-            .unwrap()
-            .is_none());
-    }
-
-    #[test]
-    fn creative_inventory_action() {
-        let mut game = Game::new();
-        let entity = game.ecs.spawn((Gamemode::Creative, player_window()));
-        let player = game.ecs.entity(entity).unwrap();
-
-        let packet = CreativeInventoryAction {
-            slot: 5,
-            clicked_item: Some(ItemStack::new(Item::Diamond, 64)),
-        };
-        handle_creative_inventory_action(player, packet).unwrap();
-
-        assert_eq!(
-            game.ecs
-                .get::<Window>(entity)
-                .unwrap()
-                .item(5)
-                .unwrap()
-                .clone(),
-            Some(ItemStack::new(Item::Diamond, 64))
-        );
-    }
-
-    fn player_window() -> Window {
-        Window::new(BackingWindow::Player {
-            player: Inventory::player(),
-        })
-    }
-}