Refactor such that libcraft contains all generated files (almost). (#461)

* Refactoring ongoing

* Added libcraft-inventory

* cha-cha-cha-Changes

* Turn and face the stranger

* Ch-ch-Changes

* Don't want to be a richer one

* Ch-ch-ch-ch-Changes

* (Turn and face the stranger)

* hHAHAHA

* Changed stuff as a test

* Changed stuff.

* Something

* Fixed a problem

* Fixed most things. Some problems left.

* Finnished up.

* removed Filled from use.

* Ongoing refactor.

* Fixed so it compiles and runs fine.

* Fix missing offhand area in inventory.json.

* Clippy issues.

* Appease the clippy gods.

* cargo fmt

* Added clippy ignore to inventory generator.

* Just fixed the generator instead. No need to ignore clippy.

* Fix Some(slot + 0)

* Fixed `let slot = index - 0;`

* Removed unnecessary borrows.

* Added _ to unread struct field.

* Derived default where it was possible.

* Spelling error.

* `cargo fmt` wants new lines at the end of files.

* Fix merge issues.

* Removed commented out code.

* Format doc comment better.

* Remove default derive on HotbarSlot.

* Clarify why the `unreachable!()` is unreachable.

* Add trailing newline.

* Update feather/base/src/anvil/entity.rs

Co-authored-by: Amber <amberkowalski03@gmail.com>

* set_slot takes a reference instead.

* remove clone from handle_click_window.

* Made damage an i32 on ItemStackMeta

* Changed code to use filter_map.

Co-authored-by: Tracreed <davidalasow@gmail.com>
Co-authored-by: Amber <amberkowalski03@gmail.com>

Author: 3 people

Cargo.lock

@@ -8,6 +8,7 @@ members = [
     "libcraft/macros",
     "libcraft/particles",
     "libcraft/text",
+    "libcraft/inventory",
 
     # Quill
     "quill/sys-macros",
@@ -29,7 +30,6 @@ members = [
 
     # Feather (common and server)
     "feather/utils",
-    "feather/generated",
     "feather/blocks",
     "feather/blocks/generator",
     "feather/base",

Cargo.toml

@@ -12,13 +12,15 @@ bitflags = "1"
 bitvec = "0.21"
 blocks = { path = "../blocks", package = "feather-blocks" }
 byteorder = "1"
-generated = { path = "../generated", package = "feather-generated" }
 hematite-nbt = { git = "https://github.com/PistonDevelopers/hematite_nbt" }
+
 libcraft-blocks = { path = "../../libcraft/blocks" }
 libcraft-core = { path = "../../libcraft/core" }
 libcraft-items = { path = "../../libcraft/items" }
 libcraft-particles = { path = "../../libcraft/particles" }
-libcraft-text = { path = "../../libcraft/text" } 
+libcraft-text = { path = "../../libcraft/text" }
+libcraft-inventory = { path = "../../libcraft/inventory" } 
+
 nom = "5"
 nom_locate = "2"
 num-derive = "0.3"

feather/base/Cargo.toml

@@ -1,5 +1,5 @@
 use arrayvec::ArrayVec;
-use generated::{Item, ItemStack};
+use libcraft_items::{Item, ItemStack, ItemStackBuilder};
 use serde::ser::Error;
 use serde::{Deserialize, Serialize, Serializer};
 use thiserror::Error;
@@ -219,8 +219,8 @@ where
             Some(nbt)
         };
         Self {
-            count: stack.count as i8,
-            item: stack.item.name().to_owned(),
+            count: stack.count() as i8,
+            item: stack.item().name().to_owned(),
             nbt,
         }
     }
@@ -235,12 +235,22 @@ pub struct ItemNbt {
 }
 
 impl ItemNbt {
-    /// Create an `ItemStack` of the specified item and amount, setting any nbt present.
+    /// Create an `ItemStack` of the specified item and amount, setting any NBT present.
+    ///
+    /// # Panics
+    /// Panics if `count` is zero.
     pub fn item_stack(nbt: &Option<Self>, item: Item, count: u8) -> ItemStack {
-        ItemStack {
-            count: count as u32,
-            item,
-            damage: nbt.as_ref().map(|n| n.damage).flatten().map(|x| x as u32),
+        match nbt {
+            Some(ItemNbt {
+                damage: Some(damage),
+            }) => ItemStackBuilder::with_item(item)
+                .count(count as u32)
+                .damage(*damage)
+                .into(),
+
+            Some(ItemNbt { damage: None }) | None => {
+                ItemStackBuilder::with_item(item).count(count as u32).into()
+            }
         }
     }
 }
@@ -252,7 +262,7 @@ where
     fn from(s: S) -> Self {
         let stack = s.borrow();
         Self {
-            damage: stack.damage.map(|d| d as i32),
+            damage: stack.damage_taken().map(|d| d as i32),
         }
     }
 }

feather/base/src/anvil/entity.rs

@@ -1,6 +1,7 @@
 //! Implements level.dat file loading.
 
-use generated::{Biome, Item};
+use libcraft_core::Biome;
+use libcraft_items::Item;
 use serde::{Deserialize, Serialize};
 use std::io::{Cursor, Read, Write};
 use std::{collections::HashMap, fs::File};

feather/base/src/anvil/level.rs

@@ -1,3 +1,4 @@
+use libcraft_items::{Item, ItemStack};
 use std::{
     collections::HashMap,
     fs,
@@ -9,7 +10,6 @@ use nbt::Value;
 use serde::{Deserialize, Serialize};
 use uuid::Uuid;
 
-use generated::{Item, ItemStack};
 use quill_common::components::{
     CanBuild, CanCreativeFly, CreativeFlying, CreativeFlyingSpeed, Instabreak, Invulnerable,
     WalkSpeed,
@@ -99,9 +99,9 @@ impl InventorySlot {
             Some(nbt)
         };
         Self {
-            count: stack.count as i8,
+            count: stack.count() as i8,
             slot,
-            item: stack.item.name().to_owned(),
+            item: stack.item().name().to_owned(),
             nbt,
         }
     }
@@ -222,8 +222,8 @@ mod tests {
         };
 
         let item_stack: ItemStack = slot.into();
-        assert_eq!(item_stack.item, Item::Feather);
-        assert_eq!(item_stack.count, 1);
+        assert_eq!(item_stack.item(), Item::Feather);
+        assert_eq!(item_stack.count(), 1);
     }
 
     #[test]
@@ -236,9 +236,9 @@ mod tests {
         };
 
         let item_stack: ItemStack = slot.into();
-        assert_eq!(item_stack.item, Item::DiamondAxe);
-        assert_eq!(item_stack.count, 1);
-        assert_eq!(item_stack.damage, Some(42));
+        assert_eq!(item_stack.item(), Item::DiamondAxe);
+        assert_eq!(item_stack.count(), 1);
+        assert_eq!(item_stack.damage_taken(), Some(42));
     }
 
     #[test]
@@ -251,7 +251,7 @@ mod tests {
         };
 
         let item_stack: ItemStack = slot.into();
-        assert_eq!(item_stack.item, Item::Air);
+        assert_eq!(item_stack.item(), Item::Air);
     }
 
     #[test]
@@ -285,7 +285,10 @@ mod tests {
             };
             assert_eq!(slot.convert_index().unwrap(), expected);
             assert_eq!(
-                InventorySlot::from_network_index(expected, ItemStack::new(Item::Stone, 1)),
+                InventorySlot::from_network_index(
+                    expected,
+                    ItemStack::new(Item::Stone, 1).unwrap()
+                ),
                 Some(slot),
             );
         }

feather/base/src/anvil/player.rs

@@ -10,7 +10,7 @@ use super::{block_entity::BlockEntityData, entity::EntityData};
 use bitvec::{bitvec, vec::BitVec};
 use blocks::BlockId;
 use byteorder::{BigEndian, ReadBytesExt, WriteBytesExt};
-use generated::Biome;
+use libcraft_core::Biome;
 use serde::{Deserialize, Serialize};
 use std::borrow::Cow;
 use std::collections::BTreeMap;

feather/base/src/anvil/region.rs

@@ -1,7 +1,7 @@
 use std::usize;
 
 use ::blocks::BlockId;
-use generated::Biome;
+use libcraft_core::Biome;
 
 use crate::ChunkPosition;
 

feather/base/src/chunk.rs

@@ -1,4 +1,4 @@
-use generated::Biome;
+use libcraft_core::Biome;
 
 use crate::{CHUNK_HEIGHT, CHUNK_WIDTH};
 

feather/base/src/chunk/biome_store.rs

@@ -20,9 +20,13 @@ pub use block::{BlockPositionValidationError, ValidBlockPosition};
 pub use blocks::*;
 pub use chunk::{Chunk, ChunkSection, CHUNK_HEIGHT, CHUNK_WIDTH};
 pub use chunk_lock::*;
-pub use generated::{Area, Biome, EntityKind, Inventory, Item, ItemStack};
+
 pub use libcraft_blocks::{BlockKind, BlockState};
-pub use libcraft_core::{position, vec3, BlockPosition, ChunkPosition, Gamemode, Position, Vec3d};
+pub use libcraft_core::{
+    position, vec3, Biome, BlockPosition, ChunkPosition, EntityKind, Gamemode, Position, Vec3d,
+};
+pub use libcraft_inventory::{Area, Inventory};
+pub use libcraft_items::{Item, ItemStack, ItemStackBuilder, ItemStackError};
 pub use libcraft_particles::{Particle, ParticleKind};
 pub use libcraft_text::{deserialize_text, Text, Title};
 #[doc(inline)]