core/txpool/legacypool: fix data race of pricedList access (ethereum#31758)

mirokuratczyk · jakub-freebit · commit 2f2a51513795 · 2025-07-03T14:04:34.000+09:00
diff --git a/core/txpool/legacypool/legacypool.go b/core/txpool/legacypool/legacypool.go
@@ -1934,7 +1934,7 @@ func (pool *LegacyPool) Clear() {
 		pool.reserver.Release(addr)
 	}
 	pool.all.Clear()
-	pool.priced = newPricedList(pool.all)
+	pool.priced.Reheap()
 	pool.pending = make(map[common.Address]*list)
 	pool.queue = make(map[common.Address]*list)
 	pool.pendingNonces = newNoncer(pool.currentState)

Original file line number	Diff line number	Diff line change
`@@ -1934,7 +1934,7 @@ func (pool *LegacyPool) Clear() {`
`1934`	`1934`	`pool.reserver.Release(addr)`
`1935`	`1935`	`}`
`1936`	`1936`	`pool.all.Clear()`
`1937`		`- pool.priced = newPricedList(pool.all)`
	`1937`	`+ pool.priced.Reheap()`
`1938`	`1938`	`pool.pending = make(map[common.Address]*list)`
`1939`	`1939`	`pool.queue = make(map[common.Address]*list)`
`1940`	`1940`	`pool.pendingNonces = newNoncer(pool.currentState)`