Skip to content

feat(ongoing-session): ensure current session follows new session #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(ongoing-session): ensure current session follows new session #883

wants to merge 1 commit into from

Conversation

ComputelessComputer
Copy link
Collaborator

@ComputelessComputer ComputelessComputer commented May 26, 2025 •
edited by coderabbitai bot
Loading

Ensure the current session context follows the newly started session. This is necessary to maintain the correct session context when a new session is started.

Summary by CodeRabbit

  • Bug Fixes
    • Improved session management to ensure the current session ID is accurately updated when starting a new session.

@ComputelessComputer
feat(ongoing-session): ensure current session follows new session
e8c61d8 
Ensure the current session context follows the newly started session. This is necessary to maintain the correct session context when a new session is started.
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 26, 2025 •
edited
Loading

Walkthrough

A call to update the current session ID in the global session store was added immediately after setting the local session state. This ensures the current session ID is explicitly synchronized in the session store when a session is started. No other logic or exported entities were changed.

Changes

File(s) Change Summary
packages/utils/src/stores/ongoing-session.ts Added explicit update to current session ID in the global session store after local state update.

Poem

In the warren of code where sessions begin,
A new hop ensures our states are akin.
With a twitch of the nose, IDs align,
Session and store now perfectly in line.
Hooray for the sync, as smooth as can be—
A rabbit’s delight in code harmony! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7055bb and e8c61d8.

📒 Files selected for processing (1)
  • packages/utils/src/stores/ongoing-session.ts (1 hunks)
🔇 Additional comments (1)
packages/utils/src/stores/ongoing-session.ts (1)

71-71: LGTM! Good synchronization between stores.

The addition of sessionsStore.getState().setCurrentSessionId(sessionId); ensures proper synchronization between the ongoing session store and the global sessions store. The placement is optimal - after setting local state but before accessing the session store.

This change directly addresses the PR objective of ensuring the current session follows the new session.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ComputelessComputer ComputelessComputer linked an issue May 26, 2025 that may be closed by this pull request
Transcript panel is NOT updating while listening to meetings #884
Open
@yujonglee yujonglee closed this May 26, 2025
@yujonglee yujonglee deleted the jj-branch-16 branch May 26, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transcript panel is NOT updating while listening to meetings
2 participants
@ComputelessComputer @yujonglee