Warn user when non-english is used with en-only model (#668)

ComputelessComputer · web-flow · commit c689f09127d2 · 2025-05-02T09:10:48.000-07:00
diff --git a/apps/desktop/src/components/settings/views/general.tsx b/apps/desktop/src/components/settings/views/general.tsx
@@ -6,6 +6,7 @@ import { useEffect } from "react";
 import { useForm } from "react-hook-form";
 import { z } from "zod";
 
+import { showModelSelectToast } from "@/components/toast/model-select";
 import { commands } from "@/types";
 import { commands as dbCommands, type ConfigGeneral } from "@hypr/plugin-db";
 import {
@@ -102,6 +103,10 @@ export default function General() {
       if (name === "autostart") {
         commands.setAutostart(!!value.autostart);
       }
+
+      if (name === "displayLanguage" && value.displayLanguage) {
+        showModelSelectToast(value.displayLanguage);
+      }
     });
 
     return () => subscription.unsubscribe();
diff --git a/apps/desktop/src/components/toast/index.tsx b/apps/desktop/src/components/toast/index.tsx
@@ -1,4 +1,4 @@
-import ModelDownloadNotification from "./model";
+import ModelDownloadNotification from "./model-download";
 import OtaNotification from "./ota";
 
 export default function Notifications() {
diff --git a/apps/desktop/src/components/toast/model-download.tsx b/apps/desktop/src/components/toast/model-download.tsx
diff --git a/apps/desktop/src/components/toast/model-select.tsx b/apps/desktop/src/components/toast/model-select.tsx
@@ -0,0 +1,40 @@
+import { commands as localSttCommands, SupportedModel } from "@hypr/plugin-local-stt";
+import { commands as windowsCommands } from "@hypr/plugin-windows";
+import { Button } from "@hypr/ui/components/ui/button";
+import { sonnerToast, toast } from "@hypr/ui/components/ui/toast";
+
+export async function showModelSelectToast(language: string) {
+  const currentModel = await localSttCommands.getCurrentModel();
+  const englishModels: SupportedModel[] = ["QuantizedTinyEn", "QuantizedBaseEn", "QuantizedSmallEn"];
+
+  if (language === "en" || !englishModels.includes(currentModel)) {
+    return;
+  }
+
+  const id = "language-model-mismatch";
+
+  toast({
+    id,
+    title: "Speech-to-Text Model Mismatch",
+    content: (
+      <div className="space-y-2">
+        <div>
+          English-only model can not be used with non-English languages.
+        </div>
+        <Button
+          variant="default"
+          onClick={() => {
+            windowsCommands.windowShow({ type: "settings" }).then(() => {
+              windowsCommands.windowEmitNavigate({ type: "settings" }, "/app/settings?tab=ai");
+            });
+
+            sonnerToast.dismiss(id);
+          }}
+        >
+          Open AI Settings
+        </Button>
+      </div>
+    ),
+    dismissible: true,
+  });
+}
diff --git a/apps/desktop/src/locales/en/messages.po b/apps/desktop/src/locales/en/messages.po
@@ -14,7 +14,7 @@ msgstr ""
 "Plural-Forms: \n"
 
 #. js-lingui-explicit-id
-#: src/components/settings/views/general.tsx:193
+#: src/components/settings/views/general.tsx:198
 msgid "Type jargons (e.g., Blitz Meeting, PaC Squad)"
 msgstr "Type jargons (e.g., Blitz Meeting, PaC Squad)"
 
@@ -365,7 +365,7 @@ msgstr "CEO"
 #~ msgid "Choose the language you want to use for the application interface"
 #~ msgstr "Choose the language you want to use for the application interface"
 
-#: src/components/settings/views/general.tsx:150
+#: src/components/settings/views/general.tsx:155
 msgid "Choose the language you want to use for the speech-to-text model and language model"
 msgstr "Choose the language you want to use for the speech-to-text model and language model"
 
@@ -555,7 +555,7 @@ msgstr "Get Started"
 msgid "Grant Access"
 msgstr "Grant Access"
 
-#: src/components/settings/views/general.tsx:124
+#: src/components/settings/views/general.tsx:129
 msgid "Help us improve Hyprnote by sharing anonymous usage data"
 msgstr "Help us improve Hyprnote by sharing anonymous usage data"
 
@@ -583,7 +583,7 @@ msgstr "Invite"
 msgid "Invite members"
 msgstr "Invite members"
 
-#: src/components/settings/views/general.tsx:181
+#: src/components/settings/views/general.tsx:186
 msgid "Jargons"
 msgstr "Jargons"
 
@@ -599,7 +599,7 @@ msgstr "Key decisions"
 msgid "Lab"
 msgstr "Lab"
 
-#: src/components/settings/views/general.tsx:147
+#: src/components/settings/views/general.tsx:152
 msgid "Language"
 msgstr "Language"
 
@@ -842,7 +842,7 @@ msgstr "Send invite"
 msgid "Settings"
 msgstr "Settings"
 
-#: src/components/settings/views/general.tsx:121
+#: src/components/settings/views/general.tsx:126
 msgid "Share usage data"
 msgstr "Share usage data"
 
@@ -1012,7 +1012,7 @@ msgstr "Works both in-person and remotely"
 msgid "Works offline"
 msgstr "Works offline"
 
-#: src/components/settings/views/general.tsx:184
+#: src/components/settings/views/general.tsx:189
 msgid "You can make Hyprnote takes these words into account when transcribing"
 msgstr "You can make Hyprnote takes these words into account when transcribing"
 
diff --git a/apps/desktop/src/locales/ko/messages.po b/apps/desktop/src/locales/ko/messages.po
@@ -14,7 +14,7 @@ msgstr ""
 "Plural-Forms: \n"
 
 #. js-lingui-explicit-id
-#: src/components/settings/views/general.tsx:193
+#: src/components/settings/views/general.tsx:198
 msgid "Type jargons (e.g., Blitz Meeting, PaC Squad)"
 msgstr ""
 
@@ -365,7 +365,7 @@ msgstr ""
 #~ msgid "Choose the language you want to use for the application interface"
 #~ msgstr ""
 
-#: src/components/settings/views/general.tsx:150
+#: src/components/settings/views/general.tsx:155
 msgid "Choose the language you want to use for the speech-to-text model and language model"
 msgstr ""
 
@@ -555,7 +555,7 @@ msgstr ""
 msgid "Grant Access"
 msgstr ""
 
-#: src/components/settings/views/general.tsx:124
+#: src/components/settings/views/general.tsx:129
 msgid "Help us improve Hyprnote by sharing anonymous usage data"
 msgstr ""
 
@@ -583,7 +583,7 @@ msgstr ""
 msgid "Invite members"
 msgstr ""
 
-#: src/components/settings/views/general.tsx:181
+#: src/components/settings/views/general.tsx:186
 msgid "Jargons"
 msgstr ""
 
@@ -599,7 +599,7 @@ msgstr ""
 msgid "Lab"
 msgstr ""
 
-#: src/components/settings/views/general.tsx:147
+#: src/components/settings/views/general.tsx:152
 msgid "Language"
 msgstr ""
 
@@ -842,7 +842,7 @@ msgstr ""
 msgid "Settings"
 msgstr ""
 
-#: src/components/settings/views/general.tsx:121
+#: src/components/settings/views/general.tsx:126
 msgid "Share usage data"
 msgstr ""
 
@@ -1012,7 +1012,7 @@ msgstr ""
 msgid "Works offline"
 msgstr ""
 
-#: src/components/settings/views/general.tsx:184
+#: src/components/settings/views/general.tsx:189
 msgid "You can make Hyprnote takes these words into account when transcribing"
 msgstr ""
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import ModelDownloadNotification from "./model";`
	`1`	`+import ModelDownloadNotification from "./model-download";`
`2`	`2`	`import OtaNotification from "./ota";`
`3`	`3`
`4`	`4`	`export default function Notifications() {`