optimize conv transpose resource to get it working reasonably well. may still have slight optimization left

Author: Jonathan-Shoemaker

hls4ml/templates/vivado/nnet_utils/nnet_conv1dtranspose_resource.h

@@ -30,33 +30,41 @@ void conv_1d_transpose_resource_cl(
     typename CONFIG_T::accum_t acc[CONFIG_T::n_pixels][mult_n_out][CONFIG_T::stride_width];
     #pragma HLS ARRAY_PARTITION variable=acc complete dim=0
 
-    typename CONFIG_T::weight_t trfilt_weights[CONFIG_T::stride_width][
+    typename CONFIG_T::weight_t trfilt_weights[
         CONFIG_T::trfilt_width * CONFIG_T::n_filt * CONFIG_T::n_chan
-    ];
+    ][CONFIG_T::stride_width];
 
     for (unsigned i_sw = 0; i_sw < CONFIG_T::stride_width; i_sw++) {
+        #pragma HLS UNROLL
+
         for (unsigned i_fw = 0; i_fw < CONFIG_T::trfilt_width; i_fw++) {
+            #pragma HLS UNROLL
+
             unsigned filt_ind = i_sw + (CONFIG_T::trfilt_width-i_fw-1)*CONFIG_T::stride_width;
             for (unsigned i_nf = 0; i_nf < CONFIG_T::n_filt; i_nf++) {
+                #pragma HLS UNROLL
+
                 for (unsigned i_nc = 0; i_nc < CONFIG_T::n_chan; i_nc++) {
-                    if (i_fw < CONFIG_T::filt_width) {
-                        trfilt_weights[i_sw][
+                    #pragma HLS UNROLL
+                    
+                    if (filt_ind < CONFIG_T::filt_width) {
+                        trfilt_weights[
                             i_nf * CONFIG_T::n_chan * CONFIG_T::trfilt_width + i_fw  * CONFIG_T::n_chan + i_nc
-                        ] = weights[
+                        ][i_sw] = weights[
                             filt_ind * CONFIG_T::n_filt * CONFIG_T::n_chan + i_nf * CONFIG_T::n_chan + i_nc
                         ];
                     }
                     else {
-                        trfilt_weights[i_sw][
+                        trfilt_weights[
                             i_fw * CONFIG_T::n_chan + i_nf * CONFIG_T::n_chan * CONFIG_T::trfilt_width + i_nc
-                        ] = 0;
+                        ][i_sw] = 0;
                     }
                 }
             }
         }
     }
 
-    #pragma HLS ARRAY_RESHAPE variable=trfilt_weights block factor=block_factor dim=2
+    #pragma HLS ARRAY_RESHAPE variable=trfilt_weights block factor=block_factor dim=1
 
     PartitionLoop:
     for (unsigned i_part = 0; i_part < CONFIG_T::n_partitions; i_part++) {
@@ -101,7 +109,7 @@ void conv_1d_transpose_resource_cl(
 
                         acc[i_pxl][i_out][i_sw] += static_cast<typename CONFIG_T::accum_t>(
                             CONFIG_T::mult_config::template product<data_T, typename CONFIG_T::mult_config::weight_t>::product(
-                                data_buf[i_pxl][i_in], trfilt_weights[i_sw][i_w]
+                                data_buf[i_pxl][i_in], trfilt_weights[i_w][i_sw]
                             )
                         );
                     }
@@ -124,21 +132,25 @@ void conv_1d_transpose_resource_cl(
             }
         }
 
+
         PixelResultLoop:
         for (unsigned i_pxl = 0; i_pxl < CONFIG_T::n_pixels; i_pxl++) {
             #pragma HLS UNROLL
 
             StrideResultLoop:
             for (unsigned i_sw = 0; i_sw < CONFIG_T::stride_width; i_sw++) {
                 #pragma HLS UNROLL
+
+                unsigned output_index = i_pxl * CONFIG_T::n_partitions * CONFIG_T::stride_width + 
+                    i_part * CONFIG_T::stride_width + i_sw;
 
-                if (i_pxl * CONFIG_T::n_partitions * CONFIG_T::stride_width + i_part * CONFIG_T::stride_width + i_sw >= CONFIG_T::pad_left && 
-                    i_pxl * CONFIG_T::n_partitions * CONFIG_T::stride_width + i_part * CONFIG_T::stride_width + i_sw < CONFIG_T::out_width + CONFIG_T::pad_left) {
+                if (output_index >= CONFIG_T::pad_left && 
+                    output_index < CONFIG_T::out_width + CONFIG_T::pad_left) {
                     ResultLoop:
                     for (unsigned i_res = 0; i_res < mult_n_out; i_res++) {
                         #pragma HLS UNROLL
 
-                        *(res++) = cast<data_T, res_T, typename CONFIG_T::mult_config>(acc[i_pxl][i_res][i_sw]);
+                        res[output_index][i_res] = cast<data_T, res_T, typename CONFIG_T::mult_config>(acc[i_pxl][i_res][i_sw]);
                     }
                 }
             }