Skip to content

Commit 24a5844

Browse files
authored
types: merge duplicate FastifyCookieOptions interface exports (#318)
1 parent b9fcf13 commit 24a5844

File tree

2 files changed

+10
-16
lines changed

2 files changed

+10
-16
lines changed

types/plugin.d.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,6 @@ declare namespace fastifyCookie {
145145

146146
type HookType = 'onRequest' | 'preParsing' | 'preValidation' | 'preHandler' | 'preSerialization'
147147

148-
export interface FastifyCookieOptions {
149-
secret?: string | string[] | Buffer | Buffer[] | Signer;
150-
hook?: HookType | false;
151-
parseOptions?: fastifyCookie.CookieSerializeOptions;
152-
}
153-
154148
export type Sign = (value: string, secret: string | Buffer, algorithm?: string) => string
155149
export type Unsign = (input: string, secret: string | Buffer, algorithm?: string) => UnsignResult
156150
export type SignerFactory = (secrets: string | string[] | Buffer | Buffer[], algorithm?: string) => SignerBase
@@ -181,8 +175,9 @@ declare namespace fastifyCookie {
181175
export const fastifyCookie: FastifyCookie
182176

183177
export interface FastifyCookieOptions {
184-
secret?: string | string[] | Buffer | Buffer[] | SignerBase;
178+
secret?: string | string[] | Buffer | Buffer[] | Signer | SignerBase;
185179
algorithm?: string;
180+
hook?: HookType | false;
186181
parseOptions?: CookieSerializeOptions;
187182
}
188183

types/plugin.test-d.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,22 @@
1-
import cookie from '..'
21
import { expectError, expectType } from 'tsd'
32
import * as fastifyCookieStar from '..'
43
import fastifyCookieCjsImport = require('..')
5-
import fastifyCookieDefault, { fastifyCookie as fastifyCookieNamed, Signer } from '..'
4+
import cookie, { fastifyCookie as fastifyCookieNamed, Signer } from '..'
65
import fastify, { FastifyInstance, FastifyReply, setCookieWrapper } from 'fastify'
76

87
const fastifyCookieCjs = require('..')
98

109
const app: FastifyInstance = fastify()
1110
app.register(fastifyCookieNamed)
12-
app.register(fastifyCookieDefault)
11+
app.register(cookie)
1312
app.register(fastifyCookieCjs)
1413
app.register(fastifyCookieCjsImport.default)
1514
app.register(fastifyCookieCjsImport.fastifyCookie)
1615
app.register(fastifyCookieStar.default)
1716
app.register(fastifyCookieStar.fastifyCookie)
1817

1918
expectType<fastifyCookieStar.FastifyCookie>(fastifyCookieNamed)
20-
expectType<fastifyCookieStar.FastifyCookie>(fastifyCookieDefault)
19+
expectType<fastifyCookieStar.FastifyCookie>(cookie)
2120
expectType<fastifyCookieStar.FastifyCookie>(fastifyCookieCjsImport.default)
2221
expectType<fastifyCookieStar.FastifyCookie>(fastifyCookieCjsImport.fastifyCookie)
2322
expectType<fastifyCookieStar.FastifyCookie>(fastifyCookieStar.default)
@@ -26,9 +25,9 @@ expectType<fastifyCookieStar.FastifyCookie>(
2625
)
2726
expectType<any>(fastifyCookieCjs)
2827

29-
expectType<fastifyCookieStar.Sign>(fastifyCookieDefault.sign)
30-
expectType<fastifyCookieStar.Unsign>(fastifyCookieDefault.unsign)
31-
expectType<fastifyCookieStar.SignerFactory >(fastifyCookieDefault.signerFactory)
28+
expectType<fastifyCookieStar.Sign>(cookie.sign)
29+
expectType<fastifyCookieStar.Unsign>(cookie.unsign)
30+
expectType<fastifyCookieStar.SignerFactory >(cookie.signerFactory)
3231

3332
expectType<fastifyCookieStar.Sign>(fastifyCookieNamed.sign)
3433
expectType<fastifyCookieStar.Unsign>(fastifyCookieNamed.unsign)
@@ -246,5 +245,5 @@ appWithHook.register(cookie, { hook: 'preValidation' })
246245
expectError(appWithHook.register(cookie, { hook: true }))
247246
expectError(appWithHook.register(cookie, { hook: 'false' }))
248247

249-
expectType<(cookieHeader: string, opts?: fastifyCookieStar.ParseOptions) => { [key: string]: string }>(fastifyCookieDefault.parse)
250-
expectType<(name: string, value: string, opts?: fastifyCookieStar.SerializeOptions) => string>(fastifyCookieDefault.serialize)
248+
expectType<(cookieHeader: string, opts?: fastifyCookieStar.ParseOptions) => { [key: string]: string }>(cookie.parse)
249+
expectType<(name: string, value: string, opts?: fastifyCookieStar.SerializeOptions) => string>(cookie.serialize)

0 commit comments

Comments
 (0)